[Bug 5543] New: Date ISO format wrong separator
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5543 Summary: Date ISO format wrong separator Change sponsored?: --- Product: Koha Version: rel_3_2 Platform: All OS/Version: All Status: NEW Severity: minor Priority: P5 Component: I18N/L10N AssignedTo: frederic@tamil.fr ReportedBy: fridolyn.somers@gmail.com QAContact: koha-bugs@lists.koha-community.org Estimated Hours: 0.0 Hie, In code Dates.pm, iso date format is defined as : iso => 'yyyy-mm-dd' But in system preference, iso is displayed as : 'yyyy/mm/dd'. Same in "date-format.inc". Regards, -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5543 --- Comment #1 from Fridolyn SOMERS <fridolyn.somers@gmail.com> 2010-12-27 13:07:16 UTC --- Created attachment 2907 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2907 Proposed patch Replace "/" by "-". Note that when date is defined using javascript calendar date containes "-". -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5543 Fridolyn SOMERS <fridolyn.somers@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #2907|0 |1 is obsolete| | --- Comment #2 from Fridolyn SOMERS <fridolyn.somers@gmail.com> 2011-04-07 10:03:34 UTC --- Created attachment 3779 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3779 Proposed patch updated (generated with git format-patch) Updated patch with git command this time. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5543 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3779|0 |1 is obsolete| | Status|NEW |ASSIGNED AssignedTo|frederic@tamil.fr |oleonard@myacpl.org --- Comment #3 from Owen Leonard <oleonard@myacpl.org> 2011-12-07 17:21:30 UTC --- Created attachment 6640 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6640 Revised fix This patch converts the changes in Fridolyn Somers' patch to T:T and adds an update to the database to correct the description there. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5543 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5543 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_2 |master -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5543 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6640|0 |1 is obsolete| | --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> 2011-12-10 09:47:10 UTC --- Created attachment 6697 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6697 Bug 5543 - Date ISO format wrong separator This patch converts the changes in Fridolyn SOMERS patch to T:T and adds an update to the database to correct the description there. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5543 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5543 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-13 13:48:02 UTC --- QA question: is the updatedatabase really needed for the description? I thought the description in systempreference was now deprecated in favor of the .pref (translatable) file -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5543 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> 2011-12-13 13:54:10 UTC --- (In reply to comment #5)
is the updatedatabase really needed for the description?
I wasn't sure myself, but I wanted to be thorough. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5543 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.walls@bywatersolutions. | |com Patch Status|Signed Off |Passed QA --- Comment #7 from Ian Walls <ian.walls@bywatersolutions.com> 2011-12-21 22:27:09 UTC --- I'm going to say good to Owen's thoroughness on this. Best to clean up all these little details as soon as we can, rather than assuming they won't be a problem, and being confused later on. Simple change, marking Passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5543 --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-27 17:31:37 UTC --- Ian, I feel/fear you've misunderstood my question: the explanation column in systempreference is now useless. What we use is the description in i18n_l10n.pref (fix that is also included) So, unless i'm mistaking somewhere, the updatedatabase is strictly useless, and we should have a bug entry for removing the explanation field. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5543 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-27 17:34:41 UTC --- The column is still needed for local use system preferences, but it could be emptied for normal system preferences. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5543 --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> 2012-01-03 17:08:32 UTC --- OK, katrin you confirm it's useless in this case. i'll push the patch without the updatedatabase stuff then, and open a bug to empty descriptions of sysprefs that are not local (question: how can we identify them ?) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5543 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |rel_3_6 Patch Status|Passed QA |Patch Pushed --- Comment #11 from Paul Poulain <paul.poulain@biblibre.com> 2012-01-10 22:31:24 UTC --- Patch pushed, please test (removed the updatedatabase stuff, that is useless -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5543 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #12 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This will be included in the upcoming 3.6.5 release. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org