[Bug 22860] New: Selenium tests authentication.t does not remove all data it created
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22860 Bug ID: 22860 Summary: Selenium tests authentication.t does not remove all data it created Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Test Suite Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Depends on: 19181 Target Milestone: --- 1 patron will remain in the DB after the tests ran. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19181 [Bug 19181] Intranet and OPAC authentication selenium test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22860 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22860 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 89400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89400&action=edit Bug 22860: Remove 1 remaining patron after authentication.t is ran Test plan: 0/ Do not apply the patch 1/ select count(*) from borrowers; 2/ Run the tests => Notice that you have 1 more patron 3/ Apply the patch and repeat 1/ and 2/ => Notice that you have the same number of patrons before and after the tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22860 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley@catalyst.net.n | |z --- Comment #2 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- I tried to test this, but was unable to replicate on master. Borrower count was 2, I ran prove t/db_dependent/selenium/authentication.t, then checked my borrower count again, and it was two. Have I missed a step here? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22860 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Can you try that: kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ git fetch origin kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ git checkout -B master origin/master kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ koha-mysql kohadev -e "select count(*) from borrowers;" +----------+ | count(*) | +----------+ | 99 | +----------+ kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/selenium/authentication.t t/db_dependent/selenium/authentication.t .. ok All tests successful. Files=1, Tests=2, 24 wallclock secs ( 0.02 usr 0.02 sys + 2.07 cusr 0.76 csys = 2.87 CPU) Result: PASS kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ koha-mysql kohadev -e "select count(*) from borrowers;" +----------+ | count(*) | +----------+ | 100 | +----------+ The selenium server must have been started before (in a devbox you can use the `start_selenium` alias) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22860 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22860 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89400|0 |1 is obsolete| | --- Comment #4 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Created attachment 97771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97771&action=edit Bug 22860: Remove 1 remaining patron after authentication.t is ran Test plan: 0/ Do not apply the patch 1/ select count(*) from borrowers; 2/ Run the tests => Notice that you have 1 more patron 3/ Apply the patch and repeat 1/ and 2/ => Notice that you have the same number of patrons before and after the tests Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22860 Bouzid Fergani <bouzid.fergani@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bouzid.fergani@inlibro.com --- Comment #5 from Bouzid Fergani <bouzid.fergani@inlibro.com> --- Hi, I can't reproduce this issue in the updated master mysql> select count(*) from borrowers; +----------+ | count(*) | +----------+ | 68379 | +----------+ prove t/db_dependent/selenium/authentication.t t/db_dependent/selenium/authentication.t .. ok All tests successful. Files=1, Tests=2, 1 wallclock secs ( 0.02 usr 0.00 sys + 1.68 cusr 0.11 csys = 1.81 CPU) Result: PASS mysql> select count(*) from borrowers; +----------+ | count(*) | +----------+ | 68379 | +----------+ You can check this please. Thanks. Bouzid. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22860 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I can replicate the issue on master - trying the fix next. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22860 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22860 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97771|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 98615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98615&action=edit Bug 22860: Remove 1 remaining patron after authentication.t is ran Test plan: 0/ Do not apply the patch 1/ select count(*) from borrowers; 2/ Run the tests => Notice that you have 1 more patron 3/ Apply the patch and repeat 1/ and 2/ => Notice that you have the same number of patrons before and after the tests Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22860 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22860 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22860 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.04 released in| | CC| |joy@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #9 from Joy Nelson <joy@bywatersolutions.com> --- Pushed to 19.11.x branch for 19.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22860 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22860 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.04 |20.05.00, 19.11.04, released in| |19.05.09 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org