[Bug 27023] New: Add class names in the suggestions column in Suggestions management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27023 Bug ID: 27023 Summary: Add class names in the suggestions column in Suggestions management Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org There is a lot of info. that goes into the Suggestions column in '/cgi-bin/koha/suggestion/suggestion.pl'. It's currently hard to parse that different information out if you wanted to do something like change the color of the text for each item type. It would be trivial to add class names. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27023 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27023 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 113635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113635&action=edit Bug 27023: Add class names in acq suggestion table (suggestions column) Test plan: 1. Apply patch 2. Add some suggestions via the OPAC, fill out all the input fields 3. Go to the suggestion managemnet page and look specficially at the Suggestions column. 4. There should be no display change in the table but you should now <span> with classes like 'suggestion_coprightdate', suggestion_isbn, suggestion_publishercode, suggestion_collectiontitle, and suggestion_itype -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27023 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27023 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113635|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 113640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113640&action=edit Bug 27023: Add class names in acq suggestion table (suggestions column) Test plan: 1. Apply patch 2. Add some suggestions via the OPAC, fill out all the input fields 3. Go to the suggestion managemnet page and look specficially at the Suggestions column. 4. There should be no display change in the table but you should now <span> with classes like 'suggestion_coprightdate', suggestion_isbn, suggestion_publishercode, suggestion_collectiontitle, and suggestion_itype Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27023 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27023 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27023 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113640|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 114994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114994&action=edit Bug 27023: Add class names in acq suggestion table (suggestions column) Test plan: 1. Apply patch 2. Add some suggestions via the OPAC, fill out all the input fields 3. Go to the suggestion managemnet page and look specficially at the Suggestions column. 4. There should be no display change in the table but you should now <span> with classes like 'suggestion_coprightdate', suggestion_isbn, suggestion_publishercode, suggestion_collectiontitle, and suggestion_itype Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27023 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 114995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114995&action=edit Bug 27023: (QA follow-up) Fix span tags One of the opening tags was missing the > and another was in the wrong spot (started after the IF, but ending outside ouf it) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27023 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add class names in the |Add class names in the |suggestions column in |suggestions column in |Suggestions management |suggestions management -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27023 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Passed QA |Failed QA --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Typo suggestion_coprightdate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27023 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27023 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114994|0 |1 is obsolete| | --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 115209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115209&action=edit Bug 27023: Add class names in acq suggestion table (suggestions column) Test plan: 1. Apply patch 2. Add some suggestions via the OPAC, fill out all the input fields 3. Go to the suggestion managemnet page and look specficially at the Suggestions column. 4. There should be no display change in the table but you should now <span> with classes like 'suggestion_coprightdate', suggestion_isbn, suggestion_publishercode, suggestion_collectiontitle, and suggestion_itype Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27023 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Lucas, did you see my follow-up patch? Sequence of attachements is wrong now, but not sure if you tested with or without. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27023 --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 115213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115213&action=edit Bug 27023: Add class names in acq suggestion table (suggestions column) Test plan: 1. Apply patch 2. Add some suggestions via the OPAC, fill out all the input fields 3. Go to the suggestion managemnet page and look specficially at the Suggestions column. 4. There should be no display change in the table but you should now <span> with classes like 'suggestion_coprightdate', suggestion_isbn, suggestion_publishercode, suggestion_collectiontitle, and suggestion_itype Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27023 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114995|0 |1 is obsolete| | --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 115214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115214&action=edit Bug 27023: (QA follow-up) Fix span tags One of the opening tags was missing the > and another was in the wrong spot (started after the IF, but ending outside ouf it) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27023 --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #7)
Hi Lucas, did you see my follow-up patch? Sequence of attachements is wrong now, but not sure if you tested with or without.
Sorry about that. I have tested with your QA follow-up. I the reattached them in the correct order. I am still keeping David's SO line. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27023 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115209|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27023 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27023 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115213|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 115220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115220&action=edit Bug 27023: Add class names in acq suggestion table (suggestions column) Test plan: 1. Apply patch 2. Add some suggestions via the OPAC, fill out all the input fields 3. Go to the suggestion managemnet page and look specficially at the Suggestions column. 4. There should be no display change in the table but you should now <span> with classes like 'suggestion_coprightdate', suggestion_isbn, suggestion_publishercode, suggestion_collectiontitle, and suggestion_itype Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27023 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115214|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 115221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115221&action=edit Bug 27023: (QA follow-up) Fix span tags One of the opening tags was missing the > and another was in the wrong spot (started after the IF, but ending outside ouf it) Move spaces around a bit so the strings don't start with spaces. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27023 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27023 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27023 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00 |21.05.00,20.11.03 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m --- Comment #14 from Fridolin Somers <fridolin.somers@biblibre.com> --- Small enhancement, I choose to backport. Pushed to 20.11.x for 20.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27023 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #15 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Enhancement, not backporting to 20.05. Please ask if needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27023 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27023 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds release notes| |classes to the various | |information spans displayed | |in the suggestions table. | |This allows for simple | |targeting of css rules to | |highlight or hide | |information that is | |important/irrelevant for | |your libraries use. CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27023 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement adds |This enhancement adds release notes|classes to the various |classes to the various |information spans displayed |information spans displayed |in the suggestions table. |in the suggestions table. |This allows for simple |This allows for simple |targeting of css rules to |targeting of CSS rules to |highlight or hide |highlight or hide |information that is |information that is |important/irrelevant for |important/irrelevant for |your libraries use. |your libraries use. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27023 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement adds |This enhancement adds release notes|classes to the various |classes to the various |information spans displayed |information spans displayed |in the suggestions table. |in the suggestions table. |This allows for simple |This allows for simple |targeting of CSS rules to |targeting of CSS rules to |highlight or hide |highlight or hide |information that is |information that is |important/irrelevant for |important/irrelevant for |your libraries use. |your library's use. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27023 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org