[Bug 21593] New: DBD::mysql::st execute failed: 'koha_kohadev.me.id' when paying fees on paycollect.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21593 Bug ID: 21593 Summary: DBD::mysql::st execute failed: 'koha_kohadev.me.id' when paying fees on paycollect.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: alexbuckley@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org When going to pay a users fine the following error is displayed: Template process failed: undef error - DBIx::Class::Storage::DBI::_dbh_execute(): 'koha_kohadev.me.id' isn't in GROUP BY at /home/vagrant/kohaclone/Koha/Objects.pm line 129 at /home/vagrant/kohaclone/C4/Templates.pm line 122 Viewing the logs you see this is caused by this DB error: DBD::mysql::st execute failed: 'koha_kohadev.me.id' isn't in GROUP BY [for Statement "SELECT `me`.`id`, `me`.`category`, `me`.`authorised_value`, `me`.`lib`, `me`.`lib_opac`, `me`.`imageurl` FROM `authorised_values` `me` LEFT JOIN `authorised_values_branches` `authorised_values_branches` ON `authorised_values_branches`.`av_id` = `me`.`id` WHERE ( ( ( `authorised_values_branches`.`branchcode` IS NULL OR `authorised_values_branches`.`branchcode` = ? ) AND `category` = ? ) ) GROUP BY `lib` ORDER BY `category`, `lib`, `lib_opac`" with ParamValues: 0="CPL", 1='PAYMENT_TYPE'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832. Doing a git bisect I found this error started when the patch 20521 was pushed to master: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20521 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21593 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20521 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21593 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Fines and fees |Architecture, internals, | |and plumbing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21593 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21593 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 80800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80800&action=edit Bug 21593: Remove GROUP BY from GetAuthValueDropbox With new MYSQL modes we are permitted only full group by. In this case I don't think we need a GROUP BY at all To test: 1 - Try to pay a fine or create a borrower 2 - Internal server error 3 - Apply patch 4 - Page should load 5 - Test various authorised values ot ensure they work e.g. Set bsort1 and bsort2 to have some authorised values with and without branch limits set PAYMENT_TYPE to have some values with and without branch limits -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21593 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|DBD::mysql::st execute |Remove Group by clause in |failed: |GetAuthValueDropbox |'koha_kohadev.me.id' when | |paying fees on | |paycollect.pl | CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21593 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21593 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21593 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This looks sane and the code scans.. Trivial change and I can't see any reason we would need the group_by clause here. I'm running through the whole test suite to check for any fallout but then I think it's a 'straight to QA' candidate. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21593 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80800|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 80803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80803&action=edit Bug 21593: Remove GROUP BY from GetAuthValueDropbox With new MYSQL modes we are permitted only full group by. In this case I don't think we need a GROUP BY at all To test: 1 - Try to pay a fine or create a borrower 2 - Internal server error 3 - Apply patch 4 - Page should load 5 - Test various authorised values ot ensure they work e.g. Set bsort1 and bsort2 to have some authorised values with and without branch limits set PAYMENT_TYPE to have some values with and without branch limits Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21593 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21593 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Tests pass, QA script pass, test plan pass. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21593 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- ok for me, I had the same fix. However I noted: Hum This one is weird, I have no idea why there is a group by lib here. This patch will introduce a change in behaviour /!\ If several AV have the same description they will not all be displayed in the dropdown list. But it seems like a bug fix, otherwise only 1 will be display, but the user will not know that there are two different codes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21593 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21597 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21597 [Bug 21597] [OMNIBUS] Test suite is still failing with new default SQL modes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21593 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21593 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21593 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- I prefer not change behaviour in oldstable 17.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21593 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org