[Bug 8315] New: fix 'C4::Output 3.02' errors in Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8315 Priority: P5 - low Change sponsored?: --- Bug ID: 8315 Assignee: gmcharlt@gmail.com Summary: fix 'C4::Output 3.02' errors in Koha Severity: major Classification: Unclassified OS: All Reporter: mtj@kohaaloha.com Hardware: All Status: NEW Version: master Component: Architecture, internals, and plumbing Product: Koha some lines in Koha have a hardcode version, like this... use C4::Output 3.02 which cause a version-mismatch error, like this... C4::Output version 3.02 required--this is only version 3.07.00.049 at review.pl line 33 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8315 --- Comment #1 from Mason James <mtj@kohaaloha.com> --- Created attachment 10483 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10483&action=edit Bug 8315 - fix 'C4::Output 3.02' errors in Koha modified: opac/opac-ratings-ajax.pl modified: opac/opac-tags.pl modified: tags/review.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8315 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8315 --- Comment #2 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #1)
Created attachment 10483 [details] Bug 8315 - fix 'C4::Output 3.02' errors in Koha
i've sent a patch that removes the unneeded '3.02' part only 3 lines are changed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8315 --- Comment #3 from Robin Sheat <robin@catalyst.net.nz> --- Created attachment 10490 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10490&action=edit Bug 8315 - fix 'C4::Output 3.02' errors in Koha modified: opac/opac-ratings-ajax.pl modified: opac/opac-tags.pl modified: tags/review.pl Signed-off-by: Robin Sheat <robin@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8315 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |robin@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8315 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7941 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8315 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Bug 7941 introduces issues in some pages. 3 are list in this bug, but others exist. At least: tags/list.pl:use C4::Tags 0.03 qw(get_tags remove_tag get_tag_rows); tags/review.pl:use C4::Tags 0.03 qw(get_tags get_approval_rows approval_counts whitelist blacklist is_approved); Marking as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8315 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Interesting those use lines have been there since 2008, it's only now we actually have accurate version numbers on our modules that they are causing a breakage. Still they definitely shouldn't be there. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8315 --- Comment #6 from Robin Sheat <robin@catalyst.net.nz> --- On 3.8.2, I see the following things that use versioning: $ grep -rPe '^\s*use\s+[^\s]+\s+\d' * C4/Creators/Template.pm:use C4::Creators::Profile 1.000000; C4/Creators/Template.pm:use C4::Creators::Lib 1.000000 qw(get_unit_values); C4/Creators/Profile.pm:use C4::Creators::Lib 1.000000 qw(get_unit_values); C4/Patroncards.pm: use C4::Patroncards::Batch 1.000000; C4/Patroncards.pm: use C4::Patroncards::Layout 1.000000; C4/Patroncards.pm: use C4::Patroncards::Lib 1.000000; C4/Patroncards.pm: use C4::Patroncards::Patroncard 1.000000; C4/Patroncards.pm: use C4::Patroncards::Profile 1.000000; C4/Patroncards.pm: use C4::Patroncards::Template 1.000000; C4/Labels.pm: use C4::Labels::Batch 1.000000; C4/Labels.pm: use C4::Labels::Label 1.000000; C4/Labels.pm: use C4::Labels::Layout 1.000000; C4/Labels.pm: use C4::Labels::Profile 1.000000; C4/Labels.pm: use C4::Labels::Template 1.000000; C4/Creators.pm: use C4::Creators::Lib 1.000000; C4/Creators.pm: use C4::Creators::PDF 1.000000; C4/Installer.pm:use C4::Installer::PerlModules 1.000000; C4/Patroncards/Patroncard.pm:use C4::Creators::Lib 1.000000 qw(get_font_types); C4/Patroncards/Patroncard.pm:use C4::Creators::PDF 1.000000 qw(StrWidth); C4/Patroncards/Patroncard.pm:use C4::Patroncards::Lib 1.000000 qw(unpack_UTF8 text_alignment leading box get_borrower_attributes); labels/label-manage.pl:use C4::Creators 1.000000; labels/label-manage.pl:use C4::Labels 1.000000; labels/label-create-csv.pl:use C4::Creators 1.000000; labels/label-create-csv.pl:use C4::Labels 1.000000; labels/label-create-xml.pl:use C4::Creators 1.000000; labels/label-create-xml.pl:use C4::Labels 1.000000; labels/label-print.pl:use C4::Creators::Lib 1.000000 qw(get_all_templates get_all_layouts get_output_formats); labels/label-print.pl:use C4::Labels::Batch 1.000000; labels/label-create-pdf.pl:use C4::Creators 1.000000; labels/label-create-pdf.pl:use C4::Labels 1.000000; labels/label-edit-batch.pl:use C4::Creators 1.000000; labels/label-edit-batch.pl:use C4::Labels 1.000000; labels/label-edit-profile.pl:use C4::Creators 1.000000; labels/label-edit-profile.pl:use C4::Labels 1.000000; labels/label-edit-layout.pl:use C4::Creators 1.000000; labels/label-edit-layout.pl:use C4::Labels 1.000000; labels/label-edit-template.pl:use C4::Creators 1.000000; labels/label-edit-template.pl:use C4::Labels 1.000000; misc/cronjobs/overdue_notices.pl:use Locale::Currency::Format 1.28; opac/opac-ratings-ajax.pl:use C4::Output 3.02 qw(:html :ajax pagination_bar); opac/opac-tags.pl:use C4::Output 3.02 qw(:html :ajax pagination_bar); patroncards/image-manage.pl:use C4::Creators 1.000000; patroncards/image-manage.pl:use C4::Patroncards 1.000000; patroncards/create-pdf.pl:use C4::Creators 1.000000; patroncards/create-pdf.pl:use C4::Patroncards 1.000000; patroncards/manage.pl:use C4::Creators 1.000000; patroncards/manage.pl:use C4::Patroncards 1.000000; patroncards/manage.pl:use C4::Labels 1.000000; patroncards/edit-template.pl:use C4::Creators 1.000000; patroncards/edit-template.pl:use C4::Patroncards 1.000000; patroncards/edit-layout.pl:use C4::Creators 1.000000; patroncards/edit-layout.pl:use C4::Patroncards 1.000000; patroncards/card-print.pl:use C4::Creators 1.000000; patroncards/card-print.pl:use C4::Labels 1.000000; patroncards/edit-batch.pl:use C4::Creators 1.000000; patroncards/edit-batch.pl:use C4::Patroncards 1.000000; patroncards/print.pl:use C4::Creators 1.000000; patroncards/print.pl:use C4::Patroncards 1.000000; patroncards/edit-profile.pl:use C4::Creators::Lib 1.000000 qw(get_all_templates get_unit_values); patroncards/edit-profile.pl:use C4::Patroncards::Profile 1.000000; tags/list.pl:use C4::Tags 0.03 qw(get_tags remove_tag get_tag_rows); tags/review.pl:use C4::Output 3.02 qw(:html :ajax pagination_bar); tags/review.pl:use C4::Tags 0.03 qw(get_tags get_approval_rows approval_counts whitelist blacklist is_approved); tools/manage-marc-import.pl:use C4::Labels::Batch 1.000000; -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8315 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpavlin@rot13.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8315 --- Comment #7 from Dobrica Pavlinusic <dpavlin@rot13.org> --- I would love for this to land in master ASAP because it breaks our production, but I would be also happy with patch with removes all versions as Robin pointed out in comment #6... Should I submit one? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8315 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10483|0 |1 is obsolete| | --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> --- Comment on attachment 10483 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10483 Bug 8315 - fix 'C4::Output 3.02' errors in Koha Robin, seems you forgot to obsolete the original patch when you uploaded the signed-off one -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8315 --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- This still needs a follow up for all the other version numbers Robin listed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8315 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10490|0 |1 is obsolete| | --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> --- Comment on attachment 10490 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10490 Bug 8315 - fix 'C4::Output 3.02' errors in Koha This patch has been pushed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8315 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |ASSIGNED CC| |paul.poulain@biblibre.com Version|master |rel_3_8 Assignee|gmcharlt@gmail.com |dpavlin@rot13.org --- Comment #11 from Paul Poulain <paul.poulain@biblibre.com> --- Switching back to "assigned", the patch provided has been pushed, other patches welcomed ! Assigning to Dobrica, as you seem to be motivated by this topic ;-) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8315 --- Comment #12 from Chris Cormack <chris@bigballofwax.co.nz> --- First patch pushed to 3.8.x -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8315 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christophe.croullebois@bibl | |ibre.com --- Comment #13 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- *** Bug 8344 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8315 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #14 from Nicole C. Engard <nengard@gmail.com> --- *** Bug 8354 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8315 mourik jan <heupink@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |heupink@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8315 --- Comment #15 from Dobrica Pavlinusic <dpavlin@rot13.org> --- Created attachment 10801 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10801&action=edit Bug 8315 - remove use C4::* version This patch touches a lot of code, but basically it removes version information from use C4::* in our code. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8315 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8315 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10801|0 |1 is obsolete| | --- Comment #16 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 10803 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10803&action=edit Bug 8315 - remove use C4::* version This patch touches a lot of code, but basically it removes version information from use C4::* in our code. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8315 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8315 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #17 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA Comment: Remove the version informations when we use a module. C4::Labels[::*], use C4::Creators::*, C4::Installer::PerlModules, C4::Patroncards[::*], Locale::Currency::Format and C4::Tags Marking as Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8315 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8315 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8315 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #18 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x will be in 3.8.3 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8315 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10803|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8315 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |iloginok@gmail.com --- Comment #19 from Chris Cormack <chris@bigballofwax.co.nz> --- *** Bug 8625 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org