[Bug 26763] New: Use standard information style for multi-hold message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26763 Bug ID: 26763 Summary: Use standard information style for multi-hold message Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: bibliwho@gmail.com, gmcharlt@gmail.com, jonathan.druart@bugs.koha-community.org, joy@bywatersolutions.com, karen@bywatersolutions.com, katrin.fischer@bsz-bw.de, lisetteslatah@gmail.com, liz@catalyst.net.nz, nick@bywatersolutions.com, testopia@bugs.koha-community.org Depends on: 19718 Bug 19718 introduced a change to the OPAC holds page which shows a message when the patron is placing a hold on a title they already have a hold on. Rather than use an <h3> tag for this message I propose we use <div class="alert alert-info"> Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19718 [Bug 19718] Create message for patrons with multiple holds on the same item -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26763 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26763 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 112095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112095&action=edit Bug 26763: Use standard information style for multi-hold message This patch modifies the markup of the message which is displayed when the patron tries to place a hold on a title they already have a hold on. Now the message is styled consistently with other similar messages. To test, apply the patch and follow the steps used to test Bug 19718: - In Administration -> Circulation and fine rules, set a rule to allow multiple holds on a title. - Log in to the OPAC as a user covered by the above rule and locate a bibliographic record on which multiple holds can be placed. - Place a hold on the record. - Return to the record details for that title and place another hold. - You should see a correctly-styled message about having at least one other hold on the record. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26763 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26763 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson@bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26763 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26763 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112095|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 112452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112452&action=edit Bug 26763: Use standard information style for multi-hold message This patch modifies the markup of the message which is displayed when the patron tries to place a hold on a title they already have a hold on. Now the message is styled consistently with other similar messages. To test, apply the patch and follow the steps used to test Bug 19718: - In Administration -> Circulation and fine rules, set a rule to allow multiple holds on a title. - Log in to the OPAC as a user covered by the above rule and locate a bibliographic record on which multiple holds can be placed. - Place a hold on the record. - Return to the record details for that title and place another hold. - You should see a correctly-styled message about having at least one other hold on the record. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26763 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26763 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26763 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112452|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 112457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112457&action=edit Bug 26763: Use standard information style for multi-hold message This patch modifies the markup of the message which is displayed when the patron tries to place a hold on a title they already have a hold on. Now the message is styled consistently with other similar messages. To test, apply the patch and follow the steps used to test Bug 19718: - In Administration -> Circulation and fine rules, set a rule to allow multiple holds on a title. - Log in to the OPAC as a user covered by the above rule and locate a bibliographic record on which multiple holds can be placed. - Place a hold on the record. - Return to the record details for that title and place another hold. - You should see a correctly-styled message about having at least one other hold on the record. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26763 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112457|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 112458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112458&action=edit Bug 26763: Use standard information style for multi-hold message This patch modifies the markup of the message which is displayed when the patron tries to place a hold on a title they already have a hold on. Now the message is styled consistently with other similar messages. To test, apply the patch and follow the steps used to test Bug 19718: - In Administration -> Circulation and fine rules, set a rule to allow multiple holds on a title. - Log in to the OPAC as a user covered by the above rule and locate a bibliographic record on which multiple holds can be placed. - Place a hold on the record. - Return to the record details for that title and place another hold. - You should see a correctly-styled message about having at least one other hold on the record. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26763 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26763 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26763 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- enhancement will not be backported to 20.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org