[Bug 8586] New: Small bug in die if no mapping in framework for biblioitems.biblioitemnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8586 Priority: P5 - low Change sponsored?: --- Bug ID: 8586 CC: m.de.rooy@rijksmuseum.nl Assignee: gmcharlt@gmail.com Summary: Small bug in die if no mapping in framework for biblioitems.biblioitemnumber Severity: normal Classification: Unclassified OS: All Reporter: fridolyn.somers@biblibre.com Hardware: All Status: NEW Version: master Component: Cataloging Product: Koha If a framework does not have a biblio.biblionumber mapping, cataloguing dies saying : No biblionumber tag for framework "$frameworkcode". It is the same for biblioitems.biblioitemnumber. But the code uses the biblio tag var instead of biblioitem tag. This causes on cataloguing with this framework the message : Software error: Tag "0" is not a valid tag. at /home/koha/src/C4/Biblio.pm line 3138 Very small patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8586 --- Comment #1 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 11414 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11414&action=edit Proposed patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8586 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Test plan : ----------- Create a new framework using default one. Delete subfield definition mapped on biblioitems.biblioitemnumber. Create a new record using this framework. Without patch => software error With patch => error message -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8586 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11414|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 11461 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11461&action=edit Bug 8586: Small bug in die if no mapping in framework for biblioitems.biblioitemnumber Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8586 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8586 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj@kohaaloha.com QA Contact| |mtj@kohaaloha.com --- Comment #4 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #3)
Created attachment 11461 [details] Bug 8586: Small bug in die if no mapping in framework for biblioitems.biblioitemnumber
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
patch looks good, passing QA mason@xen1:~/git/head$ koha-qa.pl * 4481197 Bug 8586: Small bug in die if no mapping in framework for biblioitems.biblioitemnumber C4/Biblio.pm - perlcritic-progressive tests... OK - perl -c syntax tests... OK - xt/tt_valid.t tests... OK - xt/author/valid-template.t tests... OK -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8586 --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.4 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8586 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8003 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8586 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable CC| |paul.poulain@biblibre.com Version|master |rel_3_8 Assignee|gmcharlt@gmail.com |fridolyn.somers@biblibre.co | |m --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to master. Already in stable, setting status accordingly. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org