[Bug 19511] New: local cover images not centered in table on OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19511 Bug ID: 19511 Summary: local cover images not centered in table on OPAC Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: lyle@lyle.work QA Contact: testopia@bugs.koha-community.org Created attachment 68369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68369&action=edit Local thumbnail displayed alongside Amazon thumbnails Local cover images are not displayed centered when compared with cover images loaded from Amazon. On Amazon loaded images the class "thumbnail" is included in the img tag, whereas in local cover images the "thumbnail" class is not present. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19511 --- Comment #1 from Lyle Kozloff <lyle@lyle.work> --- A work around is to add the following to IntranetUserCSS: [id*="local-thumbnail"] img{ display: block; margin: auto; } -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19511 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial Summary|local cover images not |Local cover images not |centered in table on OPAC |centered in table column in | |staff client search results Version|unspecified |master Component|OPAC |Templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19511 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19511 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 77293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77293&action=edit Bug 19511: Local cover images not centered in table column in staff client search results This patch modifies the JavaScript which embeds local cover images in staff client catalog search results. It now adds the "thumbail" class to the image, matching Amazon cover images. To test you should have one or more titles with local cover images attached. Apply the patch and clear your browser cache if necessary. Enable both the AmazonCoverImages and LocalCoverImages system preferences and perform a search which will return titles with local cover images. Confirm that local covers are styled like Amazon covers. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19511 Dilan Johnpullé <dilan@calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19511 Dilan Johnpullé <dilan@calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77293|0 |1 is obsolete| | --- Comment #3 from Dilan Johnpullé <dilan@calyx.net.au> --- Created attachment 77812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77812&action=edit Bug 19511: Local cover images not centered in table column in staff client search results This patch modifies the JavaScript which embeds local cover images in staff client catalog search results. It now adds the "thumbail" class to the image, matching Amazon cover images. To test you should have one or more titles with local cover images attached. Apply the patch and clear your browser cache if necessary. Enable both the AmazonCoverImages and LocalCoverImages system preferences and perform a search which will return titles with local cover images. Confirm that local covers are styled like Amazon covers. Tested and confirmed local cover images are appearing quite nicely now. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19511 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19511 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77812|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77840&action=edit Bug 19511: Local cover images not centered in table column in staff client search results This patch modifies the JavaScript which embeds local cover images in staff client catalog search results. It now adds the "thumbail" class to the image, matching Amazon cover images. To test you should have one or more titles with local cover images attached. Apply the patch and clear your browser cache if necessary. Enable both the AmazonCoverImages and LocalCoverImages system preferences and perform a search which will return titles with local cover images. Confirm that local covers are styled like Amazon covers. Tested and confirmed local cover images are appearing quite nicely now. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19511 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19511 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19511 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Stable |RESOLVED --- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.11.x for 17.11.10 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org