http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9587 --- Comment #1 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 15226 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15226&action=edit Bug 9587 : Mozilla Persona login Working on Mozilla Persona support (browser id) This will let a user log into Koha using browser id, if their email address used matches the email address inside Koha. Once an assertion is received, we simply need to find the user that matches that email address, and create a session for them. opac/svc/login handles this part. The nice thing about it is, the user doesn't have to do anything, like linking their account. As long as the email address they are using to identify themselves in browserid is the same as the one in Koha it will just work. This is covered by a systempreference, to allow people to do it, and is of course totally opt in, it works alongside normal Koha (or any other method) of login. So only those choosing to use it, need use it Test Plan 1/ Make sure OPACBaseURL is set correctly 2/ Switch on the Persona syspref 3/ Make a borrower (or edit one) to have the email you plan to use as the primary email 4/ Click sign in with email, make or use a persona account 5/ Logout 6/ Check you can still login and logout the normal way -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9587 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- 1) Test a) Applied patch, updatedatabase, set preferences b) Create patron with Persona account c) Tried to login... enter a endless loop of login page reloads every 3 secs Is anything more to do/enable? 2) Errors koha-qa gives * C4/Auth.pm FAIL * koha-tmpl/opac-tmpl/prog/en/includes/masthead.inc FAIL -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9587 --- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Hi Chris, yes, I set opacbaseurl, and have same behavior using chrome, safari, etc. koha-qa -c 1 -v 2 * C4/Auth.pm FAIL pod OK forbidden patterns FAIL The patch introduces a forbidden pattern: tabulation character (746) The patch introduces a forbidden pattern: tabulation character (821) The patch introduces a forbidden pattern: tabulation character (816) * koha-tmpl/opac-tmpl/prog/en/includes/masthead.inc FAIL forbidden patterns OK tt_valid FAIL lines 13 valid_template OK I'll try on a clean master. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9587 --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Is the OpacBaseURL exactly the same as the url you are hitting the site on? I am not getting the redirect, but if i change it to not match the site i am hitting i get that redirect. Perhaps it was wrong before and you fixed it? The assertion from Persona will be wrong then and it will continue to keep looping. To break the loop go to login.persona.org and log out. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9587 --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 15254 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15254&action=edit Bug 9587 : Follow up, fixing tabs in C4/Auth.pm And translation problem in masthead.inc -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9587 --- Comment #9 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Well, now (pre and post followup) works :) Clean master, cleaned cookies, etc. from browser. Tested with chrome, firefox, safari, opera. New and old autentication works. Old errors gone. New error from koha-qa :( * C4/Auth.pm FAIL pod OK forbidden patterns FAIL The patch introduces a forbidden pattern: Data::Dumper::Dumper (1031) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9587 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15226|0 |1 is obsolete| | --- Comment #11 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 15257 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15257&action=edit Bug 9587 : Mozilla Persona login Working on Mozilla Persona support (browser id) This will let a user log into Koha using browser id, if their email address used matches the email address inside Koha. Once an assertion is received, we simply need to find the user that matches that email address, and create a session for them. opac/svc/login handles this part. The nice thing about it is, the user doesn't have to do anything, like linking their account. As long as the email address they are using to identify themselves in browserid is the same as the one in Koha it will just work. This is covered by a systempreference, to allow people to do it, and is of course totally opt in, it works alongside normal Koha (or any other method) of login. So only those choosing to use it, need use it Test Plan 1/ Make sure OPACBaseURL is set correctly 2/ Switch on the Persona syspref 3/ Make a borrower (or edit one) to have the email you plan to use as the primary email 4/ Click sign in with email, make or use a persona account 5/ Logout 6/ Check you can still login and logout the normal way Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Works great. It's not browser dependent, but tested with chrome, firefox, opera and safari. Old an new login system works. Minor errors, addresed in follow-up. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9587 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9587 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15258|Bug 9587 : Follow up, |[SIGNED-OFF] Bug 9587 : description|fixing tabs in C4/Auth.pm |Follow up, fixing tabs in | |C4/Auth.pm -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9587 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15265|0 |1 is obsolete| | --- Comment #14 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 15266 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15266&action=edit [SIGNED-OFF] Bug 9587 : Followup removing a commented out warn that was annoying the qa tools Not introduced by this work but no reason not to clean it Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: no more complains from koha-qa -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9587 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #16 from Chris Cormack <chris@bigballofwax.co.nz> --- It is because I have it set to automatically log you in if it spots you logged into persona. Conversely if you are logged into Koha but not persona it is trying to log you, fixing this now. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9587 --- Comment #17 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 15449 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15449&action=edit Bug 9587 Follow up to fix the problem Katrin identified -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9587 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9587 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15257|0 |1 is obsolete| | Attachment #15258|0 |1 is obsolete| | Attachment #15266|0 |1 is obsolete| | Attachment #15459|0 |1 is obsolete| | --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 15474 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15474&action=edit [PASSED-QA] Bug 9587 : Mozilla Persona login Working on Mozilla Persona support (browser id) This will let a user log into Koha using browser id, if their email address used matches the email address inside Koha. Once an assertion is received, we simply need to find the user that matches that email address, and create a session for them. opac/svc/login handles this part. The nice thing about it is, the user doesn't have to do anything, like linking their account. As long as the email address they are using to identify themselves in browserid is the same as the one in Koha it will just work. This is covered by a systempreference, to allow people to do it, and is of course totally opt in, it works alongside normal Koha (or any other method) of login. So only those choosing to use it, need use it Test Plan 1/ Make sure OPACBaseURL is set correctly 2/ Switch on the Persona syspref 3/ Make a borrower (or edit one) to have the email you plan to use as the primary email 4/ Click sign in with email, make or use a persona account 5/ Logout 6/ Check you can still login and logout the normal way Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Works great. It's not browser dependent, but tested with chrome, firefox, opera and safari. Old an new login system works. Minor errors, addresed in follow-up. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9587 --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 15476 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15476&action=edit [PASSED-QA] Bug 9587 : Followup removing a commented out warn that was annoying the qa tools Not introduced by this work but no reason not to clean it Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: no more complains from koha-qa Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9587 --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 15478 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15478&action=edit Bug 9587 : QA follow up - fix one tabulation character Makes QA script happy. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9587 --- Comment #25 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- I am having problems getting this to work. I enabled Persona, and Koha seems to be recognizing me correctly, but I'm not logged in at the end. I get this in my logs (with $ENV{'DEBUG'} set): Initiating an anonymous session... at /home/jcamins/kohaclone/C4/Auth.pm line 952. Use of uninitialized value in concatenation (.) or string at /home/jcamins/kohaclone/C4/Auth.pm line 394. Checking Auth at /home/jcamins/kohaclone/C4/Auth.pm line 618. kohaversion : 3.1100018 Use of uninitialized value $cardnumber in concatenation (.) or string at /home/jcamins/kohaclone/C4/Auth.pm line 864. Use of uninitialized value $userflags in concatenation (.) or string at /home/jcamins/kohaclone/C4/Auth.pm line 864. AUTH_3 results: ,60,nicelynicely.johnson,Nicely Nicely,Johnson,,CPL,jcamins@gmail.com Use of uninitialized value in printf at /home/jcamins/kohaclone/C4/Auth.pm line 912. AUTH_4: () Nicely Nicely Johnson - CPL Any idea what could be going on? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9587 --- Comment #27 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- (In reply to comment #26)

The email you authenticated to persona is the primary email for your borrower in Koha right?

Yup. And the system recognized the patron, it just didn't log me in. Do I need to have a password set for the user? It strikes me that I do not. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9587 --- Comment #28 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 15578 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15578&action=edit Bug 9587 : Handling mismatched emails better To test: Sign in to Koha via persona using an email that doesn't exist in Koha Before the patch you will get into an infinite redirect loop After the patch it will give you an error message -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9587 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15580|0 |1 is obsolete| | --- Comment #30 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 15585 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15585&action=edit [SIGNED-OFF] Bug 9587 : Handling mismatched emails better To test: Sign in to Koha via persona using an email that doesn't exist in Koha Before the patch you will get into an infinite redirect loop After the patch it will give you an error message Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described. No errors. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9587 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #32 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.