[Bug 11457] New: t/db_dependent/Bookseller.t can fail when subscription table is not empty
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11457 Bug ID: 11457 Summary: t/db_dependent/Bookseller.t can fail when subscription table is not empty Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: katrin.fischer@bsz-bw.de QA Contact: gmcharlt@gmail.com Tests 22 and 23 failed on my database because I had a few subscriptions in my database. After setting the subscription.enddate far into the future the tests passed again. ok 22 - search for subscriptions by expiration date ok 23 - search for subscriptions by expiration date Maybe cleaning the subscription table within the transaction before running the test would fix this. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11457 --- Comment #1 from Chris Cormack <chris@bigballofwax.co.nz> --- Yep, if you have an old subscription that ended before 2013-12-31 test 22 will fail. If one is older than 2013-08-15 23 will also fail. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11457 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11457 --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 23886 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23886&action=edit Bug 11457 : Clearing subscription table so tests pass correctly To test 1/ Add a subscription in the serials module, with an end date before 2013-08-01 2/ run prove -v t/db_dependent/Bookseller.t Notice tests 22 and 23 fail 3/ Apply patch 4/ run test again 5/ Notice tests succeed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11457 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11457 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23886|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 23890 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23890&action=edit [SIGNED OFF] Bug 11457 : Clearing subscription table so tests pass correctly To test 1/ Add a subscription in the serials module, with an end date before 2013-08-01 2/ run prove -v t/db_dependent/Bookseller.t Notice tests 22 and 23 fail 3/ Apply patch 4/ run test again 5/ Notice tests succeed Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tests now clean the subscription table before running the tests, so that the will always pass. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11457 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11457 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23890|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 24100 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24100&action=edit Bug 11457 : Clearing subscription table so tests pass correctly To test 1/ Add a subscription in the serials module, with an end date before 2013-08-01 2/ run prove -v t/db_dependent/Bookseller.t Notice tests 22 and 23 fail 3/ Apply patch 4/ run test again 5/ Notice tests succeed Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tests now clean the subscription table before running the tests, so that the will always pass. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11457 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Chris! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11457 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #6 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Patch pushed to 3.14.x, will be in 3.14.4. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org