[Bug 7266] New: overdue.pl : filter on flags "debarred" "suspended" and "gonenoaddress" not working
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7266 Bug #: 7266 Summary: overdue.pl : filter on flags "debarred" "suspended" and "gonenoaddress" not working Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_6 Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation AssignedTo: adrien.saurat@biblibre.com ReportedBy: adrien.saurat@biblibre.com QAContact: ian.walls@bywatersolutions.com CC: gmcharlt@gmail.com When looking for overdues, the combobox "Patron flags" has no effect. Three values are available in the list: Address in question Restricted Lost card None of this works (empty result) as the code currently assumes that these filters work with the "flags" field in the database. Actually, the form value should be compared instead with the contents of the gonenoaddress, debarred and lost fields. "Address in question" should filter by: gonenoaddress TRUE "Restricted" should filter by: debarred date >= current date "Lost card" should filter by: lost TRUE -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7266 --- Comment #1 from Adrien SAURAT <adrien.saurat@biblibre.com> 2011-11-25 10:53:26 UTC --- Created attachment 6407 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6407 patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7266 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |PATCH-Sent Status|NEW |ASSIGNED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7266 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7266 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Needs Signoff |Failed QA --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> 2011-12-01 19:16:31 UTC --- Adrian + elsif ( $borflagsfilter eq 'lost') { + $strsth .= " AND borrowers.debarred <> 0"; + } Shouldn't that be checking lost not debarred? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7266 --- Comment #3 from Adrien SAURAT <adrien.saurat@biblibre.com> 2011-12-02 09:23:27 UTC --- Created attachment 6519 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6519 patch #2 Corrected the "lost" case which was checking the "debarred" field. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7266 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7266 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Does not apply --- Comment #4 from Owen Leonard <oleonard@myacpl.org> 2011-12-02 16:11:31 UTC --- The first patch does not apply for me. Tried with git bz apply and git am -i3u. Applying: Bug 7266: filter on "Patron flags" in overdue.pl error: patch failed: circ/overdue.pl:266 error: circ/overdue.pl: patch does not apply Patch failed at 0001 Bug 7266: filter on "Patron flags" in overdue.pl If you can rebase this against current master, can you please also squash the two patches together? Thanks. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7266 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6407|0 |1 is obsolete| | Attachment #6519|0 |1 is obsolete| | --- Comment #5 from Adrien SAURAT <adrien.saurat@biblibre.com> 2011-12-20 08:36:45 UTC --- Created attachment 6884 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6884 proposed patch New patch ready. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7266 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Does not apply |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7266 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6884|0 |1 is obsolete| | --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> 2011-12-20 08:54:05 UTC --- Created attachment 6886 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6886 Bug 7266: flags debarred, suspended, gonenoaddress in overdue This patch makes these flags functionnal. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7266 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7266 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Version|rel_3_6 |master -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7266 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com Version|master |rel_3_8 --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> 2012-01-17 17:04:43 UTC --- QA comment: small patch, perlcritic compliant, passed QA. Won't work for 3.6, as it relies on fine in days -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7266 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org