http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8425 --- Comment #2 from David Cook <dcook@prosentient.com.au> --- (In reply to comment #1)

Hm, this should not happen, but maybe it will help to set the UniqueItemFields to barcode? In my tests it worked really nicely, but perhaps something changed.

No luck. Setting "barcode" in UniqueItemFields makes no change. When did you test it? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8425 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- (In reply to comment #3)

Hm, I think I signed off on the patch introducing it, so the bug history should tell.

Which patch is that, Katrin? --- Also, when I look at my standard install 3.8.0 or my dev install 3.8.0 branch, the clear button works in the item block. However, it doesn't work in 3.8.2 (maybe 3.8.1) or higher... Also, in my standard 3.8.0 install, duplicate barcodes creates this error: DBD::mysql::st execute failed: Duplicate entry '201180550469528' for key 'itembarcodeidx' at .../lib/C4/Items.pm line 2127. While in my dev install 3.8.0 branch, a nice JS window pops up to say: "Duplicate values detected. Please correct the errors and resubmit." As mentioned before, in 3.8.2+, no error message is generated and only the first item is created. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8425 --- Comment #6 from David Cook <dcook@prosentient.com.au> --- Still not sure why this one is happening... The relevant code in neworderempty.tt looks identical. neworderempty.pl looks like it should be passing everything correctly to the template too. additems.js seems close enough, although check_uniqueness.pl is very different...but a quick test didn't show a difference. Even when I replace all these files with files from a version where the dupe check works, the JS still fails to pick up the duplication of the barcodes. I'll have to try git bisect again, but anyone have any ideas on this one? I figure the problem must be with additems.js and check_uniqueness.pl... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8425 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Duplicate barcodes |Autobarcode generates |generated when placing an |duplicate barcodes with |Order in Acquisitions when |AcqCreateItems = on order |AcqCreateItem = "placing an | |order" and Autobarcode is | |turned on | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I can replicate the problem: When using Autobarcode items created on order will all get the same(!) barcode. Additionally the check on saving the order fails, so you get no notice and only one item is created. I think this is because Autobarcode checks for the next barcode in the database. We are creating more than one item at once, so there is a problem. I am not sure if that part of the problem can be solved easily, but the form should warn on saving when duplicate barcodes are detected. Settings: UniqueItemFields: barcode AcqCreateItem: placing an order Autobarcode: 1, 2, 3... Turning off Autobarcode (do not generate) didn't solve the problem. There is a javascript error that you can see when saving the order in Firebug. Filing another bug for the broken duplicate check. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8425 Liz Rea (CatalystIT) <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #9 from Liz Rea (CatalystIT) <liz@catalyst.net.nz> --- oops sorry - wrong bug! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8425 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com --- Comment #10 from Galen Charlton <gmcharlt@gmail.com> --- I'm not able to reproduce the problem -- I suspect it was fixed by the patch for bug 8495. David: could you check to see if you're still seeing this? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8425 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|ASSIGNED |NEW --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The problem is that the items are not inserted in the DB when you click on the "Add item" button. So the item form generated just after does not know an item is on the road. Hopefully, there is now a check when you submit the complete order "Duplicate values detected. Please correct the errors and resubmit." The form is not submitted, there are identical barcodes. It seems quite tricky to fix this one. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.