[Bug 13370] New: Inputs overflow in filters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13370 Bug ID: 13370 Summary: Inputs overflow in filters Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: jonathan.druart@biblibre.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13370 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|oleonard@myacpl.org |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13370 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12376 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13370 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13370 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34056 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34056&action=edit Bug 13370: Inputs overflow in filter Bug 12376 adds some padding to inputs. This cause an overflow on the record detail page. Test plan: 1/ Go on a record detail page with items 2/ Enable filters Without the patch, the inputs overflow, with the patch it should be corrected (as before bug 12376). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13370 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13370 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13371 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13370 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- This doesn't apply, but I'm not sure why. The patch refers to this supposedly existing line: span.filter_column > input.date_range_filter { ..which in master is span.filter_column > input.text_filter { I can't tell if this is intended to be dependent on another patch or if the difference is unintentional. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13370 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Looks good here... Bug 13370 - Inputs overflow in filters 34056 - Bug 13370: Inputs overflow in filter Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 13370: Inputs overflow in filter Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/css/datatables.css Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/css/datatables.css -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13370 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34056|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34067 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34067&action=edit Bug 13370: Inputs overflow in filter Bug 12376 adds some padding to inputs. This cause an overflow on the record detail page. Test plan: 1/ Go on a record detail page with items 2/ Enable filters Without the patch, the inputs overflow, with the patch it should be corrected (as before bug 12376). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13370 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Ok, should be better now. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13370 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13370 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34067|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 34068 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34068&action=edit [SIGNED-OFF] Bug 13370: Inputs overflow in filter Bug 12376 adds some padding to inputs. This cause an overflow on the record detail page. Test plan: 1/ Go on a record detail page with items 2/ Enable filters Without the patch, the inputs overflow, with the patch it should be corrected (as before bug 12376). Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13370 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13370 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34068|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34145 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34145&action=edit [PASSED QA] Bug 13370: Inputs overflow in filter Bug 12376 adds some padding to inputs. This cause an overflow on the record detail page. Test plan: 1/ Go on a record detail page with items 2/ Enable filters Without the patch, the inputs overflow, with the patch it should be corrected (as before bug 12376). Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13370 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13370 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org