[Bug 16585] New: Update Italian installer sample files for 16.05
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16585 Bug ID: 16585 Summary: Update Italian installer sample files for 16.05 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: z.tajoli@cineca.it QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr Update and translate sample SQL file of the Italinan installer. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16585 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Patch complexity|--- |Trivial patch Assignee|koha-bugs@lists.koha-commun |z.tajoli@cineca.it |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16585 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |With this patch all release notes| |sample/defintions .sql | |files are translated into | |Italina (if you select | |italian during web | |installation). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16585 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16382 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16585 --- Comment #1 from Zeno Tajoli <z.tajoli@cineca.it> --- To test: - Start with an empty database - Install it-IT - Run the web installer in it-IT/Italian - Verify all files, especially sample notices, sample_frequencies, sample_numberpatterns load without any problems. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16585 --- Comment #2 from Zeno Tajoli <z.tajoli@cineca.it> --- Created attachment 51836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51836&action=edit Update Italian installer sample files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16585 --- Comment #3 from Zeno Tajoli <z.tajoli@cineca.it> --- Created attachment 51837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51837&action=edit Followup of the patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16585 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16585 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|With this patch all |With this patch all release notes|sample/defintions .sql |sample/defintions .sql |files are translated into |files are translated into |Italina (if you select |Italian (if you select |italian during web |italian during web |installation). |installation). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16585 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16585 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51836|0 |1 is obsolete| | Attachment #51837|0 |1 is obsolete| | --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 53725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53725&action=edit Bug 16585: Update Italian installer sample files for 16.05 With this patch all sample/defintions .sql files are updated and translated into Italian (if you select italian during web installation). NOTE: Squashed both patches. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16585 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor CC| |mtompset@hotmail.com --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- This is not an enhancement. This is a bug fix, as many of the strings in the Italian SQL files were English to start with. Marking it as such. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16585 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Comment on attachment 53725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53725 Bug 16585: Update Italian installer sample files for 16.05 Review of attachment 53725: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=16585&attachment=53725) ----------------------------------------------------------------- ::: installer/data/mysql/it-IT/necessari/notices.sql @@ +7,5 @@
('circulation','DUEDGST','Avviso restituzione (digest)','Avviso restituzione (digest)','Hai <<count>> prestiti da retituire', 'email'), ('circulation','PREDUE','Preavviso scadenza prestito','Preavviso scadenza prestito','Salve <<borrowers.firstname>> <<borrowers.surname>>,\r\n\r\nQuesti prestiti stanno per scadere:\r\n\r\n<<biblio.title>>, <<biblio.author>> (<<items.barcode>>)', 'email'), +('circulation','PREDUEDGST','Preavviso scadenza prestiti (digest)','Avviso copie in scadenza','Gentile <<borrowers.firstname>> <<borrowers.surname>>, +Il prestito dei seguenti volumi sta per scadere: +
You should use \r\n to line breaks. ::: installer/data/mysql/it-IT/necessari/sample_frequencies.sql @@ +1,2 @@
INSERT INTO subscription_frequencies + (id, description, displayorder, unit, unitsperissue, issuesperunit)
Why do you force the id? ::: installer/data/mysql/it-IT/necessari/sample_numberpatterns.sql @@ +1,2 @@
INSERT INTO subscription_numberpatterns + (id, label, displayorder, description, numberingmethod,
Same here. ::: installer/data/mysql/it-IT/necessari/system_preferences.sql @@ +20,4 @@
UPDATE systempreferences SET value = '1' WHERE variable = 'AllowRenewalLimitOverride'; UPDATE systempreferences SET value = 'annual' WHERE variable = 'autoBarcode'; UPDATE systempreferences SET value = 'email' WHERE variable = 'AutoEmailPrimaryAddress'; +UPDATE systempreferences SET value = '1' WHERE variable = 'BiblioAddsAuthorities';
The changes in this file seems very specific but nobody complain until now, so that should be ok. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16585 --- Comment #7 from Zeno Tajoli <z.tajoli@cineca.it> --- Hi, I answer the request of Jonathan (#6):
You should use \r\n to line breaks. I insert "\r\n\r\n" because in Italy we want a empty line in the template. It is a cosmetic request. I used "\r\n\r\n" in older version of notices.sql
Why do you force the id? [in sample_frequencies.sql and in sample_numberpatterns.sql] In fact I insert ids only because I create file directly wirh mysql tools. I think we can not insert them.
The changes in this file [system_preferences.sql] seems very specific but nobody complain until now, so that should be ok. I try to guess the best default for italian users.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16585 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16585 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53725|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 53882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53882&action=edit Bug 16585: Update Italian installer sample files for 16.05 With this patch all sample/defintions .sql files are updated and translated into Italian (if you select italian during web installation). Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16585 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Zeno Tajoli from comment #7)
Hi, I answer the request of Jonathan (#6):
You should use \r\n to line breaks. I insert "\r\n\r\n" because in Italy we want a empty line in the template. It is a cosmetic request. I used "\r\n\r\n" in older version of notices.sql
No, look at: +Il prestito dei seguenti volumi sta per scadere: + +<<items.content>> + +<<branches.branchname>>', 'email'), You did not use \r\n or whatever. Anyway, it's fine by me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16585 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #10 from Brendan Gallagher <brendan@bywatersolutions.com> --- pushed to master - Should be in the November 2016 - Thanks! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org