[Bug 29478] New: flatpickr misses quick shortcut to "Today" date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 Bug ID: 29478 Summary: flatpickr misses quick shortcut to "Today" date Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: nugged@gmail.com QA Contact: testopia@bugs.koha-community.org CC: jonathan.druart+koha@gmail.com In the previous datepicker there was the "Today" button which was useful for our Koha operators to return back to the current moment after some dates jumping. There is a request to return a somewhat "shortcut button" or similar feature to quickly jump to the current moment. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29239 Severity|enhancement |normal Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29239 [Bug 29239] [OMNIBUS] Replace jQueryUI's timepicker with flatpickr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- It's not implemented, looks like we need to use a plugin for that https://github.com/flatpickr/flatpickr/issues/576 https://github.com/jcsmorais/shortcut-buttons-flatpickr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 127626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127626&action=edit Bug 29478: Flatpickr - Restore 'Today' button It's not implemented, looks like we need to use a plugin for that https://github.com/flatpickr/flatpickr/issues/576 https://github.com/jcsmorais/shortcut-buttons-flatpickr Test plan: Confirm that flatpickr instances now have a yesterday, today and tomorrow buttons. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127626|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 127676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127676&action=edit Bug 29478: Flatpickr - Restore 'Today' button It's not implemented, looks like we need to use a plugin for that https://github.com/flatpickr/flatpickr/issues/576 https://github.com/jcsmorais/shortcut-buttons-flatpickr Test plan: Confirm that flatpickr instances now have a yesterday, today and tomorrow buttons. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This adds shortcuts to release notes| |yesterday, today and | |tomorrow for the flatpickr | |date selector. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 127694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127694&action=edit Bug 29478: (follow-up) Provide default style for shortcut buttons This patch adds some CSS to _flatpickr.scss in order to give a deafult style to the "yesterday," "today," and "tomorrow" controls added by the shortcut plugin. A missed translatable string is now wrapped in the __() function: __("or"). The patch also updates the date calculation for those shortcuts to use Flatpickr's date calculation shorthand. This isn't strictly necessary but I think it makes the code more readable. To test, apply the patch and build the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). In the staff client, view some pages with date-picker widgets. A calendar widget time selection: - Circulation -> Check out -> Checkout settings -> Select date: - The calendar widget should have "yesterday," "today," and "tomorrow" controls styled like links appearing after the time selector. The controls should be centered, with the "or" label on the same line. A calendar widget without time selection: - Tools -> Log viewer -> Display from. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #2)
Confirm that flatpickr instances now have a yesterday, today and tomorrow buttons.
I thought of an issue when testing my follow-up: Should the shortcut controls reflect the date limitations of the flatpickr instance? For instance, if selection is limited to a date before today, should the "today" and "tomorrow" controls be disabled? Currently clicking a shortcut for a date which is disallowed will empty the date field. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Owen Leonard from comment #5)
(In reply to Jonathan Druart from comment #2)
Confirm that flatpickr instances now have a yesterday, today and tomorrow buttons.
I thought of an issue when testing my follow-up: Should the shortcut controls reflect the date limitations of the flatpickr instance? For instance, if selection is limited to a date before today, should the "today" and "tomorrow" controls be disabled? Currently clicking a shortcut for a date which is disallowed will empty the date field.
Good point! Yes definitely, if not too hard to implement. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- There is a problem for futuredate, see bug 29241 comment 12. ie. you can click yesterday, the input is prefilled with yesterday's date when we should not accept dates in the past. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29500 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29500 [Bug 29500] Flatpickr accepting original date in the past for futuredate but also other dates in the past -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127676|0 |1 is obsolete| | Attachment #127694|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 127721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127721&action=edit Bug 29478: Flatpickr - Restore 'Today' button It's not implemented, looks like we need to use a plugin for that https://github.com/flatpickr/flatpickr/issues/576 https://github.com/jcsmorais/shortcut-buttons-flatpickr Test plan: Confirm that flatpickr instances now have a yesterday, today and tomorrow buttons. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 127722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127722&action=edit Bug 29478: (follow-up) Provide default style for shortcut buttons This patch adds some CSS to _flatpickr.scss in order to give a deafult style to the "yesterday," "today," and "tomorrow" controls added by the shortcut plugin. A missed translatable string is now wrapped in the __() function: __("or"). The patch also updates the date calculation for those shortcuts to use Flatpickr's date calculation shorthand. This isn't strictly necessary but I think it makes the code more readable. To test, apply the patch and build the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). In the staff client, view some pages with date-picker widgets. A calendar widget time selection: - Circulation -> Check out -> Checkout settings -> Select date: - The calendar widget should have "yesterday," "today," and "tomorrow" controls styled like links appearing after the time selector. The controls should be centered, with the "or" label on the same line. A calendar widget without time selection: - Tools -> Log viewer -> Display from. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 127730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127730&action=edit Bug 29478: Today should select now for pastinclusive If Today is clicked when we only allow dates in the past and today/now, we should select the current date/time We need to update the maxDate to make it up-to-date, or the maxDate may be set to the minute before and clicking Today will blank the input. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 --- Comment #11 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Last patch fixes a bug, however it does not restore the 23:59 time part when another date is selected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127730|0 |1 is obsolete| | --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 127804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127804&action=edit Bug 29478: Today should select now for pastinclusive If Today is clicked when we only allow dates in the past and today/now, we should select the current date/time We need to update the maxDate to make it up-to-date, or the maxDate may be set to the minute before and clicking Today will blank the input. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- The patch in Comment 9 still needs a signoff. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 --- Comment #14 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 127850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127850&action=edit Bug 29478: (follow-up) Today should select now for pastinclusive This is getting ugly. We need to add 1 minute for the minDate or the 'Today' link may not work. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 --- Comment #15 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Owen Leonard from comment #13)
The patch in Comment 9 still needs a signoff.
Looks good to me, but I prefer to see someone else testing this. Especially because I found (and fix) yet another problem... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127721|0 |1 is obsolete| | --- Comment #16 from David Nind <david@davidnind.com> --- Created attachment 127890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127890&action=edit Bug 29478: Flatpickr - Restore 'Today' button It's not implemented, looks like we need to use a plugin for that https://github.com/flatpickr/flatpickr/issues/576 https://github.com/jcsmorais/shortcut-buttons-flatpickr Test plan: Confirm that flatpickr instances now have a yesterday, today and tomorrow buttons. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127722|0 |1 is obsolete| | --- Comment #17 from David Nind <david@davidnind.com> --- Created attachment 127891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127891&action=edit Bug 29478: (follow-up) Provide default style for shortcut buttons This patch adds some CSS to _flatpickr.scss in order to give a deafult style to the "yesterday," "today," and "tomorrow" controls added by the shortcut plugin. A missed translatable string is now wrapped in the __() function: __("or"). The patch also updates the date calculation for those shortcuts to use Flatpickr's date calculation shorthand. This isn't strictly necessary but I think it makes the code more readable. To test, apply the patch and build the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). In the staff client, view some pages with date-picker widgets. A calendar widget time selection: - Circulation -> Check out -> Checkout settings -> Select date: - The calendar widget should have "yesterday," "today," and "tomorrow" controls styled like links appearing after the time selector. The controls should be centered, with the "or" label on the same line. A calendar widget without time selection: - Tools -> Log viewer -> Display from. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127804|0 |1 is obsolete| | --- Comment #18 from David Nind <david@davidnind.com> --- Created attachment 127892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127892&action=edit Bug 29478: Today should select now for pastinclusive If Today is clicked when we only allow dates in the past and today/now, we should select the current date/time We need to update the maxDate to make it up-to-date, or the maxDate may be set to the minute before and clicking Today will blank the input. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127850|0 |1 is obsolete| | --- Comment #19 from David Nind <david@davidnind.com> --- Created attachment 127893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127893&action=edit Bug 29478: (follow-up) Today should select now for pastinclusive This is getting ugly. We need to add 1 minute for the minDate or the 'Today' link may not work. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 --- Comment #20 from David Nind <david@davidnind.com> --- I'm not sure the "or" is necessary, but that is pretty minor. Things seem to work as per the test plan, and I didn't come across anything that didn't work... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127890|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127920&action=edit Bug 29478: Flatpickr - Restore 'Today' button It's not implemented, looks like we need to use a plugin for that https://github.com/flatpickr/flatpickr/issues/576 https://github.com/jcsmorais/shortcut-buttons-flatpickr Test plan: Confirm that flatpickr instances now have a yesterday, today and tomorrow buttons. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127891|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127921&action=edit Bug 29478: (follow-up) Provide default style for shortcut buttons This patch adds some CSS to _flatpickr.scss in order to give a deafult style to the "yesterday," "today," and "tomorrow" controls added by the shortcut plugin. A missed translatable string is now wrapped in the __() function: __("or"). The patch also updates the date calculation for those shortcuts to use Flatpickr's date calculation shorthand. This isn't strictly necessary but I think it makes the code more readable. To test, apply the patch and build the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). In the staff client, view some pages with date-picker widgets. A calendar widget time selection: - Circulation -> Check out -> Checkout settings -> Select date: - The calendar widget should have "yesterday," "today," and "tomorrow" controls styled like links appearing after the time selector. The controls should be centered, with the "or" label on the same line. A calendar widget without time selection: - Tools -> Log viewer -> Display from. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127892|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127922&action=edit Bug 29478: Today should select now for pastinclusive If Today is clicked when we only allow dates in the past and today/now, we should select the current date/time We need to update the maxDate to make it up-to-date, or the maxDate may be set to the minute before and clicking Today will blank the input. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127893|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127923&action=edit Bug 29478: (follow-up) Today should select now for pastinclusive This is getting ugly. We need to add 1 minute for the minDate or the 'Today' link may not work. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This all works.. yes the last patch is a bit weird, but I understand the reasoning behind it. I can PQA on the functionality.. though Owens comment regarding disabling the invalid options isn't yet implemented.. I'd love to see that happen, but given the late stag of the cycle I think that can be handled as an early follow-up bug for next cycle. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29552 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 [Bug 29552] flatpickr misses quick shortcut to "Today" date -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 --- Comment #26 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 --- Comment #27 from Mason James <mtj@kohaaloha.com> --- Created attachment 127968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127968&action=edit to test... - run prove t/00-load.t, see error - apply patch 00:07:08.189 koha_1 | # Failed test 'use C4::SIP::Sip::Configuration;' 00:07:08.189 koha_1 | # at t/00-load.t line 46. 00:07:08.189 koha_1 | # Tried to use 'C4::SIP::Sip::Configuration'. 00:07:08.189 koha_1 | # Error: "uniq" is not exported by the List::Util module - run prove t/00-load.t, see tests pass :0) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #28 from Mason James <mtj@kohaaloha.com> --- oops, patch attached to wrong BZ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127968|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29588 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29588 [Bug 29588] Yesterday and tomorrow in datepicker don't translate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #29 from Fridolin Somers <fridolin.somers@biblibre.com> --- Isn't this 'Blocks' 29239 instead if 'Depends on' ? Since it is the Omnibus. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 --- Comment #30 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Fridolin Somers from comment #29)
Isn't this 'Blocks' 29239 instead if 'Depends on' ? Since it is the Omnibus.
It showed that it was a Flatpickr bug. You can revert it you wish. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 Bug 29478 depends on bug 29239, which changed state. Bug 29239 Summary: [OMNIBUS] Replace jQueryUI's timepicker with flatpickr https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29239 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 Bug 29478 depends on bug 29239, which changed state. Bug 29239 Summary: [OMNIBUS] Replace jQueryUI's timepicker with flatpickr https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29239 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29239 Depends on|29239 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29239 [Bug 29239] [OMNIBUS] Replace jQueryUI's timepicker with flatpickr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30726 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30726 [Bug 30726] Flatpickr's "yesterday" shortcut doesn't work if entry is limited to past dates -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org