[Bug 24395] New: Floats in cash registers have 6 decimals
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24395 Bug ID: 24395 Summary: Floats in cash registers have 6 decimals Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com When going to Administration > Cash registers, the floats are displayed with 6 decimals. I think it would be better if it was limited to 2 or however many your active currency uses. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24395 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24395 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Probably should be using the TT Price template? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24395 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24395 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 97422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97422&action=edit Bug 24395: Show initial float using the Price TT plugin on summary page For displaying monetary amounts, we should be using the Price TT plugin everywhere. This adds it to the cash register summary page. To test: - Create a cash register - Check the cash register table for "Initial float" - Verify the amount shows with more than 2 decimals - Edit cash register - verify the same display there - Apply patch - Check again - it should display now with only 2 decimals Note: This doesn't fix -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24395 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24395 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97422|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 97423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97423&action=edit Bug 24395: Show initial float using the Price TT plugin on summary page For displaying monetary amounts, we should be using the Price TT plugin everywhere. This adds it to the cash register summary page. To test: - Create a cash register - Check the cash register table for "Initial float" - Verify the amount shows with more than 2 decimals - Edit cash register - verify the same display there - Apply patch - Check again - it should display now with only 2 decimals -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24395 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24395 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97423|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 97432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97432&action=edit Bug 24395: Show initial float using the Price TT plugin on summary page For displaying monetary amounts, we should be using the Price TT plugin everywhere. This adds it to the cash register summary page. To test: - Enable the cash register feature (set UseCashRegisters to 'Use') - Go to More > Administration > Accounting > Cash registers - Create a cash register - Check the cash register table for "Initial float" - Verify the amount shows with more than 2 decimals - Edit cash register - verify the same display there - Apply patch - Check again - it should display now with only 2 decimals Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24395 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97432|0 |1 is obsolete| | --- Comment #5 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 97473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97473&action=edit Bug 24395: Show initial float using the Price TT plugin on summary page For displaying monetary amounts, we should be using the Price TT plugin everywhere. This adds it to the cash register summary page. To test: - Create a cash register - Check the cash register table for "Initial float" - Verify the amount shows with more than 2 decimals - Edit cash register - verify the same display there - Apply patch - Check again - it should display now with only 2 decimals Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24395 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx Caroline and David! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24395 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24395 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97473|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 97474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97474&action=edit Bug 24395: Show initial float using the Price TT plugin on summary page For displaying monetary amounts, we should be using the Price TT plugin everywhere. This adds it to the cash register summary page. To test: - Create a cash register - Check the cash register table for "Initial float" - Verify the amount shows with more than 2 decimals - Edit cash register - verify the same display there - Apply patch - Check again - it should display now with only 2 decimals Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24395 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24395 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24395 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24395 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | Status|Pushed to master |Pushed to stable CC| |joy@bywatersolutions.com --- Comment #9 from Joy Nelson <joy@bywatersolutions.com> --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24395 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- no cash_registers.tt in 19.05.x, not backporting -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org