[Bug 17082] New: Translatability: Fix sentence splitting in member.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17082 Bug ID: 17082 Summary: Translatability: Fix sentence splitting in member.tt Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr Template file member.tt contains sentences splitted by tags leading to difficulties while translating. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17082 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |veron@veron.ch |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17082 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 54174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54174&action=edit Bug 17082: Translatability: Fix sentence splitting in member.tt This patch fixes sentences splitting in file koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt Fix is done with a new .inc file because the code is the same as in koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt To test: - Carefully review code changes - Test on a fresh install without example data (or save database and test with empty tables 'branches' and 'categories') - Go to Home > Patrons (members-home.pl) - Verify that a warnings appears aubout missing libraries and patron categories - Try to add a new patron (memberentry.pl) - Verify that the same messages are triggered - Verify that messages disappear as appropriate as soon as a library and a patron category are defined. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17082 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17082 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17082 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17082 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54174|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 54227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54227&action=edit [SIGNED-OFF] Bug 17082: Translatability: Fix sentence splitting in member.tt This patch fixes sentences splitting in file koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt Fix is done with a new .inc file because the code is the same as in koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt To test: - Carefully review code changes - Test on a fresh install without example data (or save database and test with empty tables 'branches' and 'categories') - Go to Home > Patrons (members-home.pl) - Verify that a warnings appears aubout missing libraries and patron categories - Try to add a new patron (memberentry.pl) - Verify that the same messages are triggered - Verify that messages disappear as appropriate as soon as a library and a patron category are defined. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Note: Filed Bug 17093 for JS error on patron entry form. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17082 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17082 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54227|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 54249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54249&action=edit [PASSED QA] Bug 17082: Translatability: Fix sentence splitting in member.tt This patch fixes sentences splitting in file koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt Fix is done with a new .inc file because the code is the same as in koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt To test: - Carefully review code changes - Test on a fresh install without example data (or save database and test with empty tables 'branches' and 'categories') - Go to Home > Patrons (members-home.pl) - Verify that a warnings appears aubout missing libraries and patron categories - Try to add a new patron (memberentry.pl) - Verify that the same messages are triggered - Verify that messages disappear as appropriate as soon as a library and a patron category are defined. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Note: Filed Bug 17093 for JS error on patron entry form. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17082 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Marc! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org