[Bug 6141] New: html glitches causing problems to translator
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6141 Bug #: 6141 Summary: html glitches causing problems to translator Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: trivial Priority: P5 Component: I18N/L10N AssignedTo: frederic@tamil.fr ReportedBy: julian.maurice@biblibre.com QAContact: koha-bugs@lists.koha-community.org * opac-topissue.pl = untranslatable string removed * moremember.pl: wrong " causing trouble to translator * authorities.pl missing _() in javascript -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6141 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> 2011-04-08 12:16:45 UTC --- Little correction in bug description: * opac-topissue.pl = untranslatable string removed * authorities.pl missing _() in javascript -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6141 --- Comment #2 from Julian Maurice <julian.maurice@biblibre.com> 2011-04-08 12:17:10 UTC --- Created attachment 3836 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3836 Patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6141 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6141 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6141 --- Comment #3 from Frédéric Demians <frederic@tamil.fr> 2011-05-13 12:38:22 UTC --- (In reply to comment #2)
Created attachment 3836 [details] Patch
It doesn't apply anymore on HEAD. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6141 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Does not apply -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6141 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3836|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 10011 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10011&action=edit Bug 6141 - html glitches causing problems to translator * opac-topissue.pl = untranslatable string removed * authorities.pl missing _() in javascript Rewrite of patch authored by Julian Maurice. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6141 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff CC| |kyle.m.hall@gmail.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6141 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10011|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 10035 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10035&action=edit Bug 6141 - html glitches causing problems to translator Simple fix, works... 'nuff said' -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6141 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize@ptfs-europe | |.com --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Signed off... but: Can anyone care to explain what the Importance being set to "PATCH-Sent (DO NOT USE)" actually means? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6141 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P3 Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: as Martin said : Simple fix, works... 'nuff said' & passed QA (In reply to comment #6)
Signed off... but: Can anyone care to explain what the Importance being set to "PATCH-Sent (DO NOT USE)" actually means?
Our workflow used to use this "PATCH sent" to warn that the patch has been sent. Now, and since some months, it's in the status, so this priority should not be used anymore, and it's here only for some legacy entries. Feel free to update priority if you encounter a bug with this priority ! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6141 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_8 Severity|trivial |minor -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6141 --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- Patch does not apply to 3.8.x, please reformat for 3.8.x. (It contains changes to do with authorities, which haven't been pushed to 3.8.x namely <<<<<<< HEAD ======= $(document).ready(function() { yuiToolbar(); $("#addauthc,#action").empty(); }); // YUI Toolbar Functions function yuiToolbar() { etc) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6141 --- Comment #9 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 10276 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10276&action=edit Bug 6141 - html glitches causing problems to translator - 3.8.x * opac-topissue.pl = untranslatable string removed * authorities.pl missing _() in javascript Rewrite of patch authored by Julian Maurice. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6141 --- Comment #10 from Kyle M Hall <kyle.m.hall@gmail.com> --- Chris, here you go. Does this need to go through so and qa? (In reply to comment #8)
Patch does not apply to 3.8.x, please reformat for 3.8.x.
(It contains changes to do with authorities, which haven't been pushed to 3.8.x namely
<<<<<<< HEAD ======= $(document).ready(function() { yuiToolbar(); $("#addauthc,#action").empty(); }); // YUI Toolbar Functions function yuiToolbar() {
etc)
-- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6141 --- Comment #11 from Chris Cormack <chris@bigballofwax.co.nz> --- (In reply to comment #10)
Chris, here you go. Does this need to go through so and qa?
Nope the original one was signed off, and this removes the conflicting code, I will test and push -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6141 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #12 from Chris Cormack <chris@bigballofwax.co.nz> --- Patch pushed to 3.8.x will be in 3.8.2 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org