[Bug 5356] New: Shipping billing addess improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 Summary: Shipping billing addess improvements Change sponsored?: Sponsored Product: Koha Version: rel_3_4 Platform: All URL: http://wiki.koha-community.org/wiki/Shipping_billing_a cq_RFC OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Acquisitions AssignedTo: henridamien@koha-fr.org ReportedBy: paul.poulain@biblibre.com QAContact: koha-bugs@lists.koha-community.org Estimated Hours: 0.0 Deadline: 2011-05-01 The library will be able to choose shipping and billing address at basket level. If those informations are filled at basket address, then they won't have to be filled at basketgroup. If shipping & billing addresses are filled at basket level, the information will be stored in the comment section of the basket. That will be usefull for libraries having a single basketgroup for the supplier, but different shipping/billing address -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7163 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> 2012-03-01 16:03:49 UTC --- BibLibre ref: MT5833 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|henridamien@koha-fr.org |jonathan.druart@biblibre.co | |m -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7302 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 8405 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8405&action=edit Bug 5356: delivery place and billing place centralised in basket management - adding 2 select option in basdketheader.tmpl (delivery and billing place) - adding 2 more fields in basket csv export Please test Bug 7302 with this patch. They are dependants... You can test it with a sandbox -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |koha@univ-lyon3.fr --- Comment #3 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- test on sandbox4 : After saving in http://pro.test4.biblibre.com/cgi-bin/koha/acqui/basketheader.pl?booksellerid=3&op=add_form Software error: Template process failed: file error - parse error - /home/koha/src/koha-tmpl/intranet-tmpl/prog/fr-FR/modules/acqui/basket.tt line 309: unexpected token (ELSE) [% ELSE %] at /home/koha/src/C4/Templates.pm line 127. For help, please send mail to the webmaster (webmaster@test4-sandbox), giving this error message and the time and date of the error. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8405|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 8409 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8409&action=edit Bug 5356: delivery place and billing place centralised in basket management FIX html template token :-/ In my last comment I missed a 'not'. In fact, you can NOT test this patch with a sandbox. You want apply Bug 5356 AND Bug 7302 together -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7298 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply --- Comment #5 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- try to apply on a Lyon3 branch rebase on the git-community/master. Can't apply : Applying: Bug 5356: delivery place and billing place centralised in basket management /home/kohabac/src/.git/rebase-apply/patch:76: trailing whitespace. $order->{'entrydate'}, error: patch failed: C4/Acquisition.pm:42 error: C4/Acquisition.pm: patch does not apply error: patch failed: acqui/basket.pl:129 error: acqui/basket.pl: patch does not apply error: patch failed: acqui/basketheader.pl:50 error: acqui/basketheader.pl: patch does not apply error: patch failed: installer/data/mysql/kohastructure.sql:2525 error: installer/data/mysql/kohastructure.sql: patch does not apply error: patch failed: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt:134 error: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt: patch does not apply error: patch failed: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt:189 error: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt: patch does not apply error: patch failed: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketheader.tt:125 error: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketheader.tt: patch does not apply Patch failed at 0001 Bug 5356: delivery place and billing place centralised in basket management When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Patch left in /tmp/Bug-5356-delivery-place-and-billing-place-centrali-MNbz5d.patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8409|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 8532 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8532&action=edit Bug 5356: delivery place and billing place centralised in basket management Rebased patch. Don't forget to apply Bug 7302 with this patch. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8532|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 8940 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8940&action=edit Bug 5356: delivery place and billing place centralised in basket management Rebased patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #8 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Applying after 7302. /home/kohabac/src/.git/rebase-apply/patch:76: trailing whitespace. $order->{'entrydate'}, error: patch failed: C4/Acquisition.pm:42 error: C4/Acquisition.pm: patch does not apply error: patch failed: installer/data/mysql/updatedatabase.pl:5146 error: installer/data/mysql/updatedatabase.pl: patch does not apply Patch failed at 0001 Bug 5356: delivery place and billing place centralised in basket management -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8940|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 9228 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9228&action=edit Bug 5356: delivery place and billing place centralised in basket management Rebased patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 --- Comment #10 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Still ..... Applying: Bug 5356: delivery place and billing place centralised in basket management /home/kohabac/src/.git/rebase-apply/patch:76: trailing whitespace. $order->{'entrydate'}, error: patch failed: C4/Acquisition.pm:42 error: C4/Acquisition.pm: patch does not apply Patch failed at 0001 Bug 5356: delivery place and billing place centralised in basket management -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9228|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 9230 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9230&action=edit Bug 5356: delivery place and billing place centralised in basket management Oups sorry, I rebased onto master. This patch is rebased onto master after aplying Bug 7302. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9230|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 9975 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9975&action=edit Bug 5356: delivery place and billing place centralised in basket management Rebased patch. This patch must be applied AFTER Bug 7302 ! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |katrin.fischer@bsz-bw.de --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Tried testing this together with 7302 and directly on master, but in both cases patch does not apply. Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: Bug 5356: delivery place and billing place centralised in basket management fatal: sha1 information is lacking or useless (C4/Acquisition.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 5356: delivery place and billing place centralised in basket management When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9975|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 10152 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10152&action=edit Bug 5356: delivery place and billing place centralised in basket management Rebased patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Asking for a follow up for: 1) Changing the display to show the library name instead of branchcode on the basket summary page. Currently shows: Basketgroup Delivery place: MPL Basketgroup Billing place: MPL 2) Maybe changing the branchcode to the description in the CSV export file ? Not sure about this one. 3) On basket header the pull downs for delivery place and billing place don't sort alphabetically by description, but I think by code. 4) Same sorting problem for the pull downs on the basket group page. Failing QA for: 5) I am testing this on top of 7302 and the colums for basket and basket group delivery and shipping places remain empty in my exported basket group CSV. Jonathan- could you perhaps fix that in a follow up? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 --- Comment #16 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 10201 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10201&action=edit Bug 5356: Followup sort and branchname - Sort is now the same as C4::Branch::GetBranchesLoop - branchcodes are replaced with branchnames 1) Done. 2) I don't understand what you want exactly. 3, 4) Done 5) If I edit a basket and set it a delivery and billing place. I add this basket to a basketgroup, close it and export it as csv, I have the 4 informations filled in the generated csv file. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10152|0 |1 is obsolete| | Attachment #10201|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 10338 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10338&action=edit [SIGNED-OFF] Bug 7302: Followup: rename "Client number" column with "Account number" Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10338|0 |1 is obsolete| | --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 10340 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10340&action=edit [SIGNED-OFF] Bug 5356: delivery place and billing place centralised in basket management - adding 2 select option in basdketheader.tmpl (delivery and billing place) - adding 2 more fields in basket csv export Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tested together with patches for bug 7302. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 10341 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10341&action=edit [SIGNED-OFF] Bug 5356: Followup sort and branchname - Sort is now the same as C4::Branch::GetBranchesLoop - branchcodes are replaced with branchnames Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Version|rel_3_4 |master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez@biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #20 from Paul Poulain <paul.poulain@biblibre.com> --- This patch does not apply on C4/Acquisition.pm: <<<<<<< HEAD ModBasketHeader($basket, $basketname || '', $basketnote || '', $basketbooksellernote || '', $basketcontractnumber || undef, $booksellerid); ======= ModBasketHeader( $basket, $basketname || '', $basketnote || '', $basketbooksellernote || '', $basketcontractnumber || undef, $deliveryplace || undef, $billingplace || undef );
> Bug 5356: delivery place and billing place centralised in basket management
It seems it's a consequence of bug 8247 patch. I think the solution is to have: ModBasketHeader( $basket, $basketname || '', $basketnote || '', $basketbooksellernote || '', $basketcontractnumber || undef, $deliveryplace || undef, $billingplace || undef, $booksellerid ); and rewrite ModBasketHeader accordingly (ie = reintroduce booksellerid at the end of the API) QA comments: perlcritic does not pass: perlcritic acqui/basket.pl acqui/basketheader.pl acqui/basket.pl source OK acqui/basketheader.pl: Variable declared in conditional statement at line 135, column 9. Declare variables outside of the condition. (Severity: 5) acqui/basketheader.pl: Variable declared in conditional statement at line 159, column 9. Declare variables outside of the condition. (Severity: 5) (they were OK before the patch valid_tt.t, xt/author/translatable-templates.t and xt/author/valid-templates.t ar OK It would be better to specify where the fields should be added in the table: + $dbh->do("ALTER TABLE aqbasket ADD deliveryplace VARCHAR(10) default NULL;"); + $dbh->do("ALTER TABLE aqbasket ADD billingplace VARCHAR(10) default NULL;"); + $dbh->do("ALTER TABLE aqbasket ADD freedeliveryplace VARCHAR(10) default NULL;"); add a "AFTER anotherfieldname" to the declaration. I would not have requested that only, but as the patch does not apply and I have other concerns... -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10340|0 |1 is obsolete| | Attachment #10341|0 |1 is obsolete| | --- Comment #21 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 11120 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11120&action=edit Bug 5356: delivery place and billing place centralised in basket management Rebased patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |m.de.rooy@rijksmuseum.nl QA Contact|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | --- Comment #22 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: Depending on earlier tests: Code looks good to me. Apparently, several older qa comments have been incorporated. Patch applies. Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Shipping billing addess |Shipping billing address |improvements |improvements -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #23 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: Testing this patch, there is something important missing = if you print the basketgroup PDF, you won't get the basket shipping/billing. Libraries using that will say it's a bug, no doubts. It should not be too hard to add those columns in the tables presenting the baskets on layout2pages and layout3pages (.pm and .pdf) Entering & exporting those new columns is OK though -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 --- Comment #24 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 11952 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11952&action=edit Bug 5356: Followup: Add basket billing and delivery place on export pdf (layout3pages) Hi Paul, This patch adds the basket billing place and delivery place in the generated pdf. But only for the layout3pages. Indeed, there are no space to add these information. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #25 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #24)
Created attachment 11952 [details] Bug 5356: Followup: Add basket billing and delivery place on export pdf (layout3pages)
Hi Paul, This patch adds the basket billing place and delivery place in the generated pdf. But only for the layout3pages. Indeed, there are no space to add these information.
Sounds logicall not to have the information on layout2pages, as it's all basket mixed (sorted by publisher/title). So, passed QA ! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 --- Comment #26 from Paul Poulain <paul.poulain@biblibre.com> --- Well, testing this feature & QAing the code one more time, a question arise: what is the "freedeliveryplace" done for ? * in aqbasketgroup, it was a TEXT, in this patch, for aqbasket it's a varchar(10), that is tiny for a free address ! * I can't see where I can file this freedeliveryplace field (not failing QA until i've an anwser to those questions) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 --- Comment #27 from Paul Poulain <paul.poulain@biblibre.com> --- PS: if you switch to a text field, please don't do in a follow-up. updatedatabase conflicts are very very common, and it's a pain to apply a follow-up that update updatedatabase ! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11120|0 |1 is obsolete| | --- Comment #28 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 12376 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12376&action=edit Bug 5356: delivery place and billing place centralised in basket management - adding 2 select option in basdketheader.tmpl (delivery and billing place) - adding 2 more fields in basket csv export Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tested together with patches for bug 7302. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11952|0 |1 is obsolete| | --- Comment #29 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 12377 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12377&action=edit Bug 5356: Followup: Add basket billing and delivery place on export pdf (layout3pages) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 --- Comment #30 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #26)
Well, testing this feature & QAing the code one more time, a question arise: what is the "freedeliveryplace" done for ? * in aqbasketgroup, it was a TEXT, in this patch, for aqbasket it's a varchar(10), that is tiny for a free address ! * I can't see where I can file this freedeliveryplace field
(not failing QA until i've an anwser to those questions)
Paul, In fact the aqbasket.freedeliveryplace is unused. So I removed it in the last patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 --- Comment #31 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: I think this line is wrong: + basketgroupdeliveryplace => C4::Branch::GetBranchName( $basketgroup->{deliveryplace} ) || C4::Branch::GetBranchName( $basketgroup->{freedeliveryplace} ), C4::Branch::GetBranchName( $basketgroup->{freedeliveryplace} ) will never work, because freedeliveryplace is free, so not related to a branch code ! do we agree ? (found this problem when checking if freedeliveryplace had been removed from your patches ;-) ) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 --- Comment #32 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 12407 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12407&action=edit Bug 5356: Followup: remove useless code -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 --- Comment #33 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #31)
QA comment: I think this line is wrong: + basketgroupdeliveryplace => C4::Branch::GetBranchName( $basketgroup->{deliveryplace} ) || C4::Branch::GetBranchName( $basketgroup->{freedeliveryplace} ), do we agree ?
Yes. I removed it in the last patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_10 --- Comment #34 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed. a small follow-up will be required in the display of layout3pages (screenshot attached) When the library description is long, it goes to far on the right. We should put things on 2 lines (and/or reduce the font size) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 --- Comment #35 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 12484 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12484&action=edit Screenshot of library name too far on the right -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12376|0 |1 is obsolete| | Attachment #12377|0 |1 is obsolete| | Attachment #12407|0 |1 is obsolete| | --- Comment #36 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 12838 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12838&action=edit Bug 5356: Followup Change font in the layout3pages pdf -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #37 from Paul Poulain <paul.poulain@biblibre.com> --- tiny follow-up tested, fixes the problem by using a smaller font, well done -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org