https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17352 Barton Chittenden <barton@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17352 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 55823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55823&action=edit Bug 17352 - Patron search type is hard coded to 'contain' in circ/circulation.pl The patron search type is hard coded to 'contain' in circ/circulation.pl. This causes problems because a mis-scanned cardnumber can bring up the wrong patron. The example that our partner gave us involved scanning '1733', which doesn't match any borrowers when we do a 'start_with' search, but matches the cardnumber 'p291733'. If we follow the usage in members/member.pl, we can set searchtype in HTTP params, which is amenable to fixes in intranetuserjs Test Plan: 1) Apply this patch 2) Use the checkout search, not changes should be noted Extra credit: 1) Add javascript to intranetuserjs to add a hidden input named 'searchtype' with the value 'start_with' 2) Checkout searches should now give only results where a searched field starts with the given string(s) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17352 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55823|0 |1 is obsolete| | --- Comment #2 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 55832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55832&action=edit Bug 17352 - Patron search type is hard coded to 'contain' in circ/circulation.pl The patron search type is hard coded to 'contain' in circ/circulation.pl. This causes problems because a mis-scanned cardnumber can bring up the wrong patron. The example that our partner gave us involved scanning '1733', which doesn't match any borrowers when we do a 'start_with' search, but matches the cardnumber 'p291733'. If we follow the usage in members/member.pl, we can set searchtype in HTTP params, which is amenable to fixes in intranetuserjs Test Plan: 1) Apply this patch 2) Use the checkout search, not changes should be noted Extra credit: 1) Add javascript to intranetuserjs to add a hidden input named 'searchtype' with the value 'start_with' 2) Checkout searches should now give only results where a searched field starts with the given string(s) Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Tested with extra ;) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17352 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17352 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master, thanks for the quick turnaround on this Josef, Jonathan! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17352 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |frederic@tamil.fr --- Comment #6 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.05. -- You are receiving this mail because: You are watching all bug changes.