[Bug 20479] New: Superlibrarians cannot log into opac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20479 Bug ID: 20479 Summary: Superlibrarians cannot log into opac Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Bug 15492 kicks out users who have self checkin permissions, let's not kick out superlibrarians -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20479 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20479 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 73311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73311&action=edit Bug 20479 - Don't kick superlibrarians out of the opac To test: 1 - Try to log in to opac with a superlibrarian 2 - Everythign goes wrong 3 - Apply patch 4 - Try to log in with superlibrarian 5 - You can sign in -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20479 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |nick@bywatersolutions.com Depends on| |15492 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492 [Bug 15492] Stand alone self check-in tool -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20479 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20479 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73311|0 |1 is obsolete| | --- Comment #2 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 73312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73312&action=edit Bug 20479 - Don't kick superlibrarians out of the opac To test: 1 - Try to log in to opac with a superlibrarian 2 - Everythign goes wrong 3 - Apply patch 4 - Try to log in with superlibrarian 5 - You can sign in Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20479 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Claire Gravely from comment #2)
Created attachment 73312 [details] [review] Bug 20479 - Don't kick superlibrarians out of the opac
To test: 1 - Try to log in to opac with a superlibrarian 2 - Everythign goes wrong 3 - Apply patch 4 - Try to log in with superlibrarian 5 - You can sign in
Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
The patch is almost correct: it will fail for the DB user. BTW: I filed 20480 for the styling issue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20479 --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 73321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73321&action=edit Bug 20479 (follow-up) Don't try to get flags for database user Login will still break in opac-user.pl, but that seems a bigger problem not from SCI module -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20479 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 73326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73326&action=edit Bug 20479: Use instead of fetching patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20479 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73312|0 |1 is obsolete| | --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 73327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73327&action=edit Bug 20479: Don't kick superlibrarians out of the opac To test: 1 - Try to log in to opac with a superlibrarian 2 - Everythign goes wrong 3 - Apply patch 4 - Try to log in with superlibrarian 5 - You can sign in Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20479 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73321|0 |1 is obsolete| | --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 73328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73328&action=edit Bug 20479: (follow-up) Don't try to get flags for database user Login will still break in opac-user.pl, but that seems a bigger problem not from SCI module Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20479 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73326|0 |1 is obsolete| | --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 73329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73329&action=edit Bug 20479: Use instead of fetching patron Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20479 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20479 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20479 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 73331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73331&action=edit Bug 20479: Use $flag instead of fetching patron Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20479 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- We could use $flags instead of haspermission, but it will make the code less readable. Maybe we need to create a new subroutine. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20479 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73329|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20479 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 73337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73337&action=edit Bug 20479: Ease readability - do not enter the block if not logged in -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20479 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20479 Bug 20479 depends on bug 15492, which changed state. Bug 15492 Summary: Stand alone self check-in tool https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20479 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- Depends on feature not in stable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20479 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20649 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20649 [Bug 20649] C4::Auth should use C4::Context->IsSuperLibrarian() -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org