[Bug 13237] New: Regression: List of previous checkouts should be ordered by due date ascending
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13237 Bug ID: 13237 Summary: Regression: List of previous checkouts should be ordered by due date ascending Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: kyle@bywatersolutions.com Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Depends on: 11703 Before Bug 11703 the list of previous checkouts on a patrons account were ordered with the oldest checkouts first. Now previous checkouts are shown with the newest checkouts first, breaking a sorting default which has been in place for years. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13237 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Note, the sorting of the checkouts was previously controlled by previousIssuesDefaultSortOrder & todaysIssuesDefaultSortOrder. These settings were taken into account in svc/checkouts but at some point the datatables took over the initial sorting, which broke the feature afaict. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13237 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13237 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 33523 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33523&action=edit Bug 13237 - Regression: List of previous checkouts should be ordered by due date ascending Before Bug 11703 the list of previous checkouts on a patrons account were ordered with the oldest checkouts first. Now previous checkouts are shown with the newest checkouts first, breaking a sorting default which has been in place for years. Note, the sorting of the checkouts was previously controlled by previousIssuesDefaultSortOrder & todaysIssuesDefaultSortOrder. These settings were taken into account in svc/checkouts but at some point the datatables took over the initial sorting, which broke the feature afaict. Test Plan: 1) Find a patron with a set of previous and today's checkouts 2) Note the system preferences previousIssuesDefaultSortOrder and todaysIssuesDefaultSortOrder are ignored for the initial sorting view. Also not the sorting by due date does not work correctly. 3) Apply this patch 4) Test both system preferences with each setting, note the correct sort order. 5) Sort the checkouts by due date, note the correct sort order. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13237 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13237 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 33569 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33569&action=edit Broken table ordering after apply the patch I'm getting broken table ordering after applying this patch. I applied the patch, cleared the browser cache, and checked out some items. Then I reloaded the page and got this result. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13237 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13237 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- I saw this exact behavior during the development of this patch. However, I can't reproduce it using the submitted patch. Can you try clearing your browser cache and retesting? (In reply to Owen Leonard from comment #3)
Created attachment 33569 [details] Broken table ordering after apply the patch
I'm getting broken table ordering after applying this patch. I applied the patch, cleared the browser cache, and checked out some items. Then I reloaded the page and got this result.
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13237 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Kyle M Hall from comment #4)
Can you try clearing your browser cache and retesting?
Sorry, I got the same results after trying again. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13237 jdemuth@roseville.ca.us <jdemuth@roseville.ca.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth@roseville.ca.us -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13237 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate CC| |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13237 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |INVALID --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- I think bug 13908 fixed this issue. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org