[Bug 27379] New: Autocomplete addresses for a patron using Google Places API (Maps).
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27379 Bug ID: 27379 Summary: Autocomplete addresses for a patron using Google Places API (Maps). Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: ivan.dziuba@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Created attachment 115043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115043&action=edit Google suggests addresses We are starting fill an address for a patron, Google suggests addresses which are related with patron's address. When you select a suitable address, the corresponding fields are filled automatically. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27379 Ivan Dziuba <ivan.dziuba@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ivan.dziuba@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27379 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I know a lot of libraries would really like this, but for some there might be data privacy concerns. If we add this, can we please make it optional? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27379 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27379 Ivan Dziuba <ivan.dziuba@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric.begin@inLibro.com, | |philippe.blouin@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27379 --- Comment #2 from Ivan Dziuba <ivan.dziuba@inlibro.com> --- Created attachment 115097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115097&action=edit Bug 27379 - Autocomplete addresses for a patron using Google Places API (Maps). This patch adds the preference 'GooglePlacesAPI'. You need do ./updatedatabase.pl Now, we can fill API Key Google Places and use autocomplete for addresses. This patch works on the pages: 1. moremember.pl (Add/Edit patron). Field: - Address (Main address, Alternate address, Alternate contact) 2. supplier.pl (Add/Edit vendor). Fields: - Postal address. - Physical address. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27379 Ivan Dziuba <ivan.dziuba@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #3 from Ivan Dziuba <ivan.dziuba@inlibro.com> --- (In reply to Katrin Fischer from comment #1)
I know a lot of libraries would really like this, but for some there might be data privacy concerns. If we add this, can we please make it optional?
Yes, it is optional. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27379 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27379 --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Hey Ivan, I think a lot of libraries would find this useful. When I apply the patch, and create an deveolpers API with Google, then attempt to test this patch I get the following console error: You must enable Billing on the Google Cloud Project at https://console.cloud.google.com/project/_/billing/enable Learn more at https://developers.google.com/maps/gmp-get-started Places API error: BillingNotEnabledMapError https://developers.google.com/maps/documentation/javascript/error-messages#b... Although I can get a 'free trial account' I still have to provide Google with a credit card and billing information, making this patch difficult to test. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27379 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- I see a few issues with this: 1. There are errors returned by the QA tool 2. In the "Alternate address" section the zip code does not get filled in. I see an error in the console, Uncaught TypeError: type_google is undefined 3. In the alternate contact section when I select an address from the dropdown the number is separated from the street by a comma: 95, West Washington Street. The comma shouldn't be there. 4. In both the main and alternate address sections, if I disable the "streetnumber" fields (streetnumber and B_streetnumber), the number isn't appended to the street name in the address field. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27379 Ivan Dziuba <ivan.dziuba@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |ivan.dziuba@inlibro.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27379 Benjamin Daeuber <bdaeuber@cityoffargo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdaeuber@cityoffargo.com --- Comment #6 from Benjamin Daeuber <bdaeuber@cityoffargo.com> --- Is this better approached as a plugin? This development locks libraries into Google Maps, where if this were a plugin, it's easier to use alternate providers. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27379 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- External APIs lend themselves to plugins as they can then be easier kept up to date if anything about the API changes. Should we mark this WONTFIX here maybe? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27379 --- Comment #8 from David Cook <dcook@prosentient.com.au> --- (In reply to Katrin Fischer from comment #7)
External APIs lend themselves to plugins as they can then be easier kept up to date if anything about the API changes.
Should we mark this WONTFIX here maybe?
I'm thinking so -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27379 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Inlibro: do you agree with closing? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27379 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|Failed QA |RESOLVED --- Comment #10 from Blou <philippe.blouin@inlibro.com> --- yes, you can close it. We'll revive as a plugin if needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org