[Bug 26867] New: Holds to Pull should use cn_sort
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26867 Bug ID: 26867 Summary: Holds to Pull should use cn_sort Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com To recreate: - create three bibs, each with one item. those items should have these call numbers: -- JC43 .G6 1890 -- JC330 .F74 2000 -- JC480 .R63 2006 - place an item level hold on each item - go to Holds To Pull, sort by call number - notice items are order incorrectly, going 330, 43, 480 - use a report to pull the cn_sort values for your 3 items, confirm that ordering by cn_sort in your report correctly orders them 43, 330, 480 We should use cn_sort here to get them in the correct order. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26867 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25897 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26867 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26867 SamSowanick <sam.sowanick@corvallisoregon.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sam.sowanick@corvallisorego | |n.gov --- Comment #1 from SamSowanick <sam.sowanick@corvallisoregon.gov> --- +1 We are seeing improperly sorted items on our picklist. If sorting by CN_SORT solves this, I think it would be a good idea. I don't know how to do this but hope this comment bumps this closer to a developers lap :). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26867 --- Comment #2 from Andrii Nugged <nugged@gmail.com> --- Created attachment 203938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203938&action=edit Bug 26867: Sort Holds to pull by cn_sort Holds to pull renders one row per bibliographic record and can list several available call numbers in that row. DataTables currently compares the displayed call number text, so classification numbers such as JC43 and JC330 are ordered as JC330, JC43. Order the available call numbers by their normalized classification keys and expose the first key through the table cell's data-order attribute. If an older item has no cn_sort value, retain its displayed call number as the fallback sort key. Add a self-contained Cypress regression for ascending and descending row sorting, aggregated call numbers, and the missing-cn_sort fallback. Test plan: Before applying the patch: 1. Create three bibliographic records with one item each. 2. Give the items the call numbers JC43 .G6 1890, JC330 .F74 2000, and JC480 .R63 2006. 3. Use LOC as the classification source for each item. 4. Place a hold on each bibliographic record. 5. Go to Circulation > Holds to pull. 6. Sort the Available call numbers column in ascending order. 7. Confirm that the items appear as JC330, JC43, JC480. Apply the patch. After applying the patch: 1. Return to Circulation > Holds to pull. 2. Sort the Available call numbers column in ascending order. 3. Confirm that the items appear as JC43, JC330, JC480. Automated tests: 1. yarn cypress run --spec \ t/cypress/integration/KohaTable/PendingHoldsCallNumbers_spec.ts 2. prove -I. -It/lib t/db_dependent/Koha/Holds.t Co-Authored-By: Loontik <loontik@nugged.team> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26867 Andrii Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nugged@gmail.com |ity.org | Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org