[Bug 20185] New: Some scripts does not pass perl -wc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20185 Bug ID: 20185 Summary: Some scripts does not pass perl -wc Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: In Discussion Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20185 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I guess it's the consequence of the push of patches related to bug 2505 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20185 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71484&action=edit Bug 20185: Remove warnings from aqplan.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20185 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71497&action=edit Bug 20185: Remove warnings from stats.print.pl This needs a full rewrite! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20185 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Sounds like there are no more. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20185 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19992 --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Jonathan Druart from comment #1)
I guess it's the consequence of the push of patches related to bug 2505
And people changing strict/warnings, or some combination thereof, into Modern::Perl, without checking? I did comment in a warning fashion on bug 20000 comment #2. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20185 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20012 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20185 --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- Running the following to confirm comment #4: for i in `find . -type f -name "*.p[lm]"`; do perl -wc $i; done -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20185 --- Comment #7 from M. Tompsett <mtompset@hotmail.com> --- After getting Catmandu stuff better installed, and hacking softlinks in the path to VerboseWarnings.pm and TmplTokenizer.pm, most problems go away. These two patches are fine. However, what about the horrors of files with multiple packages: C4/Barcodes.pm and OpenILS/QueryParser.pm? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20185 --- Comment #8 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 71484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71484 Bug 20185: Remove warnings from aqplan.pl Review of attachment 71484: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20185&attachment=71484) ----------------------------------------------------------------- ::: admin/aqplan.pl @@ +36,4 @@
use C4::Debug; use Koha::Acquisition::Currencies;
+our $input = new CGI;
If we are already tweaking the line, why not the new syntax? CGI->new? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20185 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to M. Tompsett from comment #6)
Running the following to confirm comment #4: for i in `find . -type f -name "*.p[lm]"`; do perl -wc $i; done
or simply `find . -name "*.pl" -exec perl -wc {} \;` yes. (In reply to M. Tompsett from comment #7)
After getting Catmandu stuff better installed, and hacking softlinks in the path to VerboseWarnings.pm and TmplTokenizer.pm, most problems go away. These two patches are fine. However, what about the horrors of files with multiple packages: C4/Barcodes.pm and OpenILS/QueryParser.pm?
The rewrite of these modules is for somewhere else (and somebody else :)) (In reply to M. Tompsett from comment #8)
If we are already tweaking the line, why not the new syntax? CGI->new?
Feel free to open a bug report to replace all the occurrence of "new CGI" if you think it is useful/major. The variable scoping problem is critical under plack. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20185 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71484|0 |1 is obsolete| | --- Comment #10 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 71561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71561&action=edit Bug 20185: Remove warnings from aqplan.pl Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20185 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71497|0 |1 is obsolete| | --- Comment #11 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 71562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71562&action=edit Bug 20185: Remove warnings from stats.print.pl This needs a full rewrite! Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20185 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20185 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20201 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20201 [Bug 20201] Silence warnings in admin/aqplan.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20185 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Summary|Some scripts does not pass |Some scripts don't pass |perl -wc |perl -wc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20185 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #12 from Julian Maurice <julian.maurice@biblibre.com> --- git grep 'stats.print.pl' returns nothing and when run from a shell it dies with Undefined subroutine &main::getcredits called at reports/stats.print.pl line 126. Is this script still used ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20185 --- Comment #13 from Julian Maurice <julian.maurice@biblibre.com> --- The last occurence of stats.print.pl was removed by commit ca4b23e929b2636054263cab35f50a07dc8a02e4 Author: Chris Cormack <crc@liblime.com> AuthorDate: Mon Jan 7 20:42:36 2008 -0600 Commit: Joshua Ferraro <jmf@liblime.com> CommitDate: Mon Jan 7 20:49:16 2008 -0600 Work in progress, working on the til reconciliation report More patches to come Signed-off-by: Joshua Ferraro <jmf@liblime.com> I will open a new report to remove this script. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20185 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71561|0 |1 is obsolete| | --- Comment #14 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 71708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71708&action=edit Bug 20185: Remove warnings from aqplan.pl Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20185 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71562|0 |1 is obsolete| | --- Comment #15 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 71709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71709&action=edit Bug 20185: Remove warnings from stats.print.pl This needs a full rewrite! Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20185 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20185 --- Comment #16 from Julian Maurice <julian.maurice@biblibre.com> --- Passed QA. Script removal in bug 20225 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20185 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20185 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=39365 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org