https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38772 --- Comment #1 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 175909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175909&action=edit Bug 38772: Typo 'minPasswordPreference' system preference Typo in system preference 'minPasswordPreference' -> 'minPasswordLength' in opac/opac-password-recovery.pl There is no 'minPasswordPreference' system preference in database. Bug 23816 added the capability to override minPasswordLength. Test plan: ========== 1. Check 'minPasswordPreference' appearances: git grep -i 'minPasswordPreference' **/* --> Note: only one in opac-password-recovery.pl; no one in sysprefs.sql 2. Apply the patch. 3. Repeat p. 1. Note there is not 'minPasswordPreference' at all. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38772 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38772 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Main CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- I've signed off, as it does appear to be a typo, and there is no minPasswordPreference system preference. However, this change makes no difference in actually resetting your password. Question for QA: So is this code still required/redundant/something else going on? I tested the OPAC password recovery process before and after applying the patch, and it worked as expected. I'm not a developer, so I have no idea how the underlying code works! Testing notes (KTD): 1. In the staff interface, check that the minPasswordPreference system preference DOES NOT exist. 2. In the staff interface, check that minPasswordLength system preference DOES exist (default is set to 8). 3. Set OpacResetPassword system preference to "Allow". 4. Set up KTD so that you can send emails [1]. 5. Add an email address to a patron, and change their credentials/password so that you can log in to the OPAC as that patron. 6. In the OPAC (logged out), select the "Forgot your password?" link, enter card number/user name, or email address. 7. Use the link in the email to reset the password. 8. Note that if the password length is less than the minimum length (before and after the patch), you can't reset your password unless it meets the minimum length. [1]. To test sending emails using a Google account: 1. Set up an App password for your Google Account. 2. Configure a new 'SMTP Server' under 'Administration > SMTP servers' using the following settings, where `User name` = your Google email address and `Password` = your APP password, not your Google account password): Host: smtp.gmail.com Port: 587 Timeout: 5 SSL: STARTTLS User name: GOOGLEACCOUNTUSER Password: GOOGLEAPPPASSWORD Debug mode: Enabled Default server: selected -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38772 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38772 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes a type in the release notes| |code for OPAC password | |recovery - | |'minPasswordPreference' to | |'minPasswordLength' (the | |correct system preference | |name). It has no effect on | |the ability to reset an | |OPAC account password. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38772 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00,24.11.03 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38772 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Version(s)|25.05.00,24.11.03 |25.05.00,24.11.03,24.05.09 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #7 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Applied to 24.05.x for 24.05.09 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38772 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00,24.11.03,24.05.09 |25.05.00,24.11.03,24.05.09, released in| |23.11.14 Status|Pushed to oldstable |Pushed to oldoldstable CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.14 -- You are receiving this mail because: You are watching all bug changes.