[Bug 30885] New: Recall - detail page explosion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30885 Bug ID: 30885 Summary: Recall - detail page explosion Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Depends on: 30876 If you have a recall on a bibliographic record, its detail page explode with: Template process failed: undef error - The method Koha::Recall->waitingdate is not covered by tests! Then, if you fix the typo: Template process failed: undef error - The method Koha::Recall->borrowernumber is not covered by tests! And then it's fun... Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30876 [Bug 30876] recalls/recalls_to_pull.pl introduces an incorrect use of ->search in list context -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30885 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30885 --- Comment #1 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 135631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135631&action=edit Bug 30885: Display recall data correctly This page does not pull the recall columns correctly. To test: 1) Enable the UseRecalls system preference and set up your recalls-related circulation rules. 2) Check out an item to Patron B. 3) Log into the OPAC as Patron A and search for the item. 4) Place an item-level recall on that item. 5) Go back to the OPAC and search for the item. Confirm that when you go to the record detail page, it explodes and errors are shown. 6) Apply patch and refresh page. 7) Confirm page loads as expected. 8) Check the Status information for the item in the Holdings table. Confirm it shows the recall information correctly. 9) Check in the item and confirm the recall as waiting for Patron A. 10) Go back to the record detail page and confirm the Status information for the item shows as Waiting in the Holdings table. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30885 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored CC| |aleisha@catalyst.net.nz Assignee|koha-bugs@lists.koha-commun |aleisha@catalyst.net.nz |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30885 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19532 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 [Bug 19532] Recalls for Koha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30885 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27272 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30885 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30885 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135631|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 135681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135681&action=edit Bug 30885: Display recall data correctly This page does not pull the recall columns correctly. To test: 1) Enable the UseRecalls system preference and set up your recalls-related circulation rules. 2) Check out an item to Patron B. 3) Log into the OPAC as Patron A and search for the item. 4) Place an item-level recall on that item. 5) Go back to the OPAC and search for the item. Confirm that when you go to the record detail page, it explodes and errors are shown. 6) Apply patch and refresh page. 7) Confirm page loads as expected. 8) Check the Status information for the item in the Holdings table. Confirm it shows the recall information correctly. 9) Check in the item and confirm the recall as waiting for Patron A. 10) Go back to the record detail page and confirm the Status information for the item shows as Waiting in the Holdings table. Sponsored-by: Catalyst IT Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30885 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes (using koha-testing-docker): 1. Step 5: this should be the staff interface. 2. If there are no transfers required, things all work as expected (that is, Patron A + B and item are all in the same library). 3. However, if the patrons are in different libraries and transfers are required, I had an error on the transfers to receive page: (a) Used Mary Burton as Patron B (Midway), and Henry Acevedo as Patron A (Midway), and Programming Perl (record #262). (b) Follow the test plan to step 9, then changed library to Midway (c) Go to Circulation > Transfers > Transfers to receive (d) Get error trace - see details below under errors > 3(d) 4. When cancelling/reverting the hold (after following the test plan to step 9 for a, b, c, and d), I noticed these issues - I presume these should be a separate bug(s): (a) Recalls tab on the item details page (staff interface): nothing happens when you click on 'Cancel recall and return to Centerville' (can cancel by clicking the check box and selecting the 'Cancel selected recalls' button). (b) Go to Circulation > Recalls > Recalls queue: nothing happens when you click on 'Cancel recall and return to: Centerville' (can cancel by clicking the check box and selecting the 'Cancel selected recalls' button). (c) Go to the patron details section for Henry and then select the Recalls tab: nothing happens when you click on Actions > 'Cancel recall and return to: Centerville'. (d) Go to Circulation > Recalls > Recalls to pull > select Cancel recall and return to: Centerville: get error - see details below under errors > 4(d) Errors ------- 3(d) - Change library to Midway: Circulation > Transfers > Transfers to receive ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Template process failed: undef error - The method Koha::Recall->borrowernumber is not covered by tests! Trace begun at /kohadevbox/koha/Koha/Object.pm line 875 Koha::Object::AUTOLOAD('Koha::Recall=HASH(0x5566df86c340)') called at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/transferstoreceive.tt line 93 eval {...} at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/transferstoreceive.tt line 93 ..... 4(d) - Circulation > Recalls > Recalls to pull > select 'Cancel recall and return to: Centerville' ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Data truncated for column 'reason' at row 1 at /kohadevbox/koha/Koha/Object.pm line 170 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 in DBIx::Class::Exception::throw at /usr/share/perl5/DBIx/Class/Exception.pm line 77 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30885 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29734 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29734 [Bug 29734] [OMNIBUS] Recalls for Koha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30885 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30885 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30885 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135681|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 135706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135706&action=edit Bug 30885: Display recall data correctly This page does not pull the recall columns correctly. To test: 1) Enable the UseRecalls system preference and set up your recalls-related circulation rules. 2) Check out an item to Patron B. 3) Log into the OPAC as Patron A and search for the item. 4) Place an item-level recall on that item. 5) Go back to the staff interface and search for the item. Confirm that when you go to the record detail page, it explodes and errors are shown. 6) Apply patch and refresh page. 7) Confirm page loads as expected. 8) Check the Status information for the item in the Holdings table. Confirm it shows the recall information correctly. 9) Check in the item and confirm the recall as waiting for Patron A. 10) Go back to the record detail page and confirm the Status information for the item shows as Waiting in the Holdings table. Sponsored-by: Catalyst IT Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30885 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30885 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30885 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Version(s)|22.11.00 |22.11.00, 22.05.01 released in| | Status|Pushed to master |Pushed to stable --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Pushed to 22.05.x for 22.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30885 Bug 30885 depends on bug 19532, which changed state. Bug 19532 Summary: Recalls for Koha https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |Needs documenting Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30885 Bug 30885 depends on bug 30876, which changed state. Bug 30876 Summary: recalls/recalls_to_pull.pl introduces an incorrect use of ->search in list context https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30876 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30885 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |arthur.suzuki@biblibre.com --- Comment #7 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- depends on recalls, not available in 21.11. won't backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30885 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30885 Bug 30885 depends on bug 19532, which changed state. Bug 19532 Summary: Recalls for Koha https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org