[Bug 21364] New: Allow deletion of basket from vendor search/view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 Bug ID: 21364 Summary: Allow deletion of basket from vendor search/view Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: nick@bywatersolutions.com Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 79015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79015&action=edit Bug 21364: Allow closing basket from vendor view/search To test: 1 - Have a vendor 2 - Add some empty baskets 3 - Add some non-empty baskets 4 - Search for vendor and note you now a - Can only 'View' empty or closed baskets b - Have a dropup menu to 'Add to ' or 'Close' open baskets 5 - Confirm things look correct and buttons work -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Allow deletion of basket |Allow closing basket from |from vendor search/view |vendor search/view -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79015|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 79019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79019&action=edit Bug 21364: Allow closing basket from vendor view/search To test: 1 - Have a vendor 2 - Add some empty baskets 3 - Add some non-empty baskets 4 - Search for vendor and note you now a - Can only 'View' empty or closed baskets b - Have a dropup menu to 'Add to ' or 'Close' open baskets 5 - Confirm things look correct and buttons work Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr Status|Needs Signoff |Signed Off --- Comment #3 from Séverine Queune <severine.queune@bulac.fr> --- Step 4 is slightly different as described but I thing behaviour in Koha is the one expected : a - empty basket show "View" button and dropdown menu with only "Add to basket" option b - no-empty basket show "View" button and dropdown menu with "Add" and "Close" options c - close basket show only "View" button Everything behaves as expected so thanks a lot Nick !! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicolas.legrand@bulac.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Nick, can you please reindent this block correctly as well as no splitting the html nodes on several lines -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 79069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79069&action=edit Bug 21364: (follow-up) Tidy indentation and remove copy/paste newlines -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Maybe this is out of scope, I don't know... I've never thought about it before, but having a "view" button doesn't fit common practices at all. The name of the basket should be a link to the view. What about this: - Link the basket name to the view. - Keep the split button, but making "Add to basket" the main action. - In the menu, put "edit," "close," and "delete." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79019|0 |1 is obsolete| | Attachment #79069|0 |1 is obsolete| | --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 79106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79106&action=edit Bug 21364: Allow closing basket from vendor view/search To test: 1 - Have a vendor 2 - Add some empty baskets 3 - Add some non-empty baskets 4 - Search for vendor and note you now a - Can only 'View' empty or closed baskets b - Have a dropup menu to 'Add to ' or 'Close' open baskets 5 - Confirm things look correct and buttons work 6 - Confirm that basket name is now a link to view basket -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79106|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 79121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79121&action=edit Bug 21364: Allow closing basket from vendor view/search To test: 1 - Have a vendor 2 - Add some empty baskets 3 - Add some non-empty baskets 4 - Search for vendor and note you now a - Can only 'View' empty or closed baskets b - Have a dropup menu to 'Add to ' or 'Close' open baskets 5 - Confirm things look correct and buttons work 6 - Confirm that basket name is now a link to view basket Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Owen Leonard from comment #8)
4 - Search for vendor and note you now a - Can only 'View' empty or closed baskets
Not true, but behavior is correct. Can only "view" if basket is closed. If basket is empty we can "view" and "add to" (In reply to Owen Leonard from comment #6)
- Keep the split button, but making "Add to basket" the main action.
Finally this has not been done, any good reasons? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #9)
(In reply to Owen Leonard from comment #8)
4 - Search for vendor and note you now a - Can only 'View' empty or closed baskets
Not true, but behavior is correct. Can only "view" if basket is closed. If basket is empty we can "view" and "add to"
Yes, was incorrect language from earlier draft of plans, behaviour is correct
(In reply to Owen Leonard from comment #6)
- Keep the split button, but making "Add to basket" the main action.
Finally this has not been done, any good reasons?
Owen and I talked this over, adding the other options to the dropdown was a bigger change and making 'add to basket' the default would be an issue since some baskets cannot be added to. This can be improved on future bug reports -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79121|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 79470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79470&action=edit Bug 21364: Allow closing basket from vendor view/search To test: 1 - Have a vendor 2 - Add some empty baskets 3 - Add some non-empty baskets 4 - Search for vendor and note you now a - Can only 'View' empty or closed baskets b - Have a dropup menu to 'Add to ' or 'Close' open baskets 5 - Confirm things look correct and buttons work 6 - Confirm that basket name is now a link to view basket Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Works well for me and I agree that, although it could be further enhanced down the line, it works reasonably as is and those further enhancements can be left for another day.. baby steps. Passing QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Making Add to basket a 2-click action might be debatable - maybe sometimes more buttons are better than menus? What happens if you don't have order_manage* permissions? (I can't test this right now because of bug 21423) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 --- Comment #14 from Séverine Queune <severine.queune@bulac.fr> --- I've just realized this new option allows to close standing orders baskets. This option is normally not available, so maybe the behaviour should be modified. Sorry to catch that point so late :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Good catch Severine, bit annoyed at myself for not spotting it myself. Seeing Failed QA pending a follow-up to resolve that oversight. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Looking at the basket summary page code, I think we need to check for other things as well: - existing uncertain prices (uncerteinparices) - standing order (unclosable => @orders ? $basket->{is_standing} : 1,) - order_manage permission -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 --- Comment #17 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 88393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88393&action=edit Bug 21364: (follow-up) Check for standing status and uncertain prices -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 --- Comment #18 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #16)
Looking at the basket summary page code, I think we need to check for other things as well: - existing uncertain prices (uncertainprices) Added
- standing order (unclosable => @orders ? $basket->{is_standing} : 1,) Added - order_manage permission I believe this is done by the call to CanUserManageBasket
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire_gravely@hotmail.com --- Comment #19 from Claire Gravely <claire_gravely@hotmail.com> --- Baskets with uncertain pricing still get a close basket option on the basket summary page. Instead they are marked bold and have dark red text. Everything else looks good! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88393|0 |1 is obsolete| | --- Comment #20 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 88787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88787&action=edit Bug 21364: (follow-up) Check for standing status and uncertain prices Fetch 'uncertainprices' when getting basket info. A side effect is that styling on baskets with uncertain prices is restored by this bug. They will appear in red To test: 1 - Add an order with an uncertainprice to the basket 2 - Return to vendor baskets view 3 - Note the actions now include "Uncertain prices" 4 - Click that, resolve the uncertain prcie 5 - Return to vendor basket view 6 - Note you can now close the basket, but don't 7 - Edit the basket, mark it as standing 8 - Return to vendor basket view 9 - Note you cannot close the basket -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88787|0 |1 is obsolete| | --- Comment #21 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 88788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88788&action=edit Bug 21364: (follow-up) Check for standing status and uncertain prices Fetch 'uncertainprices' when getting basket info. A side effect is that styling on baskets with uncertain prices is restored by this bug. They will appear in red To test: 1 - Add an order with an uncertainprice to the basket 2 - Return to vendor baskets view 3 - Note the actions now include "Uncertain prices" 4 - Click that, resolve the uncertain prcie 5 - Return to vendor basket view 6 - Note you can now close the basket, but don't 7 - Edit the basket, mark it as standing 8 - Return to vendor basket view 9 - Note you cannot close the basket -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79470|0 |1 is obsolete| | Attachment #88788|0 |1 is obsolete| | --- Comment #22 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 88847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88847&action=edit [SIGNED-OFF] Bug 21364: Allow closing basket from vendor view/search To test: 1 - Have a vendor 2 - Add some empty baskets 3 - Add some non-empty baskets 4 - Search for vendor and note you now a - Can only 'View' empty or closed baskets b - Have a dropup menu to 'Add to ' or 'Close' open baskets 5 - Confirm things look correct and buttons work 6 - Confirm that basket name is now a link to view basket Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 --- Comment #23 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 88848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88848&action=edit [SIGNED-OFF] Bug 21364: (follow-up) Check for standing status and uncertain prices Fetch 'uncertainprices' when getting basket info. A side effect is that styling on baskets with uncertain prices is restored by this bug. They will appear in red To test: 1 - Add an order with an uncertainprice to the basket 2 - Return to vendor baskets view 3 - Note the actions now include "Uncertain prices" 4 - Click that, resolve the uncertain prcie 5 - Return to vendor basket view 6 - Note you can now close the basket, but don't 7 - Edit the basket, mark it as standing 8 - Return to vendor basket view 9 - Note you cannot close the basket Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- FAIL C4/Acquisition.pm OK critic FAIL forbidden patterns forbidden pattern: tab char (line 688) OK git manipulation OK pod OK pod coverage OK spelling OK valid FAIL koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt FAIL filters wrong_html_filter at line 105 ( <td><a href="/cgi-bin/koha/acqui/basket.pl?basketno=[% basket.basketno | html %]">[% basket.basketname | html %]<a></td>) wrong_html_filter at line 154 ( <li><a href="/cgi-bin/koha/acqui/uncertainprice.pl?booksellerid=[% basket.booksellerid | html %]&owner=1"><i class="fa fa-usd"></i> Uncertain prices</a></li>) wrong_html_filter at line 156 ( <li><a href="/cgi-bin/koha/acqui/basket.pl?op=close&basketno=[% basket.basketno | html %]&booksellerid=[% basket.booksellerid | html %]"><i class="fa fa-times-circle"></i> Close this basket</a></li>) wrong_html_filter at line 156 ( <li><a href="/cgi-bin/koha/acqui/basket.pl?op=close&basketno=[% basket.basketno | html %]&booksellerid=[% basket.booksellerid | html %]"><i class="fa fa-times-circle"></i> Close this basket</a></li>) Trying to fix in a follow-up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not super happy about the 'add to basket' option being hidden now in a menu in all cases. I would have preferred to keep it visible and easy to access. It kind of contradicts the original purpose of being a fast action now. No longer saving any clicks compared to viewing and adding. I do like the 'uncertain prices' and 'close basket' actions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 88982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88982&action=edit Bug 21364: (follow-up) Check for standing status and uncertain prices Fetch 'uncertainprices' when getting basket info. A side effect is that styling on baskets with uncertain prices is restored by this bug. They will appear in red To test: 1 - Add an order with an uncertainprice to the basket 2 - Return to vendor baskets view 3 - Note the actions now include "Uncertain prices" 4 - Click that, resolve the uncertain prcie 5 - Return to vendor basket view 6 - Note you can now close the basket, but don't 7 - Edit the basket, mark it as standing 8 - Return to vendor basket view 9 - Note you cannot close the basket Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 88983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88983&action=edit Bug 21364: (QA follow-up) Fix QA script complaints (tabs and filters) Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88848|0 |1 is obsolete| | Attachment #88848|1 |0 is patch| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88847|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88848|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88847|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88848|0 |1 is patch| | Attachment #88848|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #28 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Version(s)| |19.05.00 released in| | Resolution|--- |FIXED --- Comment #29 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 --- Comment #30 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Please, we need the "Add to basket" link accessible in one click! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org --- Comment #31 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Owen, could you take a look at the discussion here? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 --- Comment #32 from Owen Leonard <oleonard@myacpl.org> --- The "View" part of the split button is an unnecessary duplication of the linked basket name earlier in the table. I think the actions column should have two possible buttons: "Add to basket" and "Close basket." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds release notes| |'Close basket' to the | |available actions in the | |vendor search results view. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23031 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23031 [Bug 23031] Improve UX of buttons on order search page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 --- Comment #33 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I've moved the discussion about the buttons onto a new bug 23031. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org