[Bug 16603] New: When processing uploaded offline circulation file, "apply directly" option fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16603 Bug ID: 16603 Summary: When processing uploaded offline circulation file, "apply directly" option fails Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/offline_circ/process_koc.pl OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com I have an offline circulation file which was generated by the Windows offline circulation program. If I upload this file and choose "Add to offline circulation queue" it works as expected. If I upload the same file and choose "Apply directly," the process never completes. Firebug shows a seemingly never-ending series of calls to /cgi-bin/koha/tools/background-job-progress.pl?jobID=8c20822320e5fbd7579aa1f61411ba00 but nothing happens. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16603 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16603 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 69454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69454&action=edit Bug 16603: When processing uploaded offline circulation file, "apply directly" option fails This patch is a temporary mitigation of whatever the real problem is. The patch hides the "Apply directly" button so that the option isn't available. To test, apply the patch and generate a .koc file with some transactions. Upload the file via Circulation -> Offline circulation file upload. After the file is uploaded, you should see only a "Add to offline circulation queue" button, which should work correctly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16603 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16603 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16603 Grace <gracesmythh@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16603 Grace <gracesmythh@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69454|0 |1 is obsolete| | --- Comment #2 from Grace <gracesmythh@gmail.com> --- Created attachment 70528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70528&action=edit Bug 16603: When processing uploaded offline circulation file, "apply directly" option fails This patch is a temporary mitigation of whatever the real problem is. The patch hides the "Apply directly" button so that the option isn't available. To test, apply the patch and generate a .koc file with some transactions. Upload the file via Circulation -> Offline circulation file upload. After the file is uploaded, you should see only a "Add to offline circulation queue" button, which should work correctly. Signed-off-by: Grace Smyth <gracesmythh@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16603 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16603 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70528|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 70746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70746&action=edit Bug 16603: When processing uploaded offline circulation file, "apply directly" option fails This patch is a temporary mitigation of whatever the real problem is. The patch hides the "Apply directly" button so that the option isn't available. To test, apply the patch and generate a .koc file with some transactions. Upload the file via Circulation -> Offline circulation file upload. After the file is uploaded, you should see only a "Add to offline circulation queue" button, which should work correctly. Signed-off-by: Grace Smyth <gracesmythh@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16603 --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 70747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70747&action=edit Bug 16603: (QA Follow-up) Add a FIXME Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16603 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | CC| |nick@bywatersolutions.com --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Would be better to fix, but I didn't see the problem in a quick look. This prevents the error for user so PQA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16603 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Nick Clemens from comment #5)
Would be better to fix, but I didn't see the problem in a quick look. This prevents the error for user so PQA
Can someone open another bug report please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16603 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16603 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|When processing uploaded |Hide option to apply |offline circulation file, |directly when processing |"apply directly" option |uploaded offline |fails |circulation file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16603 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20050 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16603 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to Stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16603 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #9 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x for v17.05.09 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org