[Bug 35985] New: ./t/db_dependent/check_sysprefs.t --showsql since Bug 34979
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35985 Bug ID: 35985 Summary: ./t/db_dependent/check_sysprefs.t --showsql since Bug 34979 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org With Bug 34979 looks like we need to adapt ./t/db_dependent/check_sysprefs.t --showsql Example : kohadev-koha@kohadevbox:koha(master)$ ./t/db_dependent/check_sysprefs.t --showsql 1..2 # Subtest: Compare database with sysprefs.sql file ('MARCOrgCode','OSt','','Define MARC Organization Code for MARC21 records - http://www.loc.gov/marc/organizations/orgshome.html','free'), 1..0 # No tests run! not ok 1 - No tests run for subtest "Compare database with sysprefs.sql file" # Failed test 'No tests run for subtest "Compare database with sysprefs.sql file"' # at ./t/db_dependent/check_sysprefs.t line 53. # Subtest: Compare sysprefs.sql with YAML files 1..2 ok 1 - No system preference entries missing from sysprefs.sql ok 2 - No system preference entries missing from YAML files ok 2 - Compare sysprefs.sql with YAML files # Looks like you failed 1 test of 2. Too much verbose. Should we skip subtest "Compare database with sysprefs.sql file" ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35985 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34979 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 [Bug 34979] System preferences missing from sysprefs.sql -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35985 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I wrote the patch, but the different comparisons are confusing :( Happy to have some help with the fix really. I think the --showsql is to help fix an already found problem, so it probably makes sense to skip tests when the script is run with this parameter. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35985 Bug 35985 depends on bug 34979, which changed state. Bug 34979 Summary: System preferences missing from sysprefs.sql https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org