[Bug 22850] New: SharedContent.t wrongly use ->set_userenv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22850 Bug ID: 22850 Summary: SharedContent.t wrongly use ->set_userenv Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Depends on: 17047, 21817 Target Milestone: --- t/db_dependent/Koha/SharedContent.t:C4::Context->set_userenv(0,0,0, ->set_userenv should no longer be used in tests. See bug 21817. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 [Bug 17047] Mana Knowledge Base : share data https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21817 [Bug 21817] Mock userenv should be a t::lib::Mocks method -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22850 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22850 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 89353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89353&action=edit Bug 22850: Do no longer use set_userenv in tests (SharedContent.t) Since bug 21817 we should use the mock_userenv subroutine instead. Test plan: The tests must pass after this patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22850 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22850 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89353|0 |1 is obsolete| | --- Comment #2 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 89578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89578&action=edit Bug 22850: Do no longer use set_userenv in tests (SharedContent.t) Since bug 21817 we should use the mock_userenv subroutine instead. Test plan: The tests must pass after this patch Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22850 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22850 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89578|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 89613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89613&action=edit Bug 22850: Do no longer use set_userenv in tests (SharedContent.t) Since bug 21817 we should use the mock_userenv subroutine instead. Test plan: The tests must pass after this patch Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22850 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22850 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Test not in 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22850 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org