[Bug 10774] New: Allow individual holds to be suspended and resumed from the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774 Bug ID: 10774 Summary: Allow individual holds to be suspended and resumed from the OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Right now, holds can only be suspended and resumed from the OPAC as a whole. It would be nice to be able to suspend and resume holds on a hold by hold basis from the OPAC. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 20534 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20534&action=edit Bug 10774 - Allow individual holds to be suspended and resumed from the OPAC Right now, holds can only be suspended and resumed from the OPAC as a whole. It would be nice to be able to suspend and resume holds on a hold by hold basis from the OPAC. Test Plan: 1) Apply this patch 2) Log in to the OPAC 3) Place a number of holds 4) Browse to "my summary" and select the holds tab 5) From here, test the following actions a) Suspend a hold indefinitely ( no resume date ) b) Suspend a hold with a date to automatically resume c) Manually resume a suspended hold -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20534|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 20535 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20535&action=edit Bug 10774 - Allow individual holds to be suspended and resumed from the OPAC Right now, holds can only be suspended and resumed from the OPAC as a whole. It would be nice to be able to suspend and resume holds on a hold by hold basis from the OPAC. Test Plan: 1) Apply this patch 2) Log in to the OPAC 3) Place a number of holds 4) Browse to "my summary" and select the holds tab 5) From here, test the following actions a) Suspend a hold indefinitely ( no resume date ) b) Suspend a hold with a date to automatically resume c) Manually resume a suspended hold 6) Disable AutoResumeSuspendedHolds, ensure the suspend until date field is no longer visible. 7) Disable SuspendHoldsOpac, ensure all suspension related fields are no longer visible. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- This looks good and is a nice improvement. I do see one issue: I'm pretty sure you shouldn't be able to suspend a hold on an item which is in transit. You can't cancel a hold while it is in transit, and the staff client blocks you from suspending. If that sounds correct and you'll submit a revision, there is also an orphan </p> which needs to be removed, right after the "clear date" link. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774 --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Good catches! I'll get a followup written asap. (In reply to Owen Leonard from comment #3)
This looks good and is a nice improvement. I do see one issue: I'm pretty sure you shouldn't be able to suspend a hold on an item which is in transit. You can't cancel a hold while it is in transit, and the staff client blocks you from suspending.
If that sounds correct and you'll submit a revision, there is also an orphan </p> which needs to be removed, right after the "clear date" link.
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20535|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 20710 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20710&action=edit Bug 10774 - Allow individual holds to be suspended and resumed from the OPAC Right now, holds can only be suspended and resumed from the OPAC as a whole. It would be nice to be able to suspend and resume holds on a hold by hold basis from the OPAC. Test Plan: 1) Apply this patch 2) Log in to the OPAC 3) Place a number of holds 4) Browse to "my summary" and select the holds tab 5) From here, test the following actions a) Suspend a hold indefinitely ( no resume date ) b) Suspend a hold with a date to automatically resume c) Manually resume a suspended hold 6) Disable AutoResumeSuspendedHolds, ensure the suspend until date field is no longer visible. 7) Disable SuspendHoldsOpac, ensure all suspension related fields are no longer visible. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774 Chris Rohde <crohde@roseville.ca.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |crohde@roseville.ca.us -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot@bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #6 from I'm just a bot <gitbot@bugs.koha-community.org> --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- When did the bot|2013-09-29 00:00:00 |2013-10-25 last check this| | --- Comment #7 from I'm just a bot <gitbot@bugs.koha-community.org> --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774 Chris Rohde <crohde@roseville.ca.us> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #8 from Chris Rohde <crohde@roseville.ca.us> --- Patch tested per test plan, and functions as expected. I Chris Rohde, signoff on this patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774 Joel Sasse <jsasse@plumcreeklibrary.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jsasse@plumcreeklibrary.net -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m QA Contact|testopia@bugs.koha-communit |jonathan.druart@biblibre.co |y.org |m --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- Looks good, the patch works as expected. No regression found. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20710|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 23211 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23211&action=edit Bug 10774 - Allow individual holds to be suspended and resumed from the OPAC Right now, holds can only be suspended and resumed from the OPAC as a whole. It would be nice to be able to suspend and resume holds on a hold by hold basis from the OPAC. Test Plan: 1) Apply this patch 2) Log in to the OPAC 3) Place a number of holds 4) Browse to "my summary" and select the holds tab 5) From here, test the following actions a) Suspend a hold indefinitely ( no resume date ) b) Suspend a hold with a date to automatically resume c) Manually resume a suspended hold 6) Disable AutoResumeSuspendedHolds, ensure the suspend until date field is no longer visible. 7) Disable SuspendHoldsOpac, ensure all suspension related fields are no longer visible. Signed-off-by: Chris Rohde <crohde@roseville.ca.us> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774 --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 23212 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23212&action=edit [ALT] Bug 11244: notices ignoring the dateformat preference Overdue notices are using the MySQL date format and not the dateformat in the system preferences. Test Plan: 1) Enable checkout notices for a patron, make sure the date due is in the notice. 2) Check out an item to that patron, note the date is in the mysql datetime format 3) Apply this patch 4) Check out another item to the patron, not the date is now in the preferred date format. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23212|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774 --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- Wrong bug number... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |ASSIGNED CC| |gmcharlt@gmail.com --- Comment #13 from Galen Charlton <gmcharlt@gmail.com> --- Pushing back to submitter for more work -- this patch series doesn't yet cover the bootstrap theme. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23211|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24016 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24016&action=edit Bug 10774 [QA Followup] - Add support for bootstrap opac theme -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774 --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24017 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24017&action=edit Bug 10774 - Allow individual holds to be suspended and resumed from the OPAC Right now, holds can only be suspended and resumed from the OPAC as a whole. It would be nice to be able to suspend and resume holds on a hold by hold basis from the OPAC. Test Plan: 1) Apply this patch 2) Log in to the OPAC 3) Place a number of holds 4) Browse to "my summary" and select the holds tab 5) From here, test the following actions a) Suspend a hold indefinitely ( no resume date ) b) Suspend a hold with a date to automatically resume c) Manually resume a suspended hold 6) Disable AutoResumeSuspendedHolds, ensure the suspend until date field is no longer visible. 7) Disable SuspendHoldsOpac, ensure all suspension related fields are no longer visible. Signed-off-by: Chris Rohde <crohde@roseville.ca.us> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24016|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24018 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24018&action=edit Bug 10774 [QA Followup] - Add support for bootstrap opac theme -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #17 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org