[Bug 40779] New: returned checkout generates refund if fee was cancelled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40779 Bug ID: 40779 Summary: returned checkout generates refund if fee was cancelled Change sponsored?: --- Product: Koha Version: 25.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: bdaeuber@cityoffargo.com QA Contact: testopia@bugs.koha-community.org If you cancel a fee for a lost item, that item will create a credit when it is returned. To recreate: 1. Ensure WhenLostChargeReplacementFee is set to "Charge" and that "Refund lost item replacement fee" in circ rules is set to "refund lost item charge". 2. Check out an item that has a replacement cost. 3. Set the item to lost. 4. Go to the Accounting tab and view Transactions. 5. Cancel the charge. 6. Return the item. Note that the patron now has a credit. This does not appear to be the case when a fine is written off. I also question whether canceling a fee should mark and item as Paid as I've always viewed "Cancel charge" as an "oops" button when someone accidentally makes something lost, so it probably shouldn't set the item to paid. But that might be outside of the scope of this ticket. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40779 Sara Brown <sbrown@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41741 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40779 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40779 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|25.05 |Main -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40779 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29923 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40779 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|returned checkout generates |Found or returned lost item |refund if fee was cancelled |generates refund of | |replacement cost fee even | |if fee was cancelled -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40779 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20262 --- Comment #1 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Testing on main, Koha does not create a credit for a cancelled lost item fee when the lost item is returned if lost item fee refund on return policy is set to "Refund lost item charge (only if unpaid)." -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40779 --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 195129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195129&action=edit Bug 40779: Do not generate credit for cancelled fee To test 1 - have syspref WhenLostChargeReplacementFee enabled 2 - have lost item fee refund on return policy set to "Refund lost item charge" 3 - have 2 items with replacement costs 4 - check your 2 items out to a patron 5 - mark both items lost 6 - confirm patron now has 2 lost item fees on account 7 - write off one of the fees 8 - cancel the other fee 9 - return the item with the written off fee 10 - confirm no credit is generated on the patron account 11 - return the item with the cancelled fee 12 - confirm a credit is generated on the patron account 13 - apply patch, restart services 14 - repeat steps 4 - 10 with a different patron, confirm no change 15 - return the item with the cancelled fee 16 - confirm no credit is generated on the patron account -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40779 --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- The patch I've provided handles the desired behavior here. We were already preventing credits for writeoffs, so it makes sense to also block credits for cancellations. I've not set this to NSO because it probably wants some unit tests. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40779 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40779 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195129|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40779 --- Comment #4 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 196186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196186&action=edit Bug 40779: Do not refund cancelled lost fee when item is found To test 1 - have syspref WhenLostChargeReplacementFee enabled 2 - have lost item fee refund on return policy set to "Refund lost item charge" 3 - have 2 items with replacement costs 4 - check your 2 items out to a patron 5 - mark both items lost 6 - confirm patron now has 2 lost item fees on account 7 - write off one of the fees 8 - cancel the other fee 9 - return the item with the written off fee 10 - confirm no credit is generated on the patron account 11 - return the item with the cancelled fee 12 - confirm a credit is generated on the patron account 13 - apply patch, restart services 14 - repeat steps 4 - 10 with a different patron, confirm no change 15 - return the item with the cancelled fee 16 - confirm no credit is generated on the patron account -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40779 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |andrew@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40779 Benjamin Daeuber <bdaeuber@cityoffargo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40779 Benjamin Daeuber <bdaeuber@cityoffargo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196186|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40779 --- Comment #5 from Benjamin Daeuber <bdaeuber@cityoffargo.com> --- Created attachment 196348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196348&action=edit Bug 40779: Do not refund cancelled lost fee when item is found To test 1 - have syspref WhenLostChargeReplacementFee enabled 2 - have lost item fee refund on return policy set to "Refund lost item charge" 3 - have 2 items with replacement costs 4 - check your 2 items out to a patron 5 - mark both items lost 6 - confirm patron now has 2 lost item fees on account 7 - write off one of the fees 8 - cancel the other fee 9 - return the item with the written off fee 10 - confirm no credit is generated on the patron account 11 - return the item with the cancelled fee 12 - confirm a credit is generated on the patron account 13 - apply patch, restart services 14 - repeat steps 4 - 10 with a different patron, confirm no change 15 - return the item with the cancelled fee 16 - confirm no credit is generated on the patron account Signed-off-by: Benjamin Daeuber <bdaeuber@fargolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40779 --- Comment #6 from Benjamin Daeuber <bdaeuber@cityoffargo.com> --- This looks OK to me. Both writeoff and cancellations are no longer refunding to the patron if the item is returned. I did try to cancel the charge, then declare the item lost again, but the patron was not recharged. I have a distant memory of that being an already known, unrelated issue, however. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40779 --- Comment #7 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to Benjamin Daeuber from comment #6)
I did try to cancel the charge, then declare the item lost again, but the patron was not recharged. I have a distant memory of that being an already known, unrelated issue, however.
Can you please detail your actions here? I was not able to replicate this error with or without my patch. What I did: - have item with replacement price - check it out - mark it lost - confirm lost charge is generated - cancel lost charge - check item out again (thereby marking it found -- making a credit without my patch, not making a credit if patch is applied) - mark it lost again - confirm a second lost charge is generated -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40779 --- Comment #8 from Benjamin Daeuber <bdaeuber@cityoffargo.com> --- (In reply to Andrew Fuerste-Henry from comment #7)
(In reply to Benjamin Daeuber from comment #6)
I did try to cancel the charge, then declare the item lost again, but the patron was not recharged. I have a distant memory of that being an already known, unrelated issue, however.
Can you please detail your actions here? I was not able to replicate this error with or without my patch. What I did: - have item with replacement price - check it out - mark it lost - confirm lost charge is generated - cancel lost charge - check item out again (thereby marking it found -- making a credit without my patch, not making a credit if patch is applied) - mark it lost again - confirm a second lost charge is generated
Ensure MarkLostItemsAsReturned is not set to "Receiving Payment for Item" and the item goes lost after the fee is cancelled, the fee does not return. It appears to be the case without the patch and outside the scope of this ticket. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org