[Bug 29086] New: Reuse article request filtering methods in Biblio template plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29086 Bug ID: 29086 Summary: Reuse article request filtering methods in Biblio template plugin Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org Introduced by bug 29082, and covered by tests, we should use those higher level methods instead of crafting queries in-place. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29086 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28684 Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29086 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 125175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125175&action=edit Bug 29086: Simplify querying active article requests This patch makes a trivial replacement of a query for a higher level method that does the same query. To test: 1. Enable the ArticleRequests feature 2. Place some article requests on known biblios 3. Have some article requests be active on others finished (either completed or cancelled) 4. Go to the detail page for those records => SUCCESS: The active article requests count is correct! 5. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29086 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 125176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125176&action=edit Bug 29086: (follow-up) Remove unrequired Koha::ArticleRequest::Status uses I noticed a couple places in which this library was included but not used. To test: 1. Apply this patch 2. Run: $ git grep 'Koha::ArticleRequest::Status' => SUCCESS: There aren't any calls to their defined constants in Biblio.pm or Patrons.pm 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29086 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Depends on| |29084 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29084 [Bug 29084] Update article requests-related Koha::Biblio methods to use relationships -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29086 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com, | |m.de.rooy@rijksmuseum.nl, | |martin.renvoize@ptfs-europe | |.com, | |nick@bywatersolutions.com, | |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29086 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Everything worked fine in the staff interface. However, in the OPAC no items are shown for the patron (Your account > Your summary > Article requests tab (has no number in (), and not items listed. This may be one of the dependcies causing this... Testing notes: - remember to run updatedatabase (for other dependencies) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29086 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to David Nind from comment #3)
Everything worked fine in the staff interface.
However, in the OPAC no items are shown for the patron (Your account > Your summary > Article requests tab (has no number in (), and not items listed. This may be one of the dependcies causing this...
Testing notes: - remember to run updatedatabase (for other dependencies)
Thanks for testing! Will check it ASAP. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29086 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Tomás Cohen Arazi from comment #4)
(In reply to David Nind from comment #3)
Everything worked fine in the staff interface.
However, in the OPAC no items are shown for the patron (Your account > Your summary > Article requests tab (has no number in (), and not items listed. This may be one of the dependcies causing this...
Testing notes: - remember to run updatedatabase (for other dependencies)
Thanks for testing! Will check it ASAP.
Solved, on bug 29083. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29086 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125175|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 125246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125246&action=edit Bug 29086: Simplify querying active article requests This patch makes a trivial replacement of a query for a higher level method that does the same query. To test: 1. Enable the ArticleRequests feature 2. Place some article requests on known biblios 3. Have some article requests be active on others finished (either completed or cancelled) 4. Go to the detail page for those records => SUCCESS: The active article requests count is correct! 5. Sign off :-D Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29086 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125176|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 125247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125247&action=edit Bug 29086: (follow-up) Remove unrequired Koha::ArticleRequest::Status uses I noticed a couple places in which this library was included but not used. To test: 1. Apply this patch 2. Run: $ git grep 'Koha::ArticleRequest::Status' => SUCCESS: There aren't any calls to their defined constants in Biblio.pm or Patrons.pm 3. Sign off :-D Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29086 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Works as expected, signing off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29086 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27949 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949 [Bug 27949] Batch printing of article request slips -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29086 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29086 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125246|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 125347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125347&action=edit Bug 29086: Simplify querying active article requests This patch makes a trivial replacement of a query for a higher level method that does the same query. To test: 1. Enable the ArticleRequests feature 2. Place some article requests on known biblios 3. Have some article requests be active on others finished (either completed or cancelled) 4. Go to the detail page for those records => SUCCESS: The active article requests count is correct! 5. Sign off :-D Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29086 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125247|0 |1 is obsolete| | --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 125348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125348&action=edit Bug 29086: (follow-up) Remove unrequired Koha::ArticleRequest::Status uses I noticed a couple places in which this library was included but not used. To test: 1. Apply this patch 2. Run: $ git grep 'Koha::ArticleRequest::Status' => SUCCESS: There aren't any calls to their defined constants in Biblio.pm or Patrons.pm 3. Sign off :-D Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29086 --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Note that the dependency needs a fix. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29086 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29086 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29086 --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29086 Bug 29086 depends on bug 29084, which changed state. Bug 29084 Summary: Update article requests-related Koha::Biblio methods to use relationships https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29084 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29086 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org