[Bug 27301] New: Harmonize methods for providing biblionumbers to opac-reserve.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27301 Bug ID: 27301 Summary: Harmonize methods for providing biblionumbers to opac-reserve.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com At the moment, you can send biblionumbers to opac-reserve.pl either as multiple "biblionumbers" arguments or as a single compacted string like "1/2/3". It seems silly to me to have all this code for handling these different scenarios. We should just harmonize the callers. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27301 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- These appear to be the templates that reference opac-reserve.pl using the concatenated "biblionumbers" syntax: 1. koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt 2. koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt 3. koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt 4. koha-tmpl/opac-tmpl/bootstrap/js/basket.js Test plan: _Search Results_ (opac-results.tt) 1. Go to http://localhost:8080/cgi-bin/koha/opac-search.pl?idx=&q=test&weight_search=1 2. Checkbox # 1 and # 2 3. Click "Place hold" _Cart_ (basket.js) 1. Go to http://localhost:8080/cgi-bin/koha/opac-search.pl?idx=&q=test&weight_search=1 2. Checkbox # 1 and # 2 3. Add to cart 4. Click on "Cart" 5. Click "Select all" 6. Click "Place hold" _Detail page_ TBC -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27301 --- Comment #2 from David Cook <dcook@prosentient.com.au> --- Using jQuery, it's fairly trivial to build a querystring of "biblionumber=1&biblionumber=2&biblionumber=3". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27301 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27301 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- Created attachment 114661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114661&action=edit Bug 27301: Pass biblionumbers to opac-reserve.pl in one style only This patch forces biblionumbers to be passed to opac-reserve.pl as individual "biblionumber" parameters instead of sending a concatenated string as a "biblionumbers" parameter. Test plan: _Search Results_ 1. Go to http://localhost:8080/cgi-bin/koha/opac-search.pl?idx=&q=test&weight_search=1 2. Checkbox # 1 and # 2 3. Click "Place hold" 4. Click "Confirm hold" 5. Note that holds are made 6. Cancel holds to prepare for next test... _Cart_ 1. Go to http://localhost:8080/cgi-bin/koha/opac-search.pl?idx=&q=test&weight_search=1 2. Checkbox # 1 and # 2 3. Add to cart 4. Click on "Cart" 5. Click "Select all" 6. Click "Place hold" 7. Click "Confirm hold" 8. Note that holds are made 9. Cancel holds to prepare for next test... _List_ 1. Go to http://localhost:8080/cgi-bin/koha/opac-search.pl?idx=&q=test&weight_search=1 2. Checkbox # 1 and # 2 3. Add to new list 4. Click on list 5. Click "Select all" 6. Click "Place hold" 7. Click "Confirm hold" 8. Note that holds are made 9. Cancel holds to prepare for next test... _Detail page_ 1. Go to http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=29 2. Click "Place hold" 3. Click "Confirm hold" 4. Note that holds are made 5. Cancel hold (because you may as well at this point) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27301 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15565 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27301 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |dcook@prosentient.com.au |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27301 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27301 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23457 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27301 Mazen Khallaf <mazen.i.khallaf@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |mazen.i.khallaf@gmail.com --- Comment #4 from Mazen Khallaf <mazen.i.khallaf@gmail.com> --- Received error "Sorry, you cannot place holds. ERROR: No record id specified." as I tried to place a hold through the cart (Step 6 of _Cart_) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27301 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|dcook@prosentient.com.au |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27301 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It looks like we already made this change in the staff interface: http://localhost:8081/cgi-bin/koha/reserve/request.pl?findborrower=&club=&biblionumber=262&biblionumber=5&biblionumber=13&biblionumber=146&biblionumber=191&biblionumber=11&biblionumber=126&biblionumber=139&biblionumber=165&biblionumber=255&biblionumber=115 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27301 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28782 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27301 --- Comment #6 from David Cook <dcook@prosentient.com.au> --- Looks like it's still an issue in the OPAC -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org