[Bug 35194] New: Javascript error when a repeatable field is repeated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35194 Bug ID: 35194 Summary: Javascript error when a repeatable field is repeated Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl, oleonard@myacpl.org The error appears in both the cataloguing and authority editor. Go to a repeatable field, like 500. Repeat it with the console open: Uncaught TypeError: $(...).sortable is not a function -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35194 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- sortable() is a jQueryUI function which was removed from Koha. It looks like that line just needs to be removed: - $("ul.sortable_subfield", clone).sortable(); Without it you can still sort and clone repeatable fields. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35194 --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- git grep "sortable(" koha-tmpl/intranet-tmpl/prog/en/modules/admin/didyoumean.tt: $( ".pluginlist" ).sortable(); koha-tmpl/intranet-tmpl/prog/js/cataloging.js: $("ul.sortable_subfield", clone).sortable(); koha-tmpl/intranet-tmpl/prog/js/pages/stockrotation.js: // $('#sortable_stages').sortable('cancel'); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35194 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Javascript error when a |Javascript error: Uncaught |repeatable field is |TypeError: $(...).sortable |repeated |is not a function -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35194 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35194 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- This also breaks didyoumean configuration. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35194 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35194 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35194 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35194 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 158709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158709&action=edit Bug 35194: Remove obsoleted sortable function Removes two occurrences and a commented one. Test plan: [1] Go to cataloguing editor. Open dev console. Clone 500. [2] Go to Admin/Did you mean. Try to toggle options. With this patch it works. Without this patch, JS errors. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35194 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35194 --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #3)
This also breaks didyoumean configuration.
This asks for Major imo. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35194 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- 22.11 grep gives me more results: git grep "sortable(" koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt: $("#subfieldtabs > ul").sortable({ koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt: $( "ul.sortable_field", "#authoritytabs" ).sortable(); koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt: $( "ul.sortable_subfield", "#authoritytabs" ).sortable(); koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt: $( "ul.sortable_field", "#addbibliotabs" ).sortable({ koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt: $( "ul.sortable_subfield", "#addbibliotabs" ).sortable({ koha-tmpl/intranet-tmpl/prog/js/marc_subfields_structure.js: $("#subfieldtabs > ul").sortable({ koha-tmpl/intranet-tmpl/prog/js/pages/preferences.js: $(".sortable").sortable(); koha-tmpl/intranet-tmpl/prog/js/pages/stockrotation.js: $('#sortable_stages').sortable({ koha-tmpl/intranet-tmpl/prog/js/pages/stockrotation.js: $('#sortable_stages').sortable('disable'); koha-tmpl/intranet-tmpl/prog/js/pages/stockrotation.js: $('#sortable_stages').sortable('cancel'); koha-tmpl/intranet-tmpl/prog/js/pages/stockrotation.js: $('#sortable_stages').sortable('enable'); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35194 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #6)
22.11 grep gives me more results:
git grep "sortable(" koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt: $("#subfieldtabs > ul").sortable({ koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt: $( "ul.sortable_field", "#authoritytabs" ).sortable(); koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt: $( "ul.sortable_subfield", "#authoritytabs" ).sortable(); koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt: $( "ul.sortable_field", "#addbibliotabs" ).sortable({ koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt: $( "ul.sortable_subfield", "#addbibliotabs" ).sortable({ koha-tmpl/intranet-tmpl/prog/js/marc_subfields_structure.js: $("#subfieldtabs > ul").sortable({ koha-tmpl/intranet-tmpl/prog/js/pages/preferences.js: $(".sortable").sortable(); koha-tmpl/intranet-tmpl/prog/js/pages/stockrotation.js: $('#sortable_stages').sortable({ koha-tmpl/intranet-tmpl/prog/js/pages/stockrotation.js: $('#sortable_stages').sortable('disable'); koha-tmpl/intranet-tmpl/prog/js/pages/stockrotation.js: $('#sortable_stages').sortable('cancel'); koha-tmpl/intranet-tmpl/prog/js/pages/stockrotation.js: $('#sortable_stages').sortable('enable');
No worries. 22.11 still has the library. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35194 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Cataloging |Architecture, internals, | |and plumbing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35194 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35194 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158709|0 |1 is obsolete| | --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 158714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158714&action=edit Bug 35194: Remove obsoleted sortable function Removes two occurrences and a commented one. Test plan: [1] Go to cataloguing editor. Open dev console. Clone 500. [2] Go to Admin/Did you mean. Try to toggle options. With this patch it works. Without this patch, JS errors. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35194 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov CC| |emily.lamancusa@montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35194 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158714|0 |1 is obsolete| | --- Comment #9 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 158746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158746&action=edit Bug 35194: Remove obsoleted sortable function Removes two occurrences and a commented one. Test plan: [1] Go to cataloguing editor. Open dev console. Clone 500. [2] Go to Admin/Did you mean. Try to toggle options. With this patch it works. Without this patch, JS errors. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35194 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35194 --- Comment #10 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Looks great! It seems like the new Sortable library never got added to the didyoumean page, though. I'll open a related bug for it. If it makes more sense to add a follow-up here instead, feel free to mark the new bug as a dupe and I'll QA the follow-up here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35194 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34114 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34114 [Bug 34114] Replace the use of jQueryUI sortable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35194 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35304 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35194 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35304 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35304 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35304 [Bug 35304] Add new Sortable library to didyoumean configuration -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35194 --- Comment #11 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- (In reply to Emily Lamancusa from comment #10)
It seems like the new Sortable library never got added to the didyoumean page, though. I'll open a related bug for it. If it makes more sense to add a follow-up here instead, feel free to mark the new bug as a dupe and I'll QA the follow-up here.
lol it was an easy fix. Patch uploaded on bug 35304 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35194 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_23_11_candidate CC| |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35194 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35194 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35194 --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Emily Lamancusa from comment #9)
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Thanks Emily -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35194 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |fridolin.somers@biblibre.co | |m --- Comment #14 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 34114 not in 23.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org