[Bug 19673] New: Patron batch modification tool cannot use authorised value "0"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19673 Bug ID: 19673 Summary: Patron batch modification tool cannot use authorised value "0" Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: emma.perks@heartofengland.nhs.uk QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com If a patron attribute has the authorized value 0, using the Batch patron modification tool does not save the value. Test case: Authorized values category YES_NO; No=0, Yes=1 Set patron attribute type to use the YES_NO category Tools Batch patron modification Select patrons Set attribute to 0 Save The attribute has not saved Many thanks. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19673 Emma Perks <emma.perks@heartofengland.nhs.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emma.perks@heartofengland.n | |hs.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19673 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19673 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 69984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69984&action=edit Bug 19673: Allow to set patron attributes to 0 with batch patron modification This patch will have to be tested deeply to make sure it will not introduce regression! The idea is to display an empty option in the patron attributes select and ignore it. That way we can deal with false values 0 and "" which were skipped before. Test plan: Add several patron attributes Use the batch patron modification tool to add/update/remove them Play with empty "" and 0 values, as well as other values Modify several attributes in a row -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19673 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|16.05 |master Severity|minor |normal Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19673 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69984|0 |1 is obsolete| | --- Comment #2 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 73223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73223&action=edit Bug 19673: Allow to set patron attributes to 0 with batch patron modification This patch will have to be tested deeply to make sure it will not introduce regression! The idea is to display an empty option in the patron attributes select and ignore it. That way we can deal with false values 0 and "" which were skipped before. Test plan: Add several patron attributes Use the batch patron modification tool to add/update/remove them Play with empty "" and 0 values, as well as other values Modify several attributes in a row Signed-off-by: Charles Farmer <charles.farmer@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19673 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |charles.farmer@inlibro.com Status|Needs Signoff |Signed Off --- Comment #3 from Charles Farmer <charles.farmer@inlibro.com> --- Could reproduce the original issue with newly created attributes. The values 0 and empty string ('') were not considered during update. Applied patch, and now I could update with both 0 and an empty field. Patch set to 'Signed off' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19673 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19673 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73223|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 73367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73367&action=edit Bug 19673: Allow to set patron attributes to 0 with batch patron modification This patch will have to be tested deeply to make sure it will not introduce regression! The idea is to display an empty option in the patron attributes select and ignore it. That way we can deal with false values 0 and "" which were skipped before. Test plan: Add several patron attributes Use the batch patron modification tool to add/update/remove them Play with empty "" and 0 values, as well as other values Modify several attributes in a row Signed-off-by: Charles Farmer <charles.farmer@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19673 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19673 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Pushed to Master |Pushed to Stable --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Pushed to stable for 17.11.06 Awesome work all! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19673 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x for v17.05.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19673 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19673 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #8 from David Cook <dcook@prosentient.com.au> --- I think that I may have found a regression caused by this patch: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23217 Basically I'm getting database errors when I try to do Batch Patron Modification and there is no borrower attribute provided, although there are borrower attribute codes on the system so the select menu appears. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19673 --- Comment #9 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #8)
I think that I may have found a regression caused by this patch:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23217
Basically I'm getting database errors when I try to do Batch Patron Modification and there is no borrower attribute provided, although there are borrower attribute codes on the system so the select menu appears.
The key is using DEBUG=1 in your Apache configuration to turn on RaiseError in DBI. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19673 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23217 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19673 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23217 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23217 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23217 [Bug 23217] Batch patron modification shows database errors when no Attribute provided -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19673 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23218 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23218 [Bug 23218] Batch patron modification empty attribute causes improper handling of values -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19673 --- Comment #10 from David Cook <dcook@prosentient.com.au> --- Also found this bug: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23218 Depending on user behaviour, it may or may not be an edge case -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org