[Bug 24391] New: Remove event attributes from patron clubs templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24391 Bug ID: 24391 Summary: Remove event attributes from patron clubs templates Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/clubs/templates-add-modify.pl OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 18530 The template for adding/editing patron clubs has several instances of "onclick," in violation of coding guidelines. https://wiki.koha-community.org/wiki/Coding_Guidelines#JS9:_Avoid_the_use_of... They should be removed in favor of defining events in JavaScript instead of markup. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18530 [Bug 18530] Remove event attributes from patron clubs templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24391 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24391 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 97128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97128&action=edit Bug 24391: Remove event attributes from patron clubs templates This patch removes "onclick" attributes from the template for adding and editing patron club templates. To test, apply the patch and go to Tools -> Patron clubs -> New club template. Test the process of adding and deleting both club and enrollment fields. Test during the template add process and when editing an existing template. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24391 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove event attributes |Remove event attributes |from patron clubs templates |from patron clubs edit | |template -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24391 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97128|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 97140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97140&action=edit Bug 24391: Remove event attributes from patron clubs edit template This patch removes "onclick" attributes from the template for adding and editing patron club templates. To test, apply the patch and go to Tools -> Patron clubs -> New club template. Test the process of adding and deleting both club and enrollment fields. Test during the template add process and when editing an existing template. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24391 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24391 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97140|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 97270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97270&action=edit Bug 24391: Remove event attributes from patron clubs edit template This patch removes "onclick" attributes from the template for adding and editing patron club templates. To test, apply the patch and go to Tools -> Patron clubs -> New club template. Test the process of adding and deleting both club and enrollment fields. Test during the template add process and when editing an existing template. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24391 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Owen, is the dependency correct here? It looks like there were patches on bug 18530 once, but there aren't now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24391 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24391 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97270|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 97373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97373&action=edit Bug 24391: Remove event attributes from patron clubs edit template This patch removes "onclick" attributes from the template for adding and editing patron club templates. To test, apply the patch and go to Tools -> Patron clubs -> New club template. Test the process of adding and deleting both club and enrollment fields. Test during the template add process and when editing an existing template. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24391 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18530 Depends on|18530 | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Katrin Fischer from comment #4)
Hi Owen, is the dependency correct here?
Sorry, it should block, not depend on, 18530 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18530 [Bug 18530] Remove event attributes from patron clubs templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24391 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24391 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24391 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | CC| |joy@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #8 from Joy Nelson <joy@bywatersolutions.com> --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24391 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 CC| |lucas@bywatersolutions.com --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24391 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley@catalyst.net.n | |z --- Comment #10 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org