[Bug 15411] New: "Non fiction" is incorrect
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15411 Bug ID: 15411 Summary: "Non fiction" is incorrect Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt@gmail.com Reporter: aleishaamohia@hotmail.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl The term "non fiction" is incorrect. Writing a patch which will change "non fiction" to "non-fiction" everywhere in OPAC and Staff Client. I would rather change to "nonfiction" rather than "non-fiction" because eliminating the hyphen takes no meaning away from the term, saves space and uses less characters, and solidifies the term. However Koha uses "non-musical recording" etc, so for consistency's sake, I'll use "non-fiction". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15411 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15411 --- Comment #1 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 45920 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45920&action=edit Bug 15411: Changing 'Non fiction' to 'Non-fiction' To test: 1) Apply patch 2) Run updatedatabase.pl 3) Go to advanced search in Staff Client (ie /cgi-bin/koha/catalogue/search.pl) 4) Confirm that it says 'Non-fiction' in the 'Any content' drop-down menu under 'Subtype limits' 5) Go to item search (ie /cgi-bin/koha/catalogue/itemsearch.pl) 6) Confirm that it says 'Non-fiction' under 'Collection code' 7) Go to advanced search in OPAC (ie /cgi-bin/koha/opac-search.pl) and click 'More options' 8) Confirm that it says 'Non-fiction' in the 'Content' drop-down menu 9) Go to the details page for a non-fiction book in the OPAC (ie /cgi-bin/koha/opac-detail.pl?biblionumber=2) and click 'Holdings' tab 10) Confirm that it says 'Non-fiction' under 'Collection' heading -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15411 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial Patch complexity|--- |String patch Assignee|gmcharlt@gmail.com |aleishaamohia@hotmail.com CC| |mtompset@hotmail.com --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- This is a simple patch, not an enhancement. Changed report settings accordingly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15411 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- $ git grep -i "non fiction" | grep -v "\/po\/" Please correct Italian, Polish, and Staff client catalogue help files. koha qa test tools passed. Currently does all that is described. However, because of the three files which still need updating, marking Failed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15411 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15411 --- Comment #4 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 46289 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46289&action=edit Bug 15411: More changes Changes to Italian and Polish sql files and catalogue help file. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15411 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45920|0 |1 is obsolete| | --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 46295 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46295&action=edit Bug 15411: Changing 'Non fiction' to 'Non-fiction' To test: 1) Apply patch 2) Run updatedatabase.pl 3) Go to advanced search in Staff Client (ie /cgi-bin/koha/catalogue/search.pl) 4) Confirm that it says 'Non-fiction' in the 'Any content' drop-down menu under 'Subtype limits' 5) Go to item search (ie /cgi-bin/koha/catalogue/itemsearch.pl) 6) Confirm that it says 'Non-fiction' under 'Collection code' 7) Go to advanced search in OPAC (ie /cgi-bin/koha/opac-search.pl) and click 'More options' 8) Confirm that it says 'Non-fiction' in the 'Content' drop-down menu 9) Go to the details page for a non-fiction book in the OPAC (ie /cgi-bin/koha/opac-detail.pl?biblionumber=2) and click 'Holdings' tab 10) Confirm that it says 'Non-fiction' under 'Collection' heading Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15411 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46295|0 |1 is obsolete| | --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 46296 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46296&action=edit Bug 15411: Changing 'Non fiction' to 'Non-fiction' To test: 1) Apply patch 2) Run updatedatabase.pl 3) Go to advanced search in Staff Client (ie /cgi-bin/koha/catalogue/search.pl) 4) Confirm that it says 'Non-fiction' in the 'Any content' drop-down menu under 'Subtype limits' 5) Go to item search (ie /cgi-bin/koha/catalogue/itemsearch.pl) 6) Confirm that it says 'Non-fiction' under 'Collection code' 7) Go to advanced search in OPAC (ie /cgi-bin/koha/opac-search.pl) and click 'More options' 8) Confirm that it says 'Non-fiction' in the 'Content' drop-down menu 9) Go to the details page for a non-fiction book in the OPAC (ie /cgi-bin/koha/opac-detail.pl?biblionumber=2) and click 'Holdings' tab 10) Confirm that it says 'Non-fiction' under 'Collection' heading Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
delete from auth_vals; source {appropriate file};
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15411 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46289|0 |1 is obsolete| | --- Comment #7 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 46297 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46297&action=edit Bug 15411: More changes Changes to Italian and Polish sql files and catalogue help file. TEST PLAN --------- 1) Confirm sql is valid and has Non-fiction. 2) Staff -> Search -> Help -- Confirm Non-fiction 3) Run koha qa test tools Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15411 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15411 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46296|0 |1 is obsolete| | --- Comment #8 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 46298 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46298&action=edit Bug 15411: Changing 'Non fiction' to 'Non-fiction' To test: 1) Apply patch 2) Run updatedatabase.pl 3) Go to advanced search in Staff Client (ie /cgi-bin/koha/catalogue/search.pl) 4) Confirm that it says 'Non-fiction' in the 'Any content' drop-down menu under 'Subtype limits' 5) Go to item search (ie /cgi-bin/koha/catalogue/itemsearch.pl) 6) Confirm that it says 'Non-fiction' under 'Collection code' 7) Go to advanced search in OPAC (ie /cgi-bin/koha/opac-search.pl) and click 'More options' 8) Confirm that it says 'Non-fiction' in the 'Content' drop-down menu 9) Go to the details page for a non-fiction book in the OPAC (ie /cgi-bin/koha/opac-detail.pl?biblionumber=2) and click 'Holdings' tab 10) Confirm that it says 'Non-fiction' under 'Collection' heading Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
delete from auth_vals; source {appropriate file};
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15411 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46297|0 |1 is obsolete| | --- Comment #9 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 46299 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46299&action=edit Bug 15411: More changes Changes to Italian and Polish sql files and catalogue help file. TEST PLAN --------- 1) Confirm sql is valid and has Non-fiction. 2) Staff -> Search -> Help -- Confirm Non-fiction 3) Run koha qa test tools Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15411 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15411 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46298|0 |1 is obsolete| | Attachment #46299|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 46350 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46350&action=edit [PASSED QA] Bug 15411: Changing 'Non fiction' to 'Non-fiction' To test: 1) Apply patch 2) Run updatedatabase.pl 3) Go to advanced search in Staff Client (ie /cgi-bin/koha/catalogue/search.pl) 4) Confirm that it says 'Non-fiction' in the 'Any content' drop-down menu under 'Subtype limits' 5) Go to item search (ie /cgi-bin/koha/catalogue/itemsearch.pl) 6) Confirm that it says 'Non-fiction' under 'Collection code' 7) Go to advanced search in OPAC (ie /cgi-bin/koha/opac-search.pl) and click 'More options' 8) Confirm that it says 'Non-fiction' in the 'Content' drop-down menu 9) Go to the details page for a non-fiction book in the OPAC (ie /cgi-bin/koha/opac-detail.pl?biblionumber=2) and click 'Holdings' tab 10) Confirm that it says 'Non-fiction' under 'Collection' heading Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
delete from auth_vals; source {appropriate file};
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15411 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 46351 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46351&action=edit [PASSED QA] Bug 15411: More changes Changes to Italian and Polish sql files and catalogue help file. TEST PLAN --------- 1) Confirm sql is valid and has Non-fiction. 2) Staff -> Search -> Help -- Confirm Non-fiction 3) Run koha qa test tools Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org