[Bug 7371] New: AutoEmailPrimaryAddress set to 'OFF' in new installs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7371 Bug #: 7371 Summary: AutoEmailPrimaryAddress set to 'OFF' in new installs Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 - low Component: Database AssignedTo: gmcharlt@gmail.com ReportedBy: nengard@gmail.com QAContact: ian.walls@bywatersolutions.com INSERT INTO `systempreferences` (variable,value,explanation,options,type) VALUES('AutoEmailPrimaryAddress','OFF','Defines the default email address where \'Account Details\' emails are sent.','email|emailpro|B_email|cardnumber|OFF','Choice'); This preference should be set to one of the choices - and OFF shouldn't be a choice - OFF seems to map to 'alternate' -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7371 --- Comment #1 from Nicole C. Engard <nengard@gmail.com> 2011-12-20 16:44:28 UTC --- Also, doesn't first_valid make the most sense as the default value since it's the most broad? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7371 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Assignee|gmcharlt@gmail.com |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Nicole, I checked this bug and it seems that OFF is mapping to 'first valid' which makes the default setting like you wanted it :) - - "Use" - pref: AutoEmailPrimaryAddress default: "OFF" choices: email: home emailpro: work B_email: alternate "OFF": first valid - "patron email address for sending out emails." - This also matches the code: 909 if ($which_address eq 'OFF') { 910 $to_address = GetFirstValidEmailAddress( $message->{'borrowernumber'} ); But there is one option 'cardnumber' that is not reflected in the pref file and can not be selected. I am going to add it. INSERT INTO `systempreferences` VALUES ('AutoEmailPrimaryAddress','OFF','email|emailpro|B_email|cardnumber|OFF','Defines the default email address where Account Details emails are sent.','Choice')" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7371 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 9130 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9130&action=edit Bug 7371: Add 'cardnumber' as option for AutoEmailPrimaryAddress The systempref.sql file had one more option 'cardnumber' that was not visible from the system preference editor. This patch adds the setting. To test: - Check new setting cardnumber is available for AutoEmailPrimaryAddress - Use setting with a patron that has an email address as cardnumber and verify email is sent out correctly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7371 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7371 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9130|0 |1 is obsolete| | --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 9162 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9162&action=edit Bug 7371: Add 'cardnumber' as option for AutoEmailPrimaryAddress The systempref.sql file had one more option 'cardnumber' that was not visible from the system preference editor. This patch adds the setting. To test: - Check new setting cardnumber is available for AutoEmailPrimaryAddress - Use setting with a patron that has an email address as cardnumber and verify email is sent out correctly. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7371 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7371 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from Ian Walls <koha.sekjal@gmail.com> --- Safely adds 'cardnumber' option to syspref editor. Marking Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7371 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_6 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org