[Bug 12805] New: Proposed changes to Koha plugins system (.KPZ) structure
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12805 Bug ID: 12805 Summary: Proposed changes to Koha plugins system (.KPZ) structure Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: In Discussion Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt@gmail.com Reporter: indradg@gmail.com QA Contact: testopia@bugs.koha-community.org In present scenario, the <pluginsdir> as per git install is located at /var/lib/plugins and per the Koha manual should be set up at /var/lib/koha/plugin. That makes it a shared directory, and a problem with multi-tenanted installations. Removable of the plugin by Client A, results in it being removed for everyone else. Same goes for installation of new plugins. These may not have been vetted or required by other clients / sites sharing the installation. Further, while the git based dev installation and the tarball installation have the <pluginsdir> defined in their respective 'skel' structures, this is missing the .deb packages. So, I propose the following changes: 1) move <pluginsdir> to a site-specific directory i.e. /var/lib/koha/<site>/plugins Rationale: (a) allow for security-vetted and need-based plugin upload and segregation; (b) "UseKohaPlugins" is classed under site-specific "Enhanced Content" sysprefs; (c) allow for easy resolution of AssignUserId apache directive in case of git installs (on a git install, .kpz uploads failed by default, citing apache doesn't own the directory); 2) add a 'koha-enable-plugins' shell script as part of the command-line tools. Since, the plugins module was primarily Kyle's baby, I would like to hear back from him and others on this, before proceeding. thanks -indra -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12805 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz, | |gmcharlt@gmail.com, | |indradg@gmail.com, | |kyle@bywatersolutions.com Assignee|gmcharlt@gmail.com |indradg@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12805 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin@catalyst.net.nz --- Comment #1 from Robin Sheat <robin@catalyst.net.nz> --- 1) is exactly how the packages do it now, 2) I don't see the need for this. At the moment you edit koha-conf.xml and set enable_plugins to 1 and that's all that's needed. koha-enable-plugins would just do that, but I feel it's doing such a small thing that it may as well be just the edit. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12805 --- Comment #2 from Robin Sheat <robin@catalyst.net.nz> --- One change I would like is supporting .tar.gz, .zip is such a wrong idea on linux systems. But that's probably its own bug :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12805 --- Comment #3 from Indranil Das Gupta <indradg@gmail.com> --- (In reply to Robin Sheat from comment #1)
1) is exactly how the packages do it now,
Mea culpa! Got that one clarified at #koha :-)
2) I don't see the need for this. At the moment you edit koha-conf.xml and set enable_plugins to 1 and that's all that's needed. koha-enable-plugins would just do that, but I feel it's doing such a small thing that it may as well be just the edit.
Automation and ease-of-use. With newbie users that I'm training up on Ubuntu/Koha combination, it is easier to have them run a "command" rather than fire up an editor, locate the line and change 0 to 1. FWIW, these are not technically savvy people and I've faced several cases of accidental deletion of other crucial lines / insertion of extraneous characters while making these small changes. These are largely train-and-let-go users whose only tech support is via telephone. The installations typically do not have Internet access. But yes, this is a niche case, and perhaps do not map into regular Koha users. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12805 --- Comment #4 from Robin Sheat <robin@catalyst.net.nz> --- I'm OK with having the script created, that's no problem. If someone writes it, I certainly wouldn't veto it :) But be aware that installing plugins may require some additional commandline stuff too, chmod'ing files etc. Due to them being in a zip file, they can end up installed with the most unsafe permissions possible, and that must be fixed from the command line. Also, some scripts may need to be made executable. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12805 Viktor Sarge <viktor.sarge@regionhalland.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |viktor.sarge@regionhalland. | |se --- Comment #5 from Viktor Sarge <viktor.sarge@regionhalland.se> --- I can only provide partial feedback here. An optional command line tool would be a welcome addition. It's practical when you are afraid to to mess the file up, while still making it possible to edit it manually and learn a little more about whats going on under the hood. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12805 --- Comment #6 from Indranil Das Gupta <indradg@gmail.com> --- Created attachment 31112 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31112&action=edit Adds koha-enable-plugins and koha-disable-plugins scripts Command-line koha-* script to toggle <enable_plugins> definition in site specific koha-conf.xml; also to add plugins listing to existing koha-list command. These files are expected to be used for a .deb package based installation of Koha Test plan: 1) Have a koha-common setup installed 2) Apply the patch and build a package for it. 3) Install it. 4) Verify that /yazgfz/config/enable_plugins is being toggled correctly when koha-enable-plugins and koha-disable-plugins are being called respectively. -idg -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12805 --- Comment #7 from Robin Sheat <robin@catalyst.net.nz> --- While I haven't tested it yet, this patch looks like a good approach to me. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12805 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@enger.priv.no --- Comment #8 from Magnus Enger <magnus@enger.priv.no> --- (In reply to Viktor Sarge from comment #5)
I can only provide partial feedback here. An optional command line tool would be a welcome addition. It's practical when you are afraid to to mess the file up, while still making it possible to edit it manually and learn a little more about whats going on under the hood.
This got me thinking about the possibilities of adding a general purpose koha-config script. See bug 12824 for some suggestions/questions. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org