[Bug 6864] New: add a syspref to allow custom text for OPAC user/pass information
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6864 Bug #: 6864 Summary: add a syspref to allow custom text for OPAC user/pass information Classification: Unclassified Change sponsored?: --- Product: Koha Version: unspecified Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: OPAC AssignedTo: oleonard@myacpl.org ReportedBy: mtj@kohaaloha.com QAContact: koha-bugs@lists.koha-community.org Created attachment 5401 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5401 image -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6864 --- Comment #1 from Mason James <mtj@kohaaloha.com> 2011-09-12 05:13:59 UTC --- some libraries may want to change the default text regarding the assigning of patron cards and passwords, depending on a library's policy adding a syspref would allow them to do this... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6864 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Version|unspecified |master AssignedTo|oleonard@myacpl.org |mtj@kohaaloha.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6864 Frédérick Capovilla <fcapovilla@live.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff CC| |fcapovilla@live.ca Assignee|mtj@kohaaloha.com |fcapovilla@live.ca --- Comment #2 from Frédérick Capovilla <fcapovilla@live.ca> --- Created attachment 25714 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25714&action=edit Add the OpacBelowLoginBox preference. We did a patch for our Koha instance which does what you are looking for. This patch adds the OpacBelowLoginBox which lets you set the message to show under the login form in the OPAC. If the preference is empty, the default, translatable text is used instead of the custom preference value. Sponsored-by: CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6864 Frédérick Capovilla <fcapovilla@live.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6864 --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 25714 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25714 Add the OpacBelowLoginBox preference. Review of attachment 25714: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=6864&attachment=25714) ----------------------------------------------------------------- ::: installer/data/mysql/updatedatabase.pl @@ +7825,5 @@
}
+$DBversion = "XXX"; +if ( CheckVersion($DBversion) ) { + $dbh->do("INSERT INTO `systempreferences` (variable,value,options,explanation,type) VALUES ('OpacBelowLoginBox','', '30|10','Texte à afficher en dessous de la boite de login','Textarea');");
I believe the text should be in English. ::: koha-tmpl/opac-tmpl/prog/en/modules/opac-auth.tt @@ +87,5 @@
<input type="submit" value="Log In" class="submit" /> <div id="nologininstructions"> + [% IF ( opacbelowloginbox ) %] + [% opacbelowloginbox %] + [% IF PatronSelfRegistration && PatronSelfRegistrationDefaultCategory %]<span id="registrationinstructions"><a href="/cgi-bin/koha/opac-memberentry.pl">Register here</a></span>[% END %]
Kind of strange to have the self-registration stuff in both IF and ELSE clauses. Put it after the IF/ELSE. ::: koha-tmpl/opac-tmpl/prog/en/modules/opac-main.tt @@ +62,5 @@
</fieldset></fieldset> </form> + <br style="clear:both" /> + <div>
div's should have id's or classes or some way of being able to affect them via Javascript, in my opinion. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6864 Frédérick Capovilla <fcapovilla@live.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25714|0 |1 is obsolete| | --- Comment #4 from Frédérick Capovilla <fcapovilla@live.ca> --- Created attachment 25938 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25938&action=edit New version of the patch. Rebase on current master and fixed. Here is a new version of the patch, fixing comment 1 and 3 of your code review. For the self-registration, the text is duplicated because the old version includes "or" and a period, which is not needed for the custom text since the link cannot be included inside of it. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6864 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED CC| |mtompset@hotmail.com --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- Sorry. I missed mentioning that you forgot to update installer/data/mysql/sysprefs.sql as well. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6864 --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 25938 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25938 New version of the patch. Rebase on current master and fixed. Review of attachment 25938: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=6864&attachment=25938) ----------------------------------------------------------------- ::: koha-tmpl/opac-tmpl/prog/en/modules/opac-main.tt @@ +64,5 @@
</form> + <br style="clear:both" /> + <div id="opacbelowloginbox"> + [% opacbelowloginbox %] + </div>
I like the id, but I'm not sure I see a need for this functionality. ::: opac/opac-main.pl @@ +56,4 @@
$template->param( koha_news => $all_koha_news, koha_news_count => $koha_news_count, + opacbelowloginbox => C4::Context->preference("OpacBelowLoginBox"),
So you really want something under the login area in the right side of the OPAC screen? I think it is ugly. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6864 --- Comment #7 from M. Tompsett <mtompset@hotmail.com> --- If you do want something under the login area displayed on the main screen, perhaps it would be shorter or different than the other login area reached by clicking 'Log in to your account'? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6864 --- Comment #8 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 25938 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25938 New version of the patch. Rebase on current master and fixed. Review of attachment 25938: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=6864&attachment=25938) ----------------------------------------------------------------- ::: koha-tmpl/opac-tmpl/prog/en/modules/opac-main.tt @@ +64,5 @@
</form> + <br style="clear:both" /> + <div id="opacbelowloginbox"> + [% opacbelowloginbox %] + </div>
With PatronSelfRegistration turned on, it gets uglier. The div is in the wrong place. It should be above line 61, I think. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6864 Frédérick Capovilla <fcapovilla@live.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25938|0 |1 is obsolete| | --- Comment #9 from Frédérick Capovilla <fcapovilla@live.ca> --- Created attachment 26465 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26465&action=edit New version of the patch, removing code in opac-main and adding missing syspref line. Since we can use the existing opacnavright preference to get the same text in opac-main, I removed the opacBelowLoginBox text from this page. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6864 Frédérick Capovilla <fcapovilla@live.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6864 --- Comment #10 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 26465 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26465 New version of the patch, removing code in opac-main and adding missing syspref line. Review of attachment 26465: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=6864&attachment=26465) ----------------------------------------------------------------- ::: installer/data/mysql/sysprefs.sql @@ +427,5 @@
('XSLTResultsDisplay','default','','Enable XSL stylesheet control over results page display on intranet','Free'), ('yuipath','local','local|http://yui.yahooapis.com/2.5.1/build','Insert the path to YUI libraries, choose local if you use koha offline','Choice'), ('z3950AuthorAuthFields','701,702,700',NULL,'Define the MARC biblio fields for Personal Name Authorities to fill biblio.author','free'), +('z3950NormalizeAuthor','0','','If ON, Personal Name Authorities will replace authors in biblio.author','YesNo'), +('OpacBelowLoginBox','', '30|10','HTML to show under the login box','Textarea')
Please try to keep this alphabetical. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6864 --- Comment #11 from M. Tompsett <mtompset@hotmail.com> --- Also, bootstrap. You only tweaked prog opactheme. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6864 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6864 --- Comment #12 from David Cook <dcook@prosentient.com.au> --- We have the same local enhancement. This would be another one that could benefit from using a WYSIWYG editor on the syspref. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6864 --- Comment #13 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 26774 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26774&action=edit Bug 6864 - Corrected alphabetical order of sysprefs.sql Original patch lazily added OpacBelowLoginBox to the end. This puts it in proper alphabetical order location. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6864 --- Comment #14 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 26776 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26776&action=edit Bug 6864 - Added missing bootstrap template changes. The original patch only touches the prog template. This updates the bootstrap theme in a corresponding manner. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6864 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26774|0 |1 is obsolete| | --- Comment #15 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 26779 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26779&action=edit Bug 6864 - Corrected alphabetical order of sysprefs.sql Original patch lazily added OpacBelowLoginBox to the end. This puts it in proper alphabetical order location. TEST PLAN --------- 1) Apply only the first patch 2) Run the Koha QA Test tool -- FAILED on the system preferences SQL file. 3) Apply only the second patch (this one) 4) Run the Koha QA Test tool -- Everything OK now. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6864 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26465|0 |1 is obsolete| | --- Comment #16 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 26780 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26780&action=edit [SIGNED OFF] Add OpacBelowLoginBox preference to add custom text below the login box. This patch file adds the ability to customize the text below the login area which appears when 'Log in to your account' in clicked in the top right of the OPAC. TEST PLAN ---------- 0) Back up your data if you care about it. 1) Open a staff client in your browser. 2) Make sure the OPAC system preference opacthemes is set to 'prog'. 3) Make sure the OPAC system preference opacuserlogin is set to 'Allow'. NOTE: Required to make the 'Log in to your account' in the top left of OPAC appear. 4) Make sure the OPAC system preference PatronSelfRegistration is set to 'Allow'. 5) Make sure the OPAC system preference PatronSelfRegistrationDefaultCategory is set to a value of patron category that exists (eg. PT is a sample one) NOTE: These are required to make the 'Register here' links appear after the text. 6) Open the OPAC in another tab. 7) Click the 'Log in to your account' link. 8) Note the text below the login area. 9) Apply the patch and run an update. (git bz apply 6864 -- interactive just this one) (./installer/data/mysql/updatedatabase.pl) 10) Refresh the OPAC page. -- the text should be identical. 11) In the staff client, modify the OPAC system preference OpacBelowLoginText to have some text, and save. 12) Refresh the OPAC page. -- the text should reflect what was entered in the OpacBelowLoginText system preference. 13) Open your mysql. 14) Drop and recreate the koha database. 15) Do a web install by going to the staff client URL. 16) Log in as the system user. 17) Confirm the OPAC system preference OpacBelowLoginBox exists. 18) Modify its value (blank, non-blank) and confirm that the OPAC page reflects the default message or custom message as expected each reload. 19) Run the Koha QA Test Tool -- This will FAIL on the system preferences SQL file. The next patch by me, Mark Tompsett, will fix it. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6864 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26779|0 |1 is obsolete| | --- Comment #17 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 26781 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26781&action=edit Bug 6864 - Corrected alphabetical order of sysprefs.sql Original patch lazily added OpacBelowLoginBox to the end. This puts it in proper alphabetical order location. TEST PLAN --------- 1) Apply only the first patch 2) Run the Koha QA Test tool -- FAILED on the system preferences SQL file. 3) Apply only the second patch (this one) 4) Run the Koha QA Test tool -- Everything OK now. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6864 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26776|0 |1 is obsolete| | --- Comment #18 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 26782 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26782&action=edit Bug 6864 - Added missing bootstrap template changes. The original patch only touches the prog template. This updates the bootstrap theme in a corresponding manner. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6864 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26782|0 |1 is obsolete| | --- Comment #19 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 26783 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26783&action=edit Bug 6864 - Bootstrap OpacBelowLoginBox This adds OpacBelowLoginBox to bootstrap. It also corrects the placement of setting the opacbelowloginbox template parameter, so that it will work under bootstrap. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6864 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26783|0 |1 is obsolete| | --- Comment #20 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 26784 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26784&action=edit Bug 6864 - Bootstrap OpacBelowLoginBox This adds OpacBelowLoginBox to bootstrap. It also corrects the placement of setting the opacbelowloginbox template parameter, so that it will work under bootstrap. TEST PLAN --------- Run steps similar to the first patch except with opacthemese set to 'bootstrap'. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6864 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #21 from Owen Leonard <oleonard@myacpl.org> --- A couple of comments: The system preference name "OpacBelowLoginBox" refers to where it goes rather than what it is. It would be a lot better to have something descriptive, like "OpacLoginHelp" or something like that. The change to the bootstrap theme modifies a different page than the change to the prog theme. I think the change to the prog theme is in the right place: On the full-page login screen where there is currently text about logging in, opac-auth.tt. (It might be good to link to this page directly from the bootstrap theme's login modal so that patrons can read the help text if they want to?) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6864 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl@biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6864 Eric Bégin <eric.begin@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric.begin@inLibro.com --- Comment #22 from Eric Bégin <eric.begin@inLibro.com> --- I think this may be a duplicate of 10951 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6864 --- Comment #23 from M. Tompsett <mtompset@hotmail.com> --- 10951 is only partially what this was supposed to cover, as far as I can tell. This should be reworked to use the system preference in 10951. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6864 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10951 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6864 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Resolution|--- |DUPLICATE Status|Failed QA |RESOLVED --- Comment #24 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- For me, this is a complete duplicate of Bug 10951 *** This bug has been marked as a duplicate of bug 10951 *** -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org