[Bug 32878] New: Make it impossible to renew the item if it has active item level hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32878 Bug ID: 32878 Summary: Make it impossible to renew the item if it has active item level hold Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Circulation Assignee: stalkernoid@gmail.com Reporter: stalkernoid@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32878 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32878 --- Comment #1 from Peter Vashchuk <stalkernoid@gmail.com> --- Created attachment 146145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146145&action=edit Bug 32878: Make it impossible to renew the item if it has active item level hold introduced in: 73c3c5d2f10751c23156372300239d42e5957c66 Bug 31112: (QA follow-up) Reduce database queries started from: 8ba1a9a5345310c54d9225049d470544b56eeb11 Bug 31112: Remove unnecessary if-clause Currently, you can renew the item even if someone already made an item level hold on that item. This patch changes that, making it not possible to do so. To reproduce: 1. Checkout an item, and make another item level hold on that specific item. 2. Renew it using the "Renew" checkbox, it should get renewed without any problems. 3. Apply the patch. 4. Checkbox should be gone and replaced with "On Hold" link that leads to the hold that doesn't allow you to renew the item again. 5. "Renew all" button should not work either. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32878 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh@dubcolib.org --- Comment #2 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Fleshing this out a little: To reproduce: 1: have AllowRenewalIfOtherItemsAvailable set to Allow 2: have a bib with multiple items 3: 3: Checkout an item, and make another item level hold on that specific item. 4: Renew it using the "Renew" checkbox, it should get renewed without any problems. 5: Apply the patch. 6: Checkbox should be gone and replaced with "On Hold" link that leads to the hold that doesn't allow you to renew the item again. 7: "Renew all" button should not work either. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32878 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32878 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146145|0 |1 is obsolete| | --- Comment #3 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Created attachment 146166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146166&action=edit Bug 32878: Make it impossible to renew the item if it has active item level hold introduced in: 73c3c5d2f10751c23156372300239d42e5957c66 Bug 31112: (QA follow-up) Reduce database queries started from: 8ba1a9a5345310c54d9225049d470544b56eeb11 Bug 31112: Remove unnecessary if-clause Currently, you can renew the item even if someone already made an item level hold on that item. This patch changes that, making it not possible to do so. To reproduce: 1. Checkout an item, and make another item level hold on that specific item. 2. Renew it using the "Renew" checkbox, it should get renewed without any problems. 3. Apply the patch. 4. Checkbox should be gone and replaced with "On Hold" link that leads to the hold that doesn't allow you to renew the item again. 5. "Renew all" button should not work either. Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32878 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Depends on| |31112 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32878 --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 146740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146740&action=edit Bug 32878: (QA follow-up) Unit test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32878 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146166|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 146741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146741&action=edit Bug 32878: Make it impossible to renew the item if it has active item level hold introduced in: 73c3c5d2f10751c23156372300239d42e5957c66 Bug 31112: (QA follow-up) Reduce database queries started from: 8ba1a9a5345310c54d9225049d470544b56eeb11 Bug 31112: Remove unnecessary if-clause Currently, you can renew the item even if someone already made an item level hold on that item. This patch changes that, making it not possible to do so. To reproduce: 1. Checkout an item, and make another item level hold on that specific item. 2. Renew it using the "Renew" checkbox, it should get renewed without any problems. 3. Apply the patch. 4. Checkbox should be gone and replaced with "On Hold" link that leads to the hold that doesn't allow you to renew the item again. 5. "Renew all" button should not work either. Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32878 --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 146742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146742&action=edit Bug 32878: (QA follow-up) Correct unit test After the patch we fail on renewing a not for loan item with an item level hold. I don't find justification for why this should be renewable, so I just change the test expectation This needs another QA eye Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32878 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32878 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32878 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146740|0 |1 is obsolete| | Attachment #146741|0 |1 is obsolete| | Attachment #146742|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 146830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146830&action=edit Bug 32878: (QA follow-up) Unit test Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32878 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146830|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 146833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146833&action=edit Bug 32878: (QA follow-up) Unit test Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32878 --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 146834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146834&action=edit Bug 32878: Make it impossible to renew the item if it has active item level hold introduced in: 73c3c5d2f10751c23156372300239d42e5957c66 Bug 31112: (QA follow-up) Reduce database queries started from: 8ba1a9a5345310c54d9225049d470544b56eeb11 Bug 31112: Remove unnecessary if-clause Currently, you can renew the item even if someone already made an item level hold on that item. This patch changes that, making it not possible to do so. To reproduce: 1. Checkout an item, and make another item level hold on that specific item. 2. Renew it using the "Renew" checkbox, it should get renewed without any problems. 3. Apply the patch. 4. Checkbox should be gone and replaced with "On Hold" link that leads to the hold that doesn't allow you to renew the item again. 5. "Renew all" button should not work either. Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32878 --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 146835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146835&action=edit Bug 32878: (QA follow-up) Correct unit test After the patch we fail on renewing a not for loan item with an item level hold. I don't find justification for why this should be renewable, so I just change the test expectation This needs another QA eye Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32878 koha-US bug tracker <bugzilla@koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla@koha-us.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32878 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32878 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32878 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32878 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- We have a failing test in master that appears to stem from here.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32878 --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 148220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148220&action=edit Bug 32878: (follow-up) Exclude non_priority holds This patch filters out non_priorty holds in the on_reserve condition. Test plan 1) Run t/db_dependant/Holds.t 2) Note it fails without this patch 3) Apply patch 4) Re-run the above test, note it now passes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32878 --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Must admit.. I always get a little confused around the priority fields of holds.. so a double check that this makes sense would be appreciated. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32878 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148220|0 |1 is obsolete| | --- Comment #15 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 148223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148223&action=edit Bug 32878: (follow-up) Exclude non_priority holds This patch filters out non_priorty holds in the on_reserve condition. Test plan 1) Run t/db_dependant/Holds.t 2) Note it fails without this patch 3) Apply patch 4) Re-run the above test, note it now passes Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32878 --- Comment #16 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Martin Renvoize from comment #14)
Must admit.. I always get a little confused around the priority fields of holds.. so a double check that this makes sense would be appreciated.
Non-priority holds specify when placing that they should not block renewals, so this is correct -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32878 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | CC| |tomascohen@gmail.com --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Follow-up pushed to master. Thanks, you rock! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32878 Lisette Scheer <lisette.scheer@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33361 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32878 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00, 22.05.10.04 released in| | CC| |Laura.escamilla@bywatersolu | |tions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32878 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00, 22.05.10.04 |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32878 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #18 from Lucas Gass <lucas@bywatersolutions.com> --- Can this be backported to 22.11.x? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32878 --- Comment #19 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Just following up to see if this can be backported to 22.11.x? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32878 --- Comment #20 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- (In reply to Laura Escamilla from comment #19)
Just following up to see if this can be backported to 22.11.x?
Just wanted to check on this one again to see if it could be backported. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32878 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.07 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32878 --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32878 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15261 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org