[Bug 27656] New: misc/cronjobs/longoverdue.pl better error message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27656 Bug ID: 27656 Summary: misc/cronjobs/longoverdue.pl better error message Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: robin@catalyst.net.nz There are two ways of configuring misc/cronjobs/longoverdue.pl : use --lost arg or system preferences DefaultLongOverdueLostValue and DefaultLongOverdueDays. Actually if you don't use any of it, you get a message : "ERROR: No --lost (-l) option defined" Should also say something about preferences. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27656 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27656 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 116510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116510&action=edit Bug 27656: misc/cronjobs/longoverdue.pl better error message There are two ways of configuring misc/cronjobs/longoverdue.pl : use --lost arg or system preferencies DefaultLongOverdueLostValue and DefaultLongOverdueDays. Actually if you don't use any of it, you get a message : "ERROR: No --lost (-l) option defined" Should also say something about preferencies : "ERROR: No --lost (-l) option nor system preferencies DefaultLongOverdueLostValue/DefaultLongOverdueDays defined" Test plan: 1) Set empty preferences DefaultLongOverdueLostValue and DefaultLongOverdueDays 2) Run : misc/cronjobs/longoverdue.pl --maxdays 365 3) You see error message 4) Set DefaultLongOverdueLostValue = 1 and DefaultLongOverdueDays = 90 5) Run : misc/cronjobs/longoverdue.pl --maxdays 365 6) You don't see error message -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27656 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27656 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27656 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116510|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 119093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119093&action=edit Bug 27656: misc/cronjobs/longoverdue.pl better error message There are two ways of configuring misc/cronjobs/longoverdue.pl : use --lost arg or system preferencies DefaultLongOverdueLostValue and DefaultLongOverdueDays. Actually if you don't use any of it, you get a message : "ERROR: No --lost (-l) option defined" Should also say something about preferencies : "ERROR: No --lost (-l) option nor system preferencies DefaultLongOverdueLostValue/DefaultLongOverdueDays defined" Test plan: 1) Set empty preferences DefaultLongOverdueLostValue and DefaultLongOverdueDays 2) Run : misc/cronjobs/longoverdue.pl --maxdays 365 3) You see error message 4) Set DefaultLongOverdueLostValue = 1 and DefaultLongOverdueDays = 90 5) Run : misc/cronjobs/longoverdue.pl --maxdays 365 6) You don't see error message Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27656 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- A minor suggestion would be to change the error message from: ..option nor system preferencies.. to ..option or system preferences.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27656 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Please address David's suggestion. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27656 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27656 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119093|0 |1 is obsolete| | --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 119707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119707&action=edit Bug 27656: misc/cronjobs/longoverdue.pl better error message There are two ways of configuring misc/cronjobs/longoverdue.pl : use --lost arg or system preferencies DefaultLongOverdueLostValue and DefaultLongOverdueDays. Actually if you don't use any of it, you get a message : "ERROR: No --lost (-l) option defined" Should also say something about preferencies : "ERROR: No --lost (-l) option no system preferences DefaultLongOverdueLostValue/DefaultLongOverdueDays defined" Test plan: 1) Set empty preferences DefaultLongOverdueLostValue and DefaultLongOverdueDays 2) Run : misc/cronjobs/longoverdue.pl --maxdays 365 3) You see error message 4) Set DefaultLongOverdueLostValue = 1 and DefaultLongOverdueDays = 90 5) Run : misc/cronjobs/longoverdue.pl --maxdays 365 6) You don't see error message Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27656 --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Jonathan Druart from comment #4)
Please address David's suggestion.
Sure. My english is sometimes rusty ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27656 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119707|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 119744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119744&action=edit Bug 27656: misc/cronjobs/longoverdue.pl better error message There are two ways of configuring misc/cronjobs/longoverdue.pl : use --lost arg or system preferencies DefaultLongOverdueLostValue and DefaultLongOverdueDays. Actually if you don't use any of it, you get a message : "ERROR: No --lost (-l) option defined" Should also say something about preferencies : "ERROR: No --lost (-l) option no system preferences DefaultLongOverdueLostValue/DefaultLongOverdueDays defined" Test plan: 1) Set empty preferences DefaultLongOverdueLostValue and DefaultLongOverdueDays 2) Run : misc/cronjobs/longoverdue.pl --maxdays 365 3) You see error message 4) Set DefaultLongOverdueLostValue = 1 and DefaultLongOverdueDays = 90 5) Run : misc/cronjobs/longoverdue.pl --maxdays 365 6) You don't see error message Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27656 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27656 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27656 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27656 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.05.00 |21.05.00,20.11.05 released in| | --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27656 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com Status|Pushed to stable |Pushed to oldstable Version(s)|21.05.00,20.11.05 |21.05.00,20.11.05,20.05.11 released in| | --- Comment #10 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 20.05.x for 20.05.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27656 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC| |victor@tuxayo.net --- Comment #11 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org