[Bug 36921] New: Incorrect error description on local title import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36921 Bug ID: 36921 Summary: Incorrect error description on local title import Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ERM Assignee: jonathan.druart@gmail.com Reporter: tomascohen@gmail.com CC: jonathan.druart@gmail.com, jonathan.field@ptfs-europe.com, martin.renvoize@ptfs-europe.com, matt.blenkinsop@ptfs-europe.com, pedro.amorim@ptfs-europe.com At least on the KBART import feature, if the file *extension* is not one of '.tsv' or '.csv', the displayed message is: ``` The file must be in .tsv or .csv format, please convert your file and try again. ``` I would write something like this instead: ``` The file extension must be either .tsv or .csv, depending on the file format. Other extensions are not accepted. ``` -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36921 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch CC| |katrin.fischer@bsz-bw.de, | |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36921 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We will "fix" this and remove the note with Bug 36831 - Add support for .txt files to the KBART import tool (I filed a similar report yesterday) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36921 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36921 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 167022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167022&action=edit Bug 36921: Fix error description on KBART file import Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36921 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- I had a go at testing, however I'm not seeing the error message before or after the patch is applied. I used the test file from bug 36831 Something pops up and then disappears very quickly, and the file is not loaded. No titles are imported (as expected). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36921 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Assignee|jonathan.druart@gmail.com |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36921 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- I wonder if this error in the console is related: Uncaught (in promise) TypeError: can't access property "invalid_columns", success.warnings is undefined addDocument webpack://koha/./koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalTitlesKBARTImport.vue?./node_modules/vue-loader/dist/index.js??ruleSet[1].rules[5].use[0]:86 erm_24.0600000.js line 2026 > eval:86:25 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36921 Laurence Rault <laurence.rault@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |laurence.rault@biblibre.com --- Comment #5 from Laurence Rault <laurence.rault@biblibre.com> --- No message, but only a popup appears very briefly, no time to read it. As expected, the file is not loaded. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org