[Bug 33774] New: Loading club table in every tab in patron details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33774 Bug ID: 33774 Summary: Loading club table in every tab in patron details Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org When clubs are defined, the clubs table loads in all tabs at the bottom of the patrons details page. To recreate: 1. Create a club 1.1. Go to Tools > Patron clubs 1.2. Click 'New club template' 1.3. Enter a name 1.4. Click 'Save' 1.5. Click 'New club' and choose the template 1.6. Enter a name 1.7. Click 'Save' 2. Go to Patrons and go in any patron's account --> At the bottom of the page, the 'Checkouts' tab says 'Loading...' 3. Click any other tab in that bottom section (Holds, Claims, Restrictions, Article requests, Recalls) --> All say 'Loading...' 4. Click the Clubs tab --> The table loads finally 5. Click back in any other tab --> The Clubs table shows in all tabs https://snipboard.io/0tBYLM.jpg -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33774 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major CC| |david@davidnind.com Version|unspecified |master --- Comment #1 from David Nind <david@davidnind.com> --- I checked this on 22.11.05, and it is not doing this. So, at the moment the bug is limited to master. I changed the importance to major, as the details area is used frequently - and I don't think you would want this bug showing in a new release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33774 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com, | |shi-yao.wang@inLibro.com, | |tomascohen@gmail.com Depends on| |26598 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Git bisect says the problem comes from Bug 26598 Display guarantee's fines on guarantor's details page Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26598 [Bug 26598] Display guarantee's fines on guarantor's details page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33774 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33774 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33774 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 151470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151470&action=edit Bug 33774: Loading club table in every tab in patron details This patch corrects a minor regression in template markup caused by Bug 33774. The Bootstrap tab attributes were lost (presumably in a merge) causing the whole tab structure to break. To test, you should have at least one club defined. Apply the patch and view the patron details page. Each tab should load its contents correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33774 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33774 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151470|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 151472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151472&action=edit Bug 33774: Loading club table in every tab in patron details This patch corrects a minor regression in template markup caused by Bug 33774. The Bootstrap tab attributes were lost (presumably in a merge) causing the whole tab structure to break. To test, you should have at least one club defined. Apply the patch and view the patron details page. Each tab should load its contents correctly. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33774 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151472|0 |1 is obsolete| | --- Comment #5 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 151500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151500&action=edit Bug 33774: Loading club table in every tab in patron details This patch corrects a minor regression in template markup caused by Bug 33774. The Bootstrap tab attributes were lost (presumably in a merge) causing the whole tab structure to break. To test, you should have at least one club defined. Apply the patch and view the patron details page. Each tab should load its contents correctly. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> https://bugs.koha-community.org/show_bug.cgi?id=26598 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33774 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151500|0 |1 is obsolete| | --- Comment #6 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 151501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151501&action=edit Bug 33774: Loading club table in every tab in patron details This patch corrects a minor regression in template markup caused by Bug 33774. The Bootstrap tab attributes were lost (presumably in a merge) causing the whole tab structure to break. To test, you should have at least one club defined. Apply the patch and view the patron details page. Each tab should load its contents correctly. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33774 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Signed Off |Passed QA --- Comment #7 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Works, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33774 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33774 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33774 Bug 33774 depends on bug 26598, which changed state. Bug 26598 Summary: Display guarantee's fines on guarantor's details page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26598 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33774 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |matt.blenkinsop@ptfs-europe | |.com --- Comment #9 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Missing dependency - not backporting to 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org