[Bug 6912] New: OPAC display crashes for analytical biblio with 008 field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6912 Bug #: 6912 Summary: OPAC display crashes for analytical biblio with 008 field Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: OPAC AssignedTo: oleonard@myacpl.org ReportedBy: frederic@tamil.fr QAContact: koha-bugs@lists.koha-community.org If CoinS is enabled, OPAC display crashes when displaying analytical biblio records which have not 008 field. To test: - Create a analytical biblio record (leader pos 6 = 'a'), without 008 field - In OPAC, display this biblio -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6912 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff AssignedTo|oleonard@myacpl.org |frederic@tamil.fr -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6912 --- Comment #1 from Frédéric Demians <frederic@tamil.fr> 2011-09-25 09:38:47 UTC --- Created attachment 5580 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5580 Proposed patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6912 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5580|0 |1 is obsolete| | --- Comment #2 from Frédéric Demians <frederic@tamil.fr> 2011-09-25 17:44:17 UTC --- Created attachment 5581 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5581 Proposed patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6912 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5581|0 |1 is obsolete| | --- Comment #3 from Frédéric Demians <frederic@tamil.fr> 2011-09-25 18:01:04 UTC --- Created attachment 5582 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5582 Proposed patch (with no warning in logs...) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6912 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jcamins@cpbibliography.com --- Comment #4 from Jared Camins-Esakov <jcamins@cpbibliography.com> 2011-10-08 16:40:38 UTC --- I cannot duplicate this bug. Or if I am duplicating it, I can't tell. What are the symptoms? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6912 --- Comment #5 from Frédéric Demians <frederic@tamil.fr> 2011-10-08 19:51:21 UTC ---
I cannot duplicate this bug. Or if I am duplicating it, I can't tell. What are the symptoms?
Thanks for testing. How to reproduce this bug, and test the patch: - In OPAC, go on a biblio record detail page. Note its biblionumber. - In another browser tab, go in staff interface, edit the previous MARC21 biblio record. - Open the leader editor. - In 7- Bibliographic level, choose 'a - Monographic component part' - Click OK, and save the the biblio record. - Switch to the OPAC tab. Refresh the page. You get this error message: Software error: Can't call method "data" on an undefined value at /home/tamil/client/lesc/kohaclone/C4/Biblio.pm line 1220. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6912 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|OPAC display crashes for |OPAC display crashes for |analytical biblio with 008 |analytical biblio without |field |008 field -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6912 --- Comment #6 from Frédéric Demians <frederic@tamil.fr> 2011-10-08 19:53:28 UTC --- Sorry, I forgot something. When editing the biblio record leader, you also have to remove the 008 field if you have one. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6912 --- Comment #7 from Jared Camins-Esakov <jcamins@cpbibliography.com> 2011-10-08 20:00:13 UTC --- Created attachment 5804 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5804 [SIGNED-OFF] Bug 6912 Test 008 presence in get CoinS function Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6912 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5582|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6912 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Patch Status|Needs Signoff |Signed Off --- Comment #8 from Jared Camins-Esakov <jcamins@cpbibliography.com> 2011-10-08 20:02:23 UTC --- I see. There is no case when a record should be without an 008, but, since it surely happens, this is very real issue. The patch works exactly as you said. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6912 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5804|0 |1 is obsolete| | --- Comment #9 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-12 15:51:24 UTC --- Created attachment 5859 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5859 Bug 6912 Test 008 presence in get CoinS function Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6912 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Patch Status|Signed Off |Passed QA --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-12 15:52:38 UTC --- QA comment : * trivial patch & good coding style * good description * works as announced passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6912 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.walls@bywatersolutions. | |com --- Comment #11 from Ian Walls <ian.walls@bywatersolutions.com> 2011-10-12 20:08:27 UTC --- Yup, straight forward patch, easy to read, agreed on passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6912 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Passed QA |Patch Pushed --- Comment #12 from Chris Cormack <chris@bigballofwax.co.nz> 2011-10-13 02:58:24 UTC --- No strings changed, pushing -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org