[Bug 29146] New: Should framework default values be applied to existing records?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 Bug ID: 29146 Summary: Should framework default values be applied to existing records? Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl If you open an existing record in the cataloguing editor, default framework values are applied. This may not always be the desired behavior. For instance, when you created the record and the defaults were applied, you did remove one value. When reopening the record, you dont like it to reappear? Any thoughts? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I agree. I think it should only default on creation of a new record. If I decide to remove the content of a field or the field itself, that should be respected. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | Severity|enhancement |normal Status|NEW |ASSIGNED --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Changing enhancement to bug status normal. What Koha does for years, is actually just wrong. The positive side is that many people will add the record, and not edit it any longer ;) But my cataloger tells me: I reopen the record, and remove the wrong defaults. Which is obviously kind of job creation. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 125541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125541&action=edit Bug 29146: Apply framework defaultvalue only to new records This applies only to the 'regular' cataloguing editor. Another report could be opened for the advanced one, if needed. Test plan: [1] Add a default value to some field X in framework Y. [2] Open an existing biblio record in that fw. Clear field X. Save. [3] Reopen the record. The default should not be in field X. [4] Add a new record in that fw. You should see default value in X. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch makes Koha no release notes| |longer apply default values | |to empty fields in an | |existing biblio record in | |the regular cataloguing | |editor. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Status|Needs Signoff |Failed QA --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Item edition is affected as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- And authorities? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 126981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126981&action=edit Bug 29146: Same for item editor Test plan: Put some defaultvalue in an item subfield. Test adding new item; is defaultvalue supplied already? Test adding existing item. Clear the subfield. Save. Open again. Is the subfield still empty now? Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Should framework default |Should framework default |values be applied to |values be applied to |existing records? |existing biblios and items? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #4)
Item edition is affected as well.
Fixed now. Please test. The change is in the new module ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29334 --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #5)
And authorities?
Will open another report for it. Bug 29334 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Marcel de Rooy from comment #7)
(In reply to Jonathan Druart from comment #4)
Item edition is affected as well.
Fixed now. Please test. The change is in the new module ;)
As it's a module, you need to provide a test :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #9)
(In reply to Marcel de Rooy from comment #7)
(In reply to Jonathan Druart from comment #4)
Item edition is affected as well.
Fixed now. Please test. The change is in the new module ;)
As it's a module, you need to provide a test :)
Ah yes, very unfortunate :) You still have a chance to increase your FQA score! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 126985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126985&action=edit Bug 29146: Add test for editing existing item Test plan: Run t/db_dependent/Koha/UI/Form/Builder/Item.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #9)
(In reply to Marcel de Rooy from comment #7)
(In reply to Jonathan Druart from comment #4)
Item edition is affected as well.
Fixed now. Please test. The change is in the new module ;)
As it's a module, you need to provide a test :)
Fixed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This patch makes Koha no |This patch makes Koha no release notes|longer apply default values |longer apply default values |to empty fields in an |to empty fields in an |existing biblio record in |existing biblio record in |the regular cataloguing |the regular cataloguing |editor. |editor. Same for item | |editor. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 --- Comment #13 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- + item => { itemnumber => 999 }, You should build_sample_item and use its itemnumber instead. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126985|0 |1 is obsolete| | --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 126988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126988&action=edit Bug 29146: Add test for editing existing item Test plan: Run t/db_dependent/Koha/UI/Form/Builder/Item.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 --- Comment #15 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #13)
+ item => { itemnumber => 999 },
You should build_sample_item and use its itemnumber instead.
Doing it with unblessed. But you know that the only essential thing here is existence of itemnumber key in a hash ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125541|0 |1 is obsolete| | --- Comment #16 from David Nind <david@davidnind.com> --- Created attachment 127041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127041&action=edit Bug 29146: Apply framework defaultvalue only to new records This applies only to the 'regular' cataloguing editor. Another report could be opened for the advanced one, if needed. Test plan: [1] Add a default value to some field X in framework Y. [2] Open an existing biblio record in that fw. Clear field X. Save. [3] Reopen the record. The default should not be in field X. [4] Add a new record in that fw. You should see default value in X. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126981|0 |1 is obsolete| | --- Comment #17 from David Nind <david@davidnind.com> --- Created attachment 127042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127042&action=edit Bug 29146: Same for item editor Test plan: Put some defaultvalue in an item subfield. Test adding new item; is defaultvalue supplied already? Test adding existing item. Clear the subfield. Save. Open again. Is the subfield still empty now? Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126988|0 |1 is obsolete| | --- Comment #18 from David Nind <david@davidnind.com> --- Created attachment 127043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127043&action=edit Bug 29146: Add test for editing existing item Test plan: Run t/db_dependent/Koha/UI/Form/Builder/Item.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 --- Comment #19 from David Nind <david@davidnind.com> --- Testing notes (using koha-testing-docker): - Set default values for items in the framework using 952 subfields -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Summary|Should framework default |Default values from the |values be applied to |framework should only be |existing biblios and items? |applied at biblio/item | |creation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127041|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127578&action=edit Bug 29146: Apply framework defaultvalue only to new records This applies only to the 'regular' cataloguing editor. Another report could be opened for the advanced one, if needed. Test plan: [1] Add a default value to some field X in framework Y. [2] Open an existing biblio record in that fw. Clear field X. Save. [3] Reopen the record. The default should not be in field X. [4] Add a new record in that fw. You should see default value in X. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127042|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127579&action=edit Bug 29146: Same for item editor Test plan: Put some defaultvalue in an item subfield. Test adding new item; is defaultvalue supplied already? Test adding existing item. Clear the subfield. Save. Open again. Is the subfield still empty now? Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127043|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127580&action=edit Bug 29146: Add test for editing existing item Test plan: Run t/db_dependent/Koha/UI/Form/Builder/Item.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I really should have got to this earlier.. it was the question in the title that put me off.. but it's clear from the top comments that the question was answered. I've updated the title to reflect the consensus. Patches are clear and simple enough to understand.. testing provides positive results and no regressions are found.. QA scripts are happy... Passing QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com --- Comment #24 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Martin Renvoize from comment #23)
I really should have got to this earlier.. it was the question in the title that put me off.. but it's clear from the top comments that the question was answered.
I've updated the title to reflect the consensus.
Patches are clear and simple enough to understand.. testing provides positive results and no regressions are found..
QA scripts are happy... Passing QA.
Thanks. Will try to use less questions in bug titles :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- By all means start with a question.. but amend it once a conclusion has been reached perhaps? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 --- Comment #26 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |kyle@bywatersolutions.com Status|Pushed to master |RESOLVED --- Comment #27 from Kyle M Hall <kyle@bywatersolutions.com> --- Does not apply to 21.05.x. Please rebase and let me know if this is needed! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29592 --- Comment #28 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- See follow-up report bug 29592 and discussion about impact on importing records from Z39.50 into basic editor. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29592 [Bug 29592] Imported records should not be completed with defaultvalues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This patch makes Koha no |This fixes the standard release notes|longer apply default values |cataloguing editor and the |to empty fields in an |item editor so that when |existing biblio record in |updating existing records |the regular cataloguing |and items empty fields are |editor. Same for item |not updated with the |editor. |default framework values. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30250 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30250 [Bug 30250] Default values from the framework should be applied when editing as new (duplicating) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #29 from Aleisha Amohia <aleisha@catalyst.net.nz> --- This has created a problem for one of our Koha libraries. When they duplicate a record (i.e 'Edit as new') they want empty fields to be filled with framework defaults. Although, due to this fix, they no longer get them. Duplicating records is like creating new records, so I think the check for a biblionumber needs to be alongside a check for whether this is a duplicate function. I've opened Bug 30250 for this follow-up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 pierre.genty@biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pierre.genty@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #30 from Fridolin Somers <fridolin.somers@biblibre.com> --- Also behavior is now different between biblio and authorities forms. See method create_input(). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 Lauren Denny <lauren_denny@sil.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lauren_denny@sil.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33670 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33670 [Bug 33670] Changes from bz29146/bz30250 doesn't apply when duplicate record suspected -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org