[Bug 40051] New: cy.wait(delay) should not be used in Cypress tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40051 Bug ID: 40051 Summary: cy.wait(delay) should not be used in Cypress tests Change sponsored?: --- Product: Koha Version: 24.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart@gmail.com Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org It can cause random failures. We should rely on the existence of something, Cypress will retry if the test fails. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40051 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|24.11 |unspecified Depends on| |40046 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40046 [Bug 40046] Remove wait and screenshot from Tools/ManageMarcImport_spec.ts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40051 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 182905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182905&action=edit Bug 40051: Remove cy.wait(delay) from cypress tests We should not use cy.wait(delay), it's a poor pattern and can cause random failures. Test plan: All cypress tests should still pass after this patchset. Note that t/cypress/integration/ERM/Titles_spec.ts is currently failing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40051 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@openfifth.co.u | |k Status|NEW |ASSIGNED --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- I've asked Pedro to have a look at Titles_spec.ts. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40051 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |BLOCKED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40051 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182905|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 183835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183835&action=edit Bug 40051: Remove cy.wait(delay) from cypress tests We should not use cy.wait(delay), it's a poor pattern and can cause random failures. Test plan: All cypress tests should still pass after this patchset. Note that t/cypress/integration/ERM/Titles_spec.ts is currently failing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40051 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40051 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183835|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 183836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183836&action=edit Bug 40051: Remove cy.wait(delay) from cypress tests We should not use cy.wait(delay), it's a poor pattern and can cause random failures. Test plan: All cypress tests should still pass after this patchset. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40051 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- All tests passing now (on top of "Bug 38899: Fix Cypress tests" not pushed yet). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40051 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40051 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183836|0 |1 is obsolete| | --- Comment #6 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 183863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183863&action=edit Bug 40051: Remove cy.wait(delay) from cypress tests We should not use cy.wait(delay), it's a poor pattern and can cause random failures. Test plan: All cypress tests should still pass after this patchset. Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40051 --- Comment #7 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 183864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183864&action=edit Bug 40051: Remove 'only' from KohaTable_spec.ts Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40051 --- Comment #8 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- InfiniteScrollSelect_spec.ts failed for me the first time: 1) Infinite scroll Should correctly display labels: CypressError: Timed out retrying after 10000ms: `cy.wait()` timed out waiting `10000ms` for the 1st request to the route: `getPageTwo`. No request ever occurred. But it doesn't seem related to this patchset and I wasn't able to get it to fail again. Also not related to this patchset, but ManageMarcImport_spec.ts still fails for me consistently (3/3): 1) loads the manage MARC import page upload a MARC record: AssertionError: Timed out retrying after 10000ms: Expected to find content: 'View batch' but never did. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40051 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40051 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183863|0 |1 is obsolete| | --- Comment #9 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 184999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184999&action=edit Bug 40051: Remove cy.wait(delay) from cypress tests We should not use cy.wait(delay), it's a poor pattern and can cause random failures. Test plan: All cypress tests should still pass after this patchset. Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40051 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183864|0 |1 is obsolete| | --- Comment #10 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 185000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185000&action=edit Bug 40051: Remove 'only' from KohaTable_spec.ts Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40051 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40051 --- Comment #11 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40051 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.03 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40051 --- Comment #12 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40051 Bug 40051 depends on bug 40046, which changed state. Bug 40046 Summary: Remove wait and screenshot from Tools/ManageMarcImport_spec.ts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40046 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40051 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 40046 not in 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40051 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #14 from David Nind <david@davidnind.com> --- Test suite related, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org