[Bug 6329] New: patron categories should show which fields are required
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6329 Bug #: 6329 Summary: patron categories should show which fields are required Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Templates AssignedTo: oleonard@myacpl.org ReportedBy: nengard@gmail.com QAContact: koha-bugs@lists.koha-community.org Created attachment 4076 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4076 error about required fields not being filled in When you're adding or editing patron category the required fields aren't marked as required. There should be a red start or some sort of indication of what fields are required. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6329 --- Comment #1 from Nicole C. Engard <nengard@gmail.com> 2011-05-11 16:18:56 UTC --- Created attachment 4077 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4077 all possible errors/required fields -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6329 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Severity|enhancement |normal -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6329 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6329 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 18135 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18135&action=edit Bug 6329 - patron categories should show which fields are required When entering a new patron category, required fields are not indicated on the entry form. This patch adds the "required" class to the relevant labels. To test, add or edit a patron category. Confirm that the required fields (category code, category type, description, and enrollment period) are indicated as being required with a red label. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6329 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18135|0 |1 is obsolete| | --- Comment #3 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 18139 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18139&action=edit [SIGNED-OFF] Bug 6329 - patron categories should show which fields are required When entering a new patron category, required fields are not indicated on the entry form. This patch adds the "required" class to the relevant labels. To test, add or edit a patron category. Confirm that the required fields (category code, category type, description, and enrollment period) are indicated as being required with a red label. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6329 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6329 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6329 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18139|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 18141 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18141&action=edit [PASSED QA] Bug 6329 - patron categories should show which fields are required When entering a new patron category, required fields are not indicated on the entry form. This patch adds the "required" class to the relevant labels. To test, add or edit a patron category. Confirm that the required fields (category code, category type, description, and enrollment period) are indicated as being required with a red label. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works nicely. Template changes only, but no string changes. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6329 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org